Issue metadata
Sign in to add a comment
|
Crash in EULA screen with committed interstitials. |
||||||||||||||||||||||
Issue descriptionIf an interstitial is triggered in the EULA webview shown on the Chrome OS OOBE (for example due to a captive portal), the load is aborted. This can trigger a crash, due to race conditions causing the Browser Context to be null in SSLErrorHandler::HandleSSLError.
,
Dec 6
Requesting merge approval for 72, though the bug is relatively rare, considering the fix is very low risk (add a missing null check), it'd be nice to have it fixed before launching.
,
Dec 7
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9658fae1bde3433ca09ed4da6b3b31c32b637888 commit 9658fae1bde3433ca09ed4da6b3b31c32b637888 Author: Carlos IL <carlosil@chromium.org> Date: Fri Dec 07 19:50:51 2018 Add check for profile in HandleSSLError. There are edge cases in which HandleSSLError can be called without a browser context, make sure it returns instead of crashing. This was causing a crash with committed interstitials enabled if an interstitial was shown in the EULA screen on the first run. Bug:911855 Change-Id: I030eb7269c1a3ed1388d159a6cfea069c09d0532 Reviewed-on: https://chromium-review.googlesource.com/c/1359827 Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614047}(cherry picked from commit 4498310486ff183b27eb250a5ffe3a8ce7325dc6) Reviewed-on: https://chromium-review.googlesource.com/c/1368445 Reviewed-by: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#147} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/9658fae1bde3433ca09ed4da6b3b31c32b637888/chrome/browser/ssl/ssl_error_handler.cc
,
Dec 7
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9658fae1bde3433ca09ed4da6b3b31c32b637888 Commit: 9658fae1bde3433ca09ed4da6b3b31c32b637888 Author: carlosil@chromium.org Commiter: carlosil@chromium.org Date: 2018-12-07 19:50:51 +0000 UTC Add check for profile in HandleSSLError. There are edge cases in which HandleSSLError can be called without a browser context, make sure it returns instead of crashing. This was causing a crash with committed interstitials enabled if an interstitial was shown in the EULA screen on the first run. Bug:911855 Change-Id: I030eb7269c1a3ed1388d159a6cfea069c09d0532 Reviewed-on: https://chromium-review.googlesource.com/c/1359827 Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614047}(cherry picked from commit 4498310486ff183b27eb250a5ffe3a8ce7325dc6) Reviewed-on: https://chromium-review.googlesource.com/c/1368445 Reviewed-by: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#147} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 5