New issue
Advanced search Search tips

Issue 911842 link

Starred by 1 user
Status: Fixed
Owner:
ftirelo@chromium.org
Closed: Dec 11
Cc:
se...@chromium.org
ftirelo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Add metrics to track how often the Autofill dropdown is suppressed

Project Member Reported by ftirelo@chromium.org, Dec 4 
Chrome Version: M72+
OS: All

Follow up of crbug.com/905081 to track how often we don't show the dropdown because there is no parent view available or because there is not enough vertical screen space.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94e5b0de9fa84eff91b8be53a0011002e897f880

commit 94e5b0de9fa84eff91b8be53a0011002e897f880
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Mon Dec 10 17:17:41 2018

[AF] Add metrics to track dropdown suppressed

This is a follow-up of crrev.com/c/1346734 to allow us measure how
often suppression happens with the new dropdown.

Bug:  911842 
Change-Id: I7519a7867b6de99998df55acab5bbb0df00668e3
Reviewed-on: https://chromium-review.googlesource.com/c/1362292
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615153}
[modify] https://crrev.com/94e5b0de9fa84eff91b8be53a0011002e897f880/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
[modify] https://crrev.com/94e5b0de9fa84eff91b8be53a0011002e897f880/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc
[modify] https://crrev.com/94e5b0de9fa84eff91b8be53a0011002e897f880/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/94e5b0de9fa84eff91b8be53a0011002e897f880/components/autofill/core/browser/autofill_external_delegate.h
[modify] https://crrev.com/94e5b0de9fa84eff91b8be53a0011002e897f880/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/94e5b0de9fa84eff91b8be53a0011002e897f880/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/94e5b0de9fa84eff91b8be53a0011002e897f880/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/94e5b0de9fa84eff91b8be53a0011002e897f880/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/94e5b0de9fa84eff91b8be53a0011002e897f880/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/94e5b0de9fa84eff91b8be53a0011002e897f880/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/94e5b0de9fa84eff91b8be53a0011002e897f880/components/autofill/core/browser/autofill_popup_delegate.h
[modify] https://crrev.com/94e5b0de9fa84eff91b8be53a0011002e897f880/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/94e5b0de9fa84eff91b8be53a0011002e897f880/components/password_manager/core/browser/password_autofill_manager.h
[modify] https://crrev.com/94e5b0de9fa84eff91b8be53a0011002e897f880/tools/metrics/histograms/enums.xml

Comment 2 by se...@chromium.org, Dec 10

Cc: se...@chromium.org
Labels: Merge-Request-72
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 11

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 11

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5d1b978096cad836ef4d8ae98331b5ef3850252

commit a5d1b978096cad836ef4d8ae98331b5ef3850252
Author: sebsg <sebsg@chromium.org>
Date: Tue Dec 11 18:30:06 2018

Merge-72 [AF] Add metrics to track dropdown suppressed

This is a follow-up of crrev.com/c/1346734 to allow us measure how
often suppression happens with the new dropdown.

TBR=ftirelo@chromium.org

(cherry picked from commit 94e5b0de9fa84eff91b8be53a0011002e897f880)

Bug:  911842 
Change-Id: I7519a7867b6de99998df55acab5bbb0df00668e3
Reviewed-on: https://chromium-review.googlesource.com/c/1362292
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615153}
Reviewed-on: https://chromium-review.googlesource.com/c/1371935
Cr-Commit-Position: refs/branch-heads/3626@{#255}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/a5d1b978096cad836ef4d8ae98331b5ef3850252/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
[modify] https://crrev.com/a5d1b978096cad836ef4d8ae98331b5ef3850252/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc
[modify] https://crrev.com/a5d1b978096cad836ef4d8ae98331b5ef3850252/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/a5d1b978096cad836ef4d8ae98331b5ef3850252/components/autofill/core/browser/autofill_external_delegate.h
[modify] https://crrev.com/a5d1b978096cad836ef4d8ae98331b5ef3850252/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/a5d1b978096cad836ef4d8ae98331b5ef3850252/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/a5d1b978096cad836ef4d8ae98331b5ef3850252/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/a5d1b978096cad836ef4d8ae98331b5ef3850252/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/a5d1b978096cad836ef4d8ae98331b5ef3850252/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/a5d1b978096cad836ef4d8ae98331b5ef3850252/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/a5d1b978096cad836ef4d8ae98331b5ef3850252/components/autofill/core/browser/autofill_popup_delegate.h
[modify] https://crrev.com/a5d1b978096cad836ef4d8ae98331b5ef3850252/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/a5d1b978096cad836ef4d8ae98331b5ef3850252/components/password_manager/core/browser/password_autofill_manager.h
[modify] https://crrev.com/a5d1b978096cad836ef4d8ae98331b5ef3850252/tools/metrics/histograms/enums.xml

Comment 5 by se...@chromium.org, Dec 11

Status: Fixed (was: Assigned)
Project Member

Comment 6 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/a5d1b978096cad836ef4d8ae98331b5ef3850252

Commit: a5d1b978096cad836ef4d8ae98331b5ef3850252
Author: sebsg@chromium.org
Commiter: sebsg@chromium.org
Date: 2018-12-11 18:30:06 +0000 UTC

Merge-72 [AF] Add metrics to track dropdown suppressed

This is a follow-up of crrev.com/c/1346734 to allow us measure how
often suppression happens with the new dropdown.

TBR=ftirelo@chromium.org

(cherry picked from commit 94e5b0de9fa84eff91b8be53a0011002e897f880)

Bug:  911842 
Change-Id: I7519a7867b6de99998df55acab5bbb0df00668e3
Reviewed-on: https://chromium-review.googlesource.com/c/1362292
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615153}
Reviewed-on: https://chromium-review.googlesource.com/c/1371935
Cr-Commit-Position: refs/branch-heads/3626@{#255}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
►

Sign in to add a comment