New issue
Advanced search Search tips

Issue 911837 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 4
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Page performance metrics names are not visible on the flamechart.

Project Member Reported by alph@chromium.org, Dec 4

Issue description

Page performance metrics names are not visible on the flamechart.
 
Status: Fixed (was: Assigned)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82dab725a234f06178b5c2fd956136256cd466e5

commit 82dab725a234f06178b5c2fd956136256cd466e5
Author: Alexei Filippov <alph@chromium.org>
Date: Fri Nov 30 01:53:56 2018

DevTools: Move page metric events on performance panel out of experiment.

BUG= 901165 

Change-Id: I1788e537ed29bab14558d12372bda59f2bfa8698
Reviewed-on: https://chromium-review.googlesource.com/c/1352850
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612505}
[modify] https://crrev.com/82dab725a234f06178b5c2fd956136256cd466e5/third_party/blink/renderer/devtools/front_end/main/Main.js
[modify] https://crrev.com/82dab725a234f06178b5c2fd956136256cd466e5/third_party/blink/renderer/devtools/front_end/perf_ui/FlameChart.js
[modify] https://crrev.com/82dab725a234f06178b5c2fd956136256cd466e5/third_party/blink/renderer/devtools/front_end/timeline/TimelineFlameChartDataProvider.js
[modify] https://crrev.com/82dab725a234f06178b5c2fd956136256cd466e5/third_party/blink/renderer/devtools/front_end/timeline/TimelineFlameChartView.js
[modify] https://crrev.com/82dab725a234f06178b5c2fd956136256cd466e5/third_party/blink/renderer/devtools/front_end/timeline/TimelinePanel.js
[modify] https://crrev.com/82dab725a234f06178b5c2fd956136256cd466e5/third_party/blink/renderer/devtools/front_end/timeline/TimelineUIUtils.js
[modify] https://crrev.com/82dab725a234f06178b5c2fd956136256cd466e5/third_party/blink/web_tests/http/tests/devtools/tracing/timeline-misc/timeline-page-metrics.js
[modify] https://crrev.com/82dab725a234f06178b5c2fd956136256cd466e5/third_party/blink/web_tests/http/tests/devtools/tracing/timeline-misc/timeline-search-expected.txt
[modify] https://crrev.com/82dab725a234f06178b5c2fd956136256cd466e5/third_party/blink/web_tests/http/tests/devtools/tracing/timeline-misc/timeline-search.js

Labels: Merge-Request-72
Labels: OS-Linux OS-Mac OS-Windows
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 5

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Dec 10

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Dec 14

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-72 merge-merged-3626

Sign in to add a comment