New issue
Advanced search Search tips

Issue 911831 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Unable to launch feedback window on sign-in screen

Project Member Reported by sdantul...@chromium.org, Dec 4

Issue description

ChromeOS  11316.1.0, 72.0.3626.0  dev-channel  eve

What steps will reproduce the problem?
1. Device on sign-in screen
2. Use Alt + Shift + i shortcut to show feedback window

What is the expected result?
Feedback window should be displayed

What happens instead?
Nothing happens.

 
Labels: -Pri-2 ReleaseBlock-Stable Pri-1
Labels: Hotlist-ConOps-CrOS
Owner: afakhry@chromium.org
Really RBS?
Cc: r...@chromium.org
Status: WontFix (was: Untriaged)
This is WAI. We disabled feedback in sign in screen.
Cc: afakhry@chromium.org jessejames@google.com
Labels: -Pri-1 -ReleaseBlock-Stable -M-72 M-73 Pri-2
Owner: jdufault@chromium.org
Status: Assigned (was: WontFix)
We disabled it due to security concerns. I think this is still valuable, we just need to lock down the UI.

Cc: tbarzic@chromium.org
Toni's work on deleting the login profile post sign-in should help here.

Comment 7 by jessejames@chromium.org, Jan 17 (5 days ago)

Cc: jessejames@chromium.org
As part of http://requiem/pm/postmortem112953, we identified re-enabling feedback on the login screen to be an open AI we'd like to implement soon.

Is there anything I can help with on the UI/product definition side?

Comment 8 by r...@chromium.org, Jan 17 (5 days ago)

Cc: jdufault@chromium.org
Labels: -Pri-2 -M-73 M-74 Pri-1
Owner: afakhry@chromium.org

Comment 9 by afakhry@chromium.org, Jan 18 (5 days ago)

Owner: andrewxu@chromium.org
Andrew, can you please handle this task?
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b26c88708e870a2e3bfe94a71f1323fcccbddf39

commit b26c88708e870a2e3bfe94a71f1323fcccbddf39
Author: Andrew Xu <andrewxu@chromium.org>
Date: Fri Jan 18 18:02:41 2019

Show feedback app on sign-in screen

Revert the earlier CL (CL#: 1332264) which disabled
the feedback app on sign-in screen, to
activate this function again.

Change-Id: I98310f536c78ca9141a7da0c40c35e88a759b3d5
Test: none
Bug:  911831 
Reviewed-on: https://chromium-review.googlesource.com/c/1419838
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624198}
[modify] https://crrev.com/b26c88708e870a2e3bfe94a71f1323fcccbddf39/chrome/browser/chromeos/login/ui/login_feedback.cc
[modify] https://crrev.com/b26c88708e870a2e3bfe94a71f1323fcccbddf39/chrome/browser/chromeos/login/ui/login_feedback.h
[modify] https://crrev.com/b26c88708e870a2e3bfe94a71f1323fcccbddf39/chrome/browser/chromeos/login/ui/login_feedback_browsertest.cc
[modify] https://crrev.com/b26c88708e870a2e3bfe94a71f1323fcccbddf39/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Comment 11 by andrewxu@chromium.org, Jan 18 (4 days ago)

Status: Fixed (was: Assigned)

Sign in to add a comment