New issue
Advanced search Search tips

Issue 911821 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 5
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DummyProofSource in p2p_quic_transport_impl.cc needs to implement GetCertChain

Project Member Reported by rch@chromium.org, Dec 4

Issue description

Recent changes to core QUIC code call GetCertChain during the handshake, and DummyProofSource needs to be modified accordingly.
 
Owner: rch@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1c6a0c1985aae3d9844fe2ee75ff7919fed0ee3

commit d1c6a0c1985aae3d9844fe2ee75ff7919fed0ee3
Author: Ryan Hamilton <rch@chromium.org>
Date: Wed Dec 05 00:20:43 2018

Flip FLAGS_quic_reloadable_flag_quic_use_get_cert_chain

Also implement GetCertChain in DummyProofSource.
BUG= 911821 

Change-Id: I9907078166f097eadbd6c778fafba1efef7260e2
Reviewed-on: https://chromium-review.googlesource.com/c/1357355
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613781}
[modify] https://crrev.com/d1c6a0c1985aae3d9844fe2ee75ff7919fed0ee3/net/quic/quic_flags_list.h
[modify] https://crrev.com/d1c6a0c1985aae3d9844fe2ee75ff7919fed0ee3/third_party/blink/renderer/modules/peerconnection/adapters/p2p_quic_transport_impl.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment