New issue
Advanced search Search tips

Issue 911814 link

Starred by 1 user
Status: Verified
Owner:
yuweih@chromium.org
Closed: Jan 5
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

[Remoting Windows] Can't reinstall host

Project Member Reported by yuweih@google.com, Dec 4 
In some cases we'd like the user to be able to reinstall the host by rerunning the MSI file, say the user had deleted the host service manually and they need to reinstall to repair. User currently can fix that by installing a newer host version, but rerunning the MSI with the current host version doesn't do anything.

OTOH rerunning installers on Mac and Linux works and fixes issues caused by broken components.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6e0f15037152467ea2b8ed435f46d0c5cf68966

commit d6e0f15037152467ea2b8ed435f46d0c5cf68966
Author: Yuwei Huang <yuweih@chromium.org>
Date: Fri Dec 14 21:58:52 2018

[Remoting Windows installer] Set REINSTALL and REINSTALLMODE properties for reinstallation

We saw a few users having problem starting the host because the host service
has been removed while the native messaging host is still there. On other
platforms this can be fixed by reinstalling the host, but rerunning the MSI on
Windows does nothing unless it's an upgrade.

This CL adds the REINSTALL and REINSTALLMODE properties to the installer if the
user tries to rerun the MSI, so that the installer will forcibly reinstall all
files and services.

Bug:  911814 
Change-Id: Ic25f3d54f2ff34ea61e7aeb7f9fa92b6255cc423
Reviewed-on: https://chromium-review.googlesource.com/c/1363900
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616838}
[modify] https://crrev.com/d6e0f15037152467ea2b8ed435f46d0c5cf68966/remoting/host/installer/win/chromoting.wxs

Comment 2 by yuweih@chromium.org, Jan 5

Owner: ajnolley@chromium.org
Status: Fixed (was: Assigned)
Hi AJ, could you do a test pass for the Windows host installer following the instructions here:
https://docs.google.com/document/d/11ykUrnqT_webLSu1QOdghg8-JO5shKZRqFw_C5a9zyM/edit?usp=sharing

Let me know if you have any questions. Thanks!

Comment 3 by ajnolley@google.com, Jan 9

Owner: yuweih@chromium.org
Status: Verified (was: Fixed)
Hi Yuwei, All done and worked great. Some of the host version numbering doesn't match, between the download links and references in the doc. I used the versions linked for download. Let me know if those are not correct.

Comment 4 by yuweih@chromium.org, Jan 9 

Thank you AJ! 3658 and 3660 are M73 builds so I just mislabeled them :P
►

Sign in to add a comment