New issue
Advanced search Search tips

Issue 911807 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Dec 6
Cc:
xixuan@chromium.org
ayatane@chromium.org
pprabhu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

"Data migrated" commit messages are not informative

Project Member Reported by akes...@chromium.org, Dec 4 
git log is full of these, but they are not at all informative about what data was migrated to/from where.

~/chromiumos/infra_internal/skylab_inventory/staging$ git log
commit 6f4914b1554db47a35f1708e4020a5ca5751a4a9
Author: chromeos-test <chromeos-test@google.com>
Date:   Tue Dec 4 13:23:15 2018 -0800

    Data migrated

commit a28cf1df90bef1b4943e00232fbaad2e0adf5cea
Author: chromeos-test <chromeos-test@google.com>
Date:   Tue Dec 4 13:02:46 2018 -0800

    Data migrated

commit d31bf1d5879c5cbf5c73fe8ed7c271c18cc6d5ae
Author: chromeos-test <chromeos-test@google.com>
Date:   Tue Dec 4 12:42:18 2018 -0800

    Data migrated

commit f3d59d1c3fa5fdd324f933816f47924d05542359
Author: chromeos-test <chromeos-test@google.com>
Date:   Tue Dec 4 12:20:19 2018 -0800

    Data migrated

commit f15fb9af6120968e97811609b614fc7261dd3168
Author: chromeos-test <chromeos-test@google.com>
Date:   Tue Dec 4 11:59:24 2018 -0800

    Data migrated

commit 331982cbae9deb582b357c8c8d38947b9b8763c4
Author: chromeos-test <chromeos-test@google.com>
Date:   Tue Dec 4 11:38:31 2018 -0800

    Data migrated

Comment 1 by ayatane@chromium.org, Dec 5

Labels: Hotlist-Skylab Hotlist-Fixit
Status: Available (was: Untriaged)

Comment 2 by ayatane@chromium.org, Dec 5 

To clarify, this is just to make it "Automated data migration from Autotest AFE" or some such?

Comment 3 by akes...@chromium.org, Dec 5 

Sure, that would help.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/skylab_inventory/+/8c18a16721dfc79f7828bd8f57488152ce839cf3

commit 8c18a16721dfc79f7828bd8f57488152ce839cf3
Author: Allen Li <ayatane@google.com>
Date: Thu Dec 06 01:17:52 2018

Improve commit message for upsync

BUG= chromium:911807 
TEST=None

Change-Id: I2e443306dde284a776093f281d66892e274aae55
Reviewed-on: https://chromium-review.googlesource.com/1364255
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/8c18a16721dfc79f7828bd8f57488152ce839cf3/venv/skylab_inventory/scripts/upsync.py

Comment 5 by ayatane@chromium.org, Dec 6

Status: Fixed (was: Available)
►

Sign in to add a comment