New issue
Advanced search Search tips

Issue 911802 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 902446

Blocking:
issue 911643
issue 914491



Sign in to add a comment

TouchActionBrowserTest.DefaultAuto/1 fails with SkRenderer,SkDDL

Project Member Reported by backer@chromium.org, Dec 4

Issue description

Does not fail with just SkRenderer.

$ out/linux_rel/content_browsertests  --enable-features=VizDisplayCompositor,UseSkiaRenderer,UseSkiaDeferredDisplayList --gtest_filter=TouchActionBrowserTest.DefaultAuto/1
IMPORTANT DEBUGGING NOTE: each test is run inside its own process.
For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with either
--single_process (to run the test in one launcher/browser process) or
--single-process (to do the above, and also run Chrome in single-process mode).
Using sharding settings from environment. This is shard 0/1
Using 1 parallel jobs.
Note: Google Test filter = TouchActionBrowserTest.DefaultAuto/1
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from TouchActionBrowserTest
[ RUN      ] TouchActionBrowserTest.DefaultAuto/1

DevTools listening on ws://127.0.0.1:43693/devtools/browser/5ecaee62-162b-41dd-8c6e-41304ff43f93
[143008:143060:1204/163030.221480:ERROR:skia_output_surface_impl.cc(260)] Not implemented reached in virtual void viz::SkiaOutputSurfaceImpl::EnsureBackbuffer()
../../content/browser/renderer_host/input/touch_action_browsertest.cc:435: Failure
Expected: (expected_scroll_position_after_scroll.y() / 2) <= (scroll_top), actual: 22 vs 0
Stack trace:
#0 0x55f7386d87dc testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop()
#1 0x55f7386d81b9 testing::internal::AssertHelper::operator=()
#2 0x55f73837d16a content::TouchActionBrowserTest::CheckScrollOffset()
#3 0x55f73837ae02 content::TouchActionBrowserTest::DoTouchScroll()
#4 0x55f73837a1a9 content::TouchActionBrowserTest_DefaultAuto_Test::RunTestOnMainThread()
#5 0x55f73881fc07 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#6 0x55f73887fa26 content::ShellBrowserMainParts::PreMainMessageLoopRun()
#7 0x7f28668c1fe5 content::BrowserMainLoop::PreMainMessageLoopRun()
#8 0x7f2866e02495 content::StartupTaskRunner::RunAllTasksNow()
#9 0x7f28668c0d09 content::BrowserMainLoop::CreateStartupTasks()
#10 0x7f28668c48a6 content::BrowserMainRunnerImpl::Initialize()
#11 0x55f73887d4da ShellBrowserMain()
#12 0x55f738875b90 content::ShellMainDelegate::RunProcess()
#13 0x7f286741cf2b content::ContentMainRunnerImpl::RunServiceManager()
#14 0x7f286741cdf6 content::ContentMainRunnerImpl::Run()
#15 0x7f285b9bf47a service_manager::Main()
#16 0x7f286741b0f1 content::ContentMain()
#17 0x55f73881f79e content::BrowserTestBase::SetUp()

[142987:142997:1204/163030.422112:WARNING:discardable_shared_memory_manager.cc(410)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked.
[142987:143087:1204/163030.433237:WARNING:internal_linux.cc(64)] Failed to read /proc/143008/stat
[  FAILED  ] TouchActionBrowserTest.DefaultAuto/1, where GetParam() = true (1564 ms)
[----------] 1 test from TouchActionBrowserTest (1564 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (1564 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] TouchActionBrowserTest.DefaultAuto/1, where GetParam() = true

 1 FAILED TEST
[1204/163031.082756:ERROR:kill_posix.cc(84)] Unable to terminate process group 142987: No such process (3)
[1/1] TouchActionBrowserTest.DefaultAuto/1 (2097 ms)
1 test failed:
    TouchActionBrowserTest.DefaultAuto/1 (../../content/browser/renderer_host/input/touch_action_browsertest.cc:449)
 
Blocking: 911643
Peng: I assigned to you because it passes with SkRenderer but fails with SkRenderer,SkDDL. It really could be anything though (e.g. race). Please triage.
Blocking: 914491
Cc: bokan@chromium.org
Owner: backer@chromium.org
Blockedon: 902446
I looked into this and it seems like a race. Only fails these expectations: https://cs.chromium.org/chromium/src/content/browser/renderer_host/input/touch_action_browsertest.cc?rcl=0a45d6ae77963eee78e7a4aff69ed26e48913743&l=434

So maybe blocked on issue 902446.

Sign in to add a comment