https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/probe/core_probes.cc?q=AsyncTask::AsyncTask&sq=package:chromium&dr=CSs&l=50 Sometimes blink::probe::AsyncTask() and blink::probe::AsyncTaskScheduled() are passed in Execution contexts that are nullptrs. This makes the API inconsistent. Investigate why.
Issue 912533 has been merged into this issue.
Automatically applying components based on crash stacktrace and information from OWNERS files. If this is incorrect, please apply the Test-Predator-Wrong-Components label.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32929f531a58a3cadf185d351d1a3382863fa062 commit 32929f531a58a3cadf185d351d1a3382863fa062 Author: Ryan Tseng <hinoka@google.com> Date: Tue Dec 11 06:11:19 2018 Reland: Replace blink::ToIsolate(ExecutionContext) with blink::ExecutionContext->GetIsolate() And remove blink::ToIsolate(ExecutionContext) altogether. Originally https://chromium-review.googlesource.com/c/chromium/src/+/1355944 The difference is added checks in: * AsyncTaskCanceled * AllAsyncTasksCanceled for nullptr ExecutionContext. Bug: 889542 , 911800 Change-Id: Icef90fadbc89019118119f044dde8f10ddffa72f Reviewed-on: https://chromium-review.googlesource.com/c/1366358 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#615445} [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/bindings/core/v8/script_event_listener.cc [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/bindings/core/v8/script_promise_property_base.cc [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/bindings/core/v8/script_promise_property_test.cc [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.cc [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/bindings/core/v8/v8_binding_for_core.h [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/core/frame/csp/content_security_policy.cc [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/core/html/html_frame_element_base.cc [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/core/messaging/message_port.cc [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/core/probe/core_probes.cc [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/core/trustedtypes/trusted_types_util.cc [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/core/workers/dedicated_worker.cc [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/core/workers/dedicated_worker_messaging_proxy.cc [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/core/workers/experimental/task.cc [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/modules/indexeddb/idb_key_range.cc [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/modules/payments/abort_payment_respond_with_observer.cc [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/modules/payments/can_make_payment_respond_with_observer.cc [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/modules/payments/payment_request_respond_with_observer.cc [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/modules/service_worker/fetch_respond_with_observer.cc [modify] https://crrev.com/32929f531a58a3cadf185d351d1a3382863fa062/third_party/blink/renderer/modules/time_zone_monitor/time_zone_monitor_client.cc
core_probes.cc now handles nullptr contexts for all methods.
Comment 1 by hinoka@chromium.org
, Dec 6