Chrome Duet IPH needs to wait for tracker initialization. |
||||||
Issue descriptionDuet's IPH has a race condition that can prevent the IPH from showing. Since the tracker is lazily loaded and Duet IPH is usually the first thing to appear, it is possible that the tracker isn't ready.
,
Dec 4
,
Dec 5
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d04f0ad8d47d55eae9dbb4fd3efd35e06722fde commit 7d04f0ad8d47d55eae9dbb4fd3efd35e06722fde Author: Matthew Jones <mdjones@chromium.org> Date: Thu Dec 06 00:02:19 2018 Wait for tracker to be ready before showing Duet IPH This patch fixes an issue where Duet was attempting to query the IPH tracker prior to it being completely initialized. The fix is simply wrapping the IPH trigger in an init callback. TBR=mdjones@chromium.org (cherry picked from commit fb8d248a0adb62b5934e90c011cf44ab6545bc81) Bug: 911797 Change-Id: Ie5e375fa2dde14a441ea260cb70d48150e3c1d7b Reviewed-on: https://chromium-review.googlesource.com/c/1361864 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613730} Reviewed-on: https://chromium-review.googlesource.com/c/1364168 Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#95} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/7d04f0ad8d47d55eae9dbb4fd3efd35e06722fde/chrome/android/java/src/org/chromium/chrome/browser/toolbar/bottom/BrowsingModeBottomToolbarCoordinator.java
,
Dec 6
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d04f0ad8d47d55eae9dbb4fd3efd35e06722fde Commit: 7d04f0ad8d47d55eae9dbb4fd3efd35e06722fde Author: mdjones@chromium.org Commiter: mdjones@chromium.org Date: 2018-12-06 00:02:19 +0000 UTC Wait for tracker to be ready before showing Duet IPH This patch fixes an issue where Duet was attempting to query the IPH tracker prior to it being completely initialized. The fix is simply wrapping the IPH trigger in an init callback. TBR=mdjones@chromium.org (cherry picked from commit fb8d248a0adb62b5934e90c011cf44ab6545bc81) Bug: 911797 Change-Id: Ie5e375fa2dde14a441ea260cb70d48150e3c1d7b Reviewed-on: https://chromium-review.googlesource.com/c/1361864 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613730} Reviewed-on: https://chromium-review.googlesource.com/c/1364168 Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#95} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Dec 4