New issue
Advanced search Search tips

Issue 911793 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 911643



Sign in to add a comment

Make SnapshotBrowserTest.AsyncMultiWindowTest pass with SkRenderer,SkDDL

Project Member Reported by backer@chromium.org, Dec 4

Issue description

We fail a CHECK with SkDDL. Test passes with SkRenderer and no SkDDL

out/linux_rel/content_browsertests  --enable-features=VizDisplayCompositor,UseSkiaRenderer,UseSkiaDeferredDisplayList --gtest_filter=SnapshotBrowserTest.AsyncMultiWindowTest
IMPORTANT DEBUGGING NOTE: each test is run inside its own process.
For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with either
--single_process (to run the test in one launcher/browser process) or
--single-process (to do the above, and also run Chrome in single-process mode).
Using sharding settings from environment. This is shard 0/1
Using 1 parallel jobs.
Note: Google Test filter = SnapshotBrowserTest.AsyncMultiWindowTest
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from SnapshotBrowserTest, where TypeParam = 
[ RUN      ] SnapshotBrowserTest.AsyncMultiWindowTest

DevTools listening on ws://127.0.0.1:46785/devtools/browser/1691f1f9-8042-4540-99b0-cca37be56656
[137637:137684:1204/161255.076847:ERROR:skia_output_surface_impl.cc(260)] Not implemented reached in virtual void viz::SkiaOutputSurfaceImpl::EnsureBackbuffer()
[137637:137684:1204/161255.249865:ERROR:skia_output_surface_impl.cc(260)] Not implemented reached in virtual void viz::SkiaOutputSurfaceImpl::EnsureBackbuffer()
[137637:137684:1204/161255.268552:ERROR:skia_output_surface_impl.cc(260)] Not implemented reached in virtual void viz::SkiaOutputSurfaceImpl::EnsureBackbuffer()
[137637:137684:1204/161255.323034:ERROR:skia_output_surface_impl.cc(260)] Not implemented reached in virtual void viz::SkiaOutputSurfaceImpl::EnsureBackbuffer()
[137637:137684:1204/161255.578652:FATAL:skia_output_surface_impl.cc(366)] Check failed: !recorder_. 
#0 0x7f69e214a13f base::debug::StackTrace::StackTrace()
#1 0x7f69e206e1eb logging::LogMessage::~LogMessage()
#2 0x7f69d79dc03d viz::SkiaOutputSurfaceImpl::BeginPaintCurrentFrame()
#3 0x7f69d797309d viz::SkiaRenderer::BindFramebufferToOutputSurface()
#4 0x7f69d7932b04 viz::DirectRenderer::UseRenderPass()
#5 0x7f69d7931f35 viz::DirectRenderer::DrawRenderPass()
#6 0x7f69d79316db viz::DirectRenderer::DrawRenderPassAndExecuteCopyRequests()
#7 0x7f69d793114e viz::DirectRenderer::DrawFrame()
#8 0x7f69d79373f2 viz::Display::DrawAndSwap()
#9 0x7f69d7946a82 viz::DisplayScheduler::DrawAndSwap()
#10 0x7f69d79461fb viz::DisplayScheduler::AttemptDrawAndSwap()
#11 0x7f69d7945a5c viz::DisplayScheduler::OnBeginFrameDeadline()
#12 0x7f69d79485c4 _ZN4base8internal7InvokerINS0_9BindStateIMN3viz16DisplaySchedulerEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#13 0x7f69d7948bec _ZN4base8internal22CancelableCallbackImplINS_17RepeatingCallbackIFvvEEEE16ForwardRepeatingIJEEEvDpT_
#14 0x7f69d79485c4 _ZN4base8internal7InvokerINS0_9BindStateIMN3viz16DisplaySchedulerEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#15 0x7f69e204ebe9 base::debug::TaskAnnotator::RunTask()
#16 0x7f69e207d4a0 base::MessageLoopImpl::RunTask()
#17 0x7f69e207dc22 base::MessageLoopImpl::DoWork()
#18 0x7f69e207fdba base::MessagePumpDefault::Run()
#19 0x7f69e207cf75 base::MessageLoopImpl::Run()
#20 0x7f69e20b0196 base::RunLoop::Run()
#21 0x7f69e21124da base::Thread::Run()
#22 0x7f69e2112a98 base::Thread::ThreadMain()
#23 0x7f69e2160d98 base::(anonymous namespace)::ThreadFunc()
#24 0x7f69d6ec7494 start_thread
#25 0x7f69d5f44a8f clone

 
Blocking: 911643
Could you take a look at this Peng? It seems like the type of thing that you've debugged before.
Cc: backer@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b80c413d66b8cbc37db662ee9b141691b79c0eae

commit b80c413d66b8cbc37db662ee9b141691b79c0eae
Author: Peng Huang <penghuang@chromium.org>
Date: Thu Dec 06 15:52:45 2018

Fix SnapshotBrowserTest.AsyncMultiWindowTest for SkiaRenderer + DDL

Bug:  911793 
Change-Id: I937e902d7e9ff7e046710558e48e4765b3ec06ee
Reviewed-on: https://chromium-review.googlesource.com/c/1363864
Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614365}
[modify] https://crrev.com/b80c413d66b8cbc37db662ee9b141691b79c0eae/components/viz/service/display/direct_renderer.cc
[modify] https://crrev.com/b80c413d66b8cbc37db662ee9b141691b79c0eae/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/b80c413d66b8cbc37db662ee9b141691b79c0eae/components/viz/service/display/skia_renderer.cc

Status: Fixed (was: Started)

Sign in to add a comment