New issue
Advanced search Search tips

Issue 911784 link

Starred by 1 user
Status: Started
Owner:
est...@chromium.org
Cc:
jamescook@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 888145
issue 916256
issue 916272
issue 905430



Sign in to add a comment

views_unittests and views_mus_unittests should merge

Project Member Reported by est...@chromium.org, Dec 4 
Currently, views_unittests and views_mus_unittests run most of the same tests, but the latter uses DesktopNativeWidgetAura by default and the former uses NativeWidgetAura by default. (There are a few non-overlapping tests as well.)  On Chrome OS, views_unittests always use NWA.

Instead, we should make Chrome OS match Linux and Windows in views_unittests by using NWA by default (and DNWA for tests that explicitly ask for it), and get rid of views_mus_unittests.

We should probably also remove the ui/views/mus/ build targets by folding them into ui/views/.

Comment 1 by jamescook@chromium.org, Dec 4

Blocking: 888145
Cc: jamescook@chromium.org

Comment 2 by sky@chromium.org, Dec 18

Blocking: 916256

Comment 3 by est...@chromium.org, Dec 18

Blocking: 916272
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458

commit bddf4c6eeb6cacaeb012208c84cb88cc9dca3458
Author: Evan Stade <estade@chromium.org>
Date: Fri Dec 21 22:43:21 2018

Merge views_mus_unittests and views_unittests

- Allow testing DesktopNativeWidgetAura on Chrome OS by doing necessary
  Mus setup.
- To accommodate Chrome OS, tests must specify that they will be testing
  desktop widgets before SetUp (for tests that inherit from
  ViewsTestBase). On Chrome OS, these are the tests that provide Mus
  coverage.
- Command line flags are ignored, so views_unittests will perform the
  same tests with and without --enable-features=SingleProcessMash
- Enable some test suites on Chrome OS, such as
  desktop_native_widget_aura_unittest.cc, and some individual tests.

Bug: 911784
Change-Id: Ic3acd21770f07fb8298a172dc556b3fa036d6791
Reviewed-on: https://chromium-review.googlesource.com/c/1378666
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618646}
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/BUILD.gn
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/chrome/browser/ui/views/infobars/infobar_view_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/chrome/browser/ui/views/media_router/cast_toolbar_button_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/chrome/browser/ui/views/media_router/cloud_services_dialog_view_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/chrome/browser/ui/views/menu_interactive_uitest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/chrome/browser/ui/views/message_center/popups_only_ui_delegate_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/chrome/test/views/chrome_views_test_base.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/components/constrained_window/BUILD.gn
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/content/public/test/test_launcher.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/base/clipboard/clipboard_test_template.h
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/base/clipboard/clipboard_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/base/test/test_clipboard_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/BUILD.gn
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/DEPS
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/OWNERS
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/accessibility/ax_system_caret_win_interactive_uitest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/accessible_pane_view_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/animation/ink_drop_impl_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/cocoa/bridged_native_widget_interactive_uitest.mm
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/controls/button/menu_button_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/controls/menu/menu_controller_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/controls/menu/menu_runner_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/controls/native/native_view_host_aura_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/controls/webview/webview_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/corewm/DEPS
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/corewm/desktop_capture_controller_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/corewm/tooltip_controller_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/event_monitor_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/focus/focus_manager_unittest.cc
[rename] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/interactive_ui_tests_manifest.json
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/layout/grid_layout_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/mus/BUILD.gn
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/mus/DEPS
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/mus/OWNERS
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/mus/ax_remote_host_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/mus/ax_tree_source_mus_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/mus/clipboard_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/mus/desktop_window_tree_host_mus_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/mus/drag_interactive_uitest.cc
[delete] https://crrev.com/f01e9f40e7d86bb59fe09456d673de7ba19d9c11/ui/views/mus/interactive_ui_tests_mus.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/mus/remote_view/remote_view_host_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/mus/remote_view/remote_view_provider_unittest.cc
[delete] https://crrev.com/f01e9f40e7d86bb59fe09456d673de7ba19d9c11/ui/views/mus/run_all_unittests_mus.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/mus/screen_mus_unittest.cc
[delete] https://crrev.com/f01e9f40e7d86bb59fe09456d673de7ba19d9c11/ui/views/mus/views_mus_test_suite.cc
[delete] https://crrev.com/f01e9f40e7d86bb59fe09456d673de7ba19d9c11/ui/views/mus/views_mus_test_suite.h
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/test/DEPS
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/test/focus_manager_test.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/test/focus_manager_test.h
[add] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/test/native_widget_factory.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/test/native_widget_factory.h
[delete] https://crrev.com/f01e9f40e7d86bb59fe09456d673de7ba19d9c11/ui/views/test/native_widget_factory_aura_mus.cc
[delete] https://crrev.com/f01e9f40e7d86bb59fe09456d673de7ba19d9c11/ui/views/test/native_widget_factory_desktop.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/test/platform_test_helper.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/test/platform_test_helper.h
[add] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/test/platform_test_helper_mus.cc
[add] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/test/platform_test_helper_mus.h
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/test/views_interactive_ui_test_base.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/test/views_interactive_ui_test_base.h
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/test/views_test_base.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/test/views_test_base.h
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/test/views_test_helper_aura.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/test/widget_test.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/test/widget_test.h
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/test/widget_test_aura.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/test/widget_test_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/touchui/touch_selection_controller_impl_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/touchui/touch_selection_menu_runner_views_unittest.cc
[rename] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/unittests_manifest.json
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/view_unittest_aura.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/views_test_suite.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/views_test_suite.h
[delete] https://crrev.com/f01e9f40e7d86bb59fe09456d673de7ba19d9c11/ui/views/widget/DEPS
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/widget/desktop_aura/desktop_drag_drop_client_ozone_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/widget/desktop_aura/desktop_focus_rules_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/widget/desktop_widget_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/widget/native_widget_aura_interactive_uitest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/widget/native_widget_mac_interactive_uitest.mm
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/widget/native_widget_mac_unittest.mm
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/widget/native_widget_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/widget/root_view_unittest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/widget/widget_interactive_uitest.cc
[modify] https://crrev.com/bddf4c6eeb6cacaeb012208c84cb88cc9dca3458/ui/views/widget/widget_unittest.cc

Comment 5 by avi@google.com, Dec 24 

Reverting because this change appears to have broken several CrOS bots in that "every test is now failing" way. I suspect it because it touches CrOS build files, and it introduces the string "Unexpectedly ran test more than once: " which appears in the failing output.

See:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9731
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/30663
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/10290
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f9dd378129a97d42fd0db32f8c3c931da9dba6d

commit 6f9dd378129a97d42fd0db32f8c3c931da9dba6d
Author: Avi Drissman <avi@chromium.org>
Date: Mon Dec 24 22:36:30 2018

Revert "Merge views_mus_unittests and views_unittests"

This reverts commit bddf4c6eeb6cacaeb012208c84cb88cc9dca3458.

Reason for revert: linux-chromeos-dbg, Linux Chromium OS ASan LSan Tests (1), and Linux ChromiumOS MSan Tests bots are burning in the "all tests are failing" way. This change touches CrOS in a very suspicious way.

Original change's description:
> Merge views_mus_unittests and views_unittests
>
> - Allow testing DesktopNativeWidgetAura on Chrome OS by doing necessary
>   Mus setup.
> - To accommodate Chrome OS, tests must specify that they will be testing
>   desktop widgets before SetUp (for tests that inherit from
>   ViewsTestBase). On Chrome OS, these are the tests that provide Mus
>   coverage.
> - Command line flags are ignored, so views_unittests will perform the
>   same tests with and without --enable-features=SingleProcessMash
> - Enable some test suites on Chrome OS, such as
>   desktop_native_widget_aura_unittest.cc, and some individual tests.
>
> Bug: 911784
> Change-Id: Ic3acd21770f07fb8298a172dc556b3fa036d6791
> Reviewed-on: https://chromium-review.googlesource.com/c/1378666
> Commit-Queue: Evan Stade <estade@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#618646}

TBR=sky@chromium.org,estade@chromium.org,tsepez@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

NOPRESUBMIT=true

Bug: 911784
Change-Id: Ia2d3ee0931565c6e41c1ded868a2edd0e873870a
Reviewed-on: https://chromium-review.googlesource.com/c/1390427
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618842}
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/BUILD.gn
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/chrome/browser/ui/views/infobars/infobar_view_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/chrome/browser/ui/views/media_router/cast_toolbar_button_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/chrome/browser/ui/views/media_router/cloud_services_dialog_view_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/chrome/browser/ui/views/menu_interactive_uitest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/chrome/browser/ui/views/message_center/popups_only_ui_delegate_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/chrome/test/views/chrome_views_test_base.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/components/constrained_window/BUILD.gn
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/content/public/test/test_launcher.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/base/clipboard/clipboard_test_template.h
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/base/clipboard/clipboard_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/base/test/test_clipboard_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/BUILD.gn
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/DEPS
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/OWNERS
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/accessibility/ax_system_caret_win_interactive_uitest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/accessible_pane_view_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/animation/ink_drop_impl_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/cocoa/bridged_native_widget_interactive_uitest.mm
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/controls/button/menu_button_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/controls/menu/menu_controller_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/controls/menu/menu_runner_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/controls/native/native_view_host_aura_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/controls/webview/webview_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/corewm/DEPS
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/corewm/desktop_capture_controller_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/corewm/tooltip_controller_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/event_monitor_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/focus/focus_manager_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/layout/grid_layout_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/mus/BUILD.gn
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/mus/DEPS
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/mus/OWNERS
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/mus/ax_remote_host_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/mus/ax_tree_source_mus_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/mus/clipboard_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/mus/desktop_window_tree_host_mus_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/mus/drag_interactive_uitest.cc
[rename] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/mus/interactive_ui_tests_manifest.json
[add] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/mus/interactive_ui_tests_mus.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/mus/remote_view/remote_view_host_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/mus/remote_view/remote_view_provider_unittest.cc
[add] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/mus/run_all_unittests_mus.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/mus/screen_mus_unittest.cc
[rename] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/mus/unittests_manifest.json
[add] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/mus/views_mus_test_suite.cc
[add] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/mus/views_mus_test_suite.h
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/test/DEPS
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/test/focus_manager_test.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/test/focus_manager_test.h
[delete] https://crrev.com/ef8bbedcad363d2ec5d9c681114a0ebadff5f4f7/ui/views/test/native_widget_factory.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/test/native_widget_factory.h
[add] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/test/native_widget_factory_aura_mus.cc
[add] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/test/native_widget_factory_desktop.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/test/platform_test_helper.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/test/platform_test_helper.h
[delete] https://crrev.com/ef8bbedcad363d2ec5d9c681114a0ebadff5f4f7/ui/views/test/platform_test_helper_mus.cc
[delete] https://crrev.com/ef8bbedcad363d2ec5d9c681114a0ebadff5f4f7/ui/views/test/platform_test_helper_mus.h
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/test/views_interactive_ui_test_base.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/test/views_interactive_ui_test_base.h
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/test/views_test_base.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/test/views_test_base.h
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/test/views_test_helper_aura.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/test/widget_test.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/test/widget_test.h
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/test/widget_test_aura.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/test/widget_test_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/touchui/touch_selection_controller_impl_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/touchui/touch_selection_menu_runner_views_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/view_unittest_aura.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/views_test_suite.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/views_test_suite.h
[add] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/widget/DEPS
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/widget/desktop_aura/desktop_drag_drop_client_ozone_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/widget/desktop_aura/desktop_focus_rules_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/widget/desktop_widget_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/widget/native_widget_aura_interactive_uitest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/widget/native_widget_mac_interactive_uitest.mm
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/widget/native_widget_mac_unittest.mm
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/widget/native_widget_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/widget/root_view_unittest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/widget/widget_interactive_uitest.cc
[modify] https://crrev.com/6f9dd378129a97d42fd0db32f8c3c931da9dba6d/ui/views/widget/widget_unittest.cc

Comment 7 by avi@google.com, Dec 26 

FYI, the revert did indeed fix the bots.

A sample failure was:
[1224/144637.246752:FATAL:test_launcher.cc(511)] Check failed: 1U == parsed_results.size() (1 vs. 2)Unexpectedly ran test more than once: ClipboardTest/BaseClipboardTest.RTFTest
#0 0x7f9e323c6e8d base::debug::StackTrace::StackTrace()
#1 0x7f9e320c0bfa base::debug::StackTrace::StackTrace()
#2 0x7f9e3212b6ae logging::LogMessage::~LogMessage()
#3 0x55ce8a35fe60 content::(anonymous namespace)::WrapperTestLauncherDelegate::GTestCallback()
#4 0x55ce8a35f98a content::(anonymous namespace)::WrapperTestLauncherDelegate::ChildProcessLifetimeObserver::OnCompleted()

but over and over.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5da1d21f332c756024e5cc65f2da9ae8a4ee529f

commit 5da1d21f332c756024e5cc65f2da9ae8a4ee529f
Author: Evan Stade <estade@chromium.org>
Date: Mon Jan 14 19:34:33 2019

Re-land "Merge views_mus_unittests and views_unittests"

This relands commit 6f9dd378129a97d42fd0db32f8c3c931da9dba6d.

> Merge views_mus_unittests and views_unittests
>
> - Allow testing DesktopNativeWidgetAura on Chrome OS by doing necessary
>   Mus setup.
> - To accommodate Chrome OS, tests must specify that they will be testing
>   desktop widgets before SetUp (for tests that inherit from
>   ViewsTestBase). On Chrome OS, these are the tests that provide Mus
>   coverage.
> - Command line flags are ignored, so views_unittests will perform the
>   same tests with and without --enable-features=SingleProcessMash
> - Enable some test suites on Chrome OS, such as
>   desktop_native_widget_aura_unittest.cc, and some individual tests.

TBR=tsepez@chromium.org

Bug: 911784
Change-Id: If7dd151d6ae5a47887ae0436f340a0c0372e990c
Reviewed-on: https://chromium-review.googlesource.com/c/1393454
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622549}
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/BUILD.gn
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/chrome/browser/ui/views/infobars/infobar_view_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/chrome/browser/ui/views/media_router/cast_toolbar_button_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/chrome/browser/ui/views/media_router/cloud_services_dialog_view_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/chrome/browser/ui/views/menu_interactive_uitest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/chrome/browser/ui/views/message_center/popups_only_ui_delegate_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/chrome/test/base/interactive_ui_tests_main.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/chrome/test/views/chrome_views_test_base.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/components/constrained_window/BUILD.gn
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/content/public/test/test_launcher.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/base/clipboard/clipboard_test_template.h
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/base/clipboard/clipboard_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/base/test/test_clipboard_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/BUILD.gn
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/DEPS
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/OWNERS
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/accessibility/ax_system_caret_win_interactive_uitest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/accessible_pane_view_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/animation/ink_drop_impl_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/cocoa/bridged_native_widget_interactive_uitest.mm
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/controls/button/menu_button_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/controls/menu/menu_controller_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/controls/menu/menu_runner_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/controls/native/native_view_host_aura_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/controls/webview/webview_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/corewm/DEPS
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/corewm/desktop_capture_controller_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/corewm/tooltip_controller_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/event_monitor_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/focus/focus_manager_unittest.cc
[rename] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/interactive_ui_tests_manifest.json
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/layout/grid_layout_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/mus/BUILD.gn
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/mus/DEPS
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/mus/OWNERS
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/mus/ax_remote_host_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/mus/ax_tree_source_mus_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/mus/clipboard_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/mus/desktop_window_tree_host_mus_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/mus/drag_interactive_uitest.cc
[delete] https://crrev.com/e14a00d50d1ebedb74b842d1f3af22cc6feeb417/ui/views/mus/interactive_ui_tests_mus.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/mus/remote_view/remote_view_host_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/mus/remote_view/remote_view_provider_unittest.cc
[delete] https://crrev.com/e14a00d50d1ebedb74b842d1f3af22cc6feeb417/ui/views/mus/run_all_unittests_mus.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/mus/screen_mus_unittest.cc
[delete] https://crrev.com/e14a00d50d1ebedb74b842d1f3af22cc6feeb417/ui/views/mus/views_mus_test_suite.cc
[delete] https://crrev.com/e14a00d50d1ebedb74b842d1f3af22cc6feeb417/ui/views/mus/views_mus_test_suite.h
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/test/DEPS
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/test/focus_manager_test.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/test/focus_manager_test.h
[add] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/test/native_widget_factory.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/test/native_widget_factory.h
[delete] https://crrev.com/e14a00d50d1ebedb74b842d1f3af22cc6feeb417/ui/views/test/native_widget_factory_aura_mus.cc
[delete] https://crrev.com/e14a00d50d1ebedb74b842d1f3af22cc6feeb417/ui/views/test/native_widget_factory_desktop.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/test/platform_test_helper.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/test/platform_test_helper.h
[add] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/test/platform_test_helper_mus.cc
[add] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/test/platform_test_helper_mus.h
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/test/views_interactive_ui_test_base.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/test/views_interactive_ui_test_base.h
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/test/views_test_base.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/test/views_test_base.h
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/test/views_test_helper_aura.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/test/widget_test.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/test/widget_test.h
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/test/widget_test_aura.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/test/widget_test_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/touchui/touch_selection_controller_impl_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/touchui/touch_selection_menu_runner_views_unittest.cc
[rename] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/unittests_manifest.json
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/view_unittest_aura.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/views_test_suite.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/views_test_suite.h
[delete] https://crrev.com/e14a00d50d1ebedb74b842d1f3af22cc6feeb417/ui/views/widget/DEPS
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/widget/desktop_aura/desktop_drag_drop_client_ozone_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/widget/desktop_aura/desktop_focus_rules_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/widget/desktop_widget_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/widget/native_widget_aura_interactive_uitest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/widget/native_widget_mac_interactive_uitest.mm
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/widget/native_widget_mac_unittest.mm
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/widget/native_widget_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/widget/root_view_unittest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/widget/widget_interactive_uitest.cc
[modify] https://crrev.com/5da1d21f332c756024e5cc65f2da9ae8a4ee529f/ui/views/widget/widget_unittest.cc
►

Sign in to add a comment