New issue
Advanced search Search tips

Issue 911781 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Cleanup Translate Event Logging dead code

Project Member Reported by anthonyvd@chromium.org, Dec 4

Issue description

The feature is disabled by default and no config apply anymore. Since it was decided to stop collecting those events, we should remove the Chromium code that logs the events.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/375260f7da26d6910344c5904c849b916ff217c8

commit 375260f7da26d6910344c5904c849b916ff217c8
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Thu Dec 06 16:54:37 2018

Remove iOS Translate Event Logging in Sync

The feature is disabled by default, no config currently applies, and it
was decided to stop collecting these events. This removes the iOS
portion of the code because it allows removing a translate -> sync
dependency that was preventing another change from landing.

Bug: 896719,911781
Change-Id: I54c40dc1154bb6619d876dbd3fc86e3d22078e99
Reviewed-on: https://chromium-review.googlesource.com/c/1361927
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614385}
[modify] https://crrev.com/375260f7da26d6910344c5904c849b916ff217c8/ios/chrome/browser/translate/BUILD.gn
[modify] https://crrev.com/375260f7da26d6910344c5904c849b916ff217c8/ios/chrome/browser/translate/chrome_ios_translate_client.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 12

Labels: merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/684e7722852692a9b603ea296f9c0145e5ce96db

commit 684e7722852692a9b603ea296f9c0145e5ce96db
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Wed Dec 12 20:13:31 2018

Remove iOS Translate Event Logging in Sync

The feature is disabled by default, no config currently applies, and it
was decided to stop collecting these events. This removes the iOS
portion of the code because it allows removing a translate -> sync
dependency that was preventing another change from landing.

Bug: 896719,911781
Change-Id: I54c40dc1154bb6619d876dbd3fc86e3d22078e99
Reviewed-on: https://chromium-review.googlesource.com/c/1361927
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614385}(cherry picked from commit 375260f7da26d6910344c5904c849b916ff217c8)
Reviewed-on: https://chromium-review.googlesource.com/c/1374510
Cr-Commit-Position: refs/branch-heads/3626@{#300}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/684e7722852692a9b603ea296f9c0145e5ce96db/ios/chrome/browser/translate/BUILD.gn
[modify] https://crrev.com/684e7722852692a9b603ea296f9c0145e5ce96db/ios/chrome/browser/translate/chrome_ios_translate_client.mm

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/684e7722852692a9b603ea296f9c0145e5ce96db

Commit: 684e7722852692a9b603ea296f9c0145e5ce96db
Author: anthonyvd@chromium.org
Commiter: rogerm@chromium.org
Date: 2018-12-12 20:13:31 +0000 UTC

Remove iOS Translate Event Logging in Sync

The feature is disabled by default, no config currently applies, and it
was decided to stop collecting these events. This removes the iOS
portion of the code because it allows removing a translate -> sync
dependency that was preventing another change from landing.

Bug: 896719,911781
Change-Id: I54c40dc1154bb6619d876dbd3fc86e3d22078e99
Reviewed-on: https://chromium-review.googlesource.com/c/1361927
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614385}(cherry picked from commit 375260f7da26d6910344c5904c849b916ff217c8)
Reviewed-on: https://chromium-review.googlesource.com/c/1374510
Cr-Commit-Position: refs/branch-heads/3626@{#300}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment