New issue
Advanced search Search tips

Issue 911779 link

Starred by 1 user
Status: Verified
Owner:
nicolaso@chromium.org
Closed: Dec 17
Cc:
pastarmovj@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug-Regression



Sign in to add a comment

BrowserSwitcher doesn't use IE as default

Project Member Reported by nicolaso@chromium.org, Dec 4 
This patch [1] changed the code in AlternativeBrowserLauncher, so it only calls SetBrowser{Path,Parameters}() when the pref is managed.

This is causing it to never call SetBrowserPath() at all when the pref isn't managed, which means AlternativeBrowserDriver isn't setting a default value.

This is a regression.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1293560
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22d04cdf8ebd45ffa2f42bd4a7f135c068f0b7bb

commit 22d04cdf8ebd45ffa2f42bd4a7f135c068f0b7bb
Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Date: Sun Dec 16 23:13:42 2018

[BrowserSwitcher] Apply default browser even when pref is not managed

Previously, the code that would set IE/Safari (based on platform) as the
default browser would not apply correctly because of a regression.  This
CL applies the rules again, even when the AlternativeBrowserPath policy
is not set.

Bug:  911779 
Change-Id: I79c758b9295f67682934bbc299cfaa544b1a30d0
Reviewed-on: https://chromium-review.googlesource.com/c/1372411
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617024}
[modify] https://crrev.com/22d04cdf8ebd45ffa2f42bd4a7f135c068f0b7bb/chrome/browser/browser_switcher/alternative_browser_driver_posix.cc
[modify] https://crrev.com/22d04cdf8ebd45ffa2f42bd4a7f135c068f0b7bb/chrome/browser/browser_switcher/alternative_browser_driver_win.cc
[modify] https://crrev.com/22d04cdf8ebd45ffa2f42bd4a7f135c068f0b7bb/chrome/browser/browser_switcher/alternative_browser_launcher.cc
[modify] https://crrev.com/22d04cdf8ebd45ffa2f42bd4a7f135c068f0b7bb/chrome/browser/browser_switcher/alternative_browser_launcher_unittest.cc
[modify] https://crrev.com/22d04cdf8ebd45ffa2f42bd4a7f135c068f0b7bb/chrome/browser/browser_switcher/browser_switcher_sitelist.cc

Comment 2 by nicolaso@chromium.org, Dec 17

Status: Verified (was: Assigned)
►

Sign in to add a comment