New issue
Advanced search Search tips

Issue 911770 link

Starred by 2 users
Status: Verified
Owner:
thomasanderson@chromium.org
Closed: Dec 7
Cc:
vamshi.kommuri@chromium.org
alancutter@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Classic theme on desktop Linux should use MD-style frame buttons like ChromeOS

Project Member Reported by thomasanderson@chromium.org, Dec 4 
The current buttons are styled to match a theme that was the default on an ancient version of Ubuntu.  Now users have the option to use the GTK theme to have system-styled frame buttons.  In the classic theme though, the browser should look like Chrome(OS), not the system style.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4c383b13f54423564b008db1b0d23ad4a8a8d9c

commit f4c383b13f54423564b008db1b0d23ad4a8a8d9c
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Dec 05 02:45:38 2018

Move FrameCaptionButton from ash to ui

This is necessary for:
https://chromium-review.googlesource.com/c/chromium/src/+/1361798

BUG= 911770 
R=sky

Change-Id: I4f6d1f470987de9366d371b81e7ba8503fce6179
Reviewed-on: https://chromium-review.googlesource.com/c/1359031
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613831}
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/BUILD.gn
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/assistant/ui/caption_bar.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/frame/caption_buttons/frame_size_button_unittest.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/frame/header_view.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/frame/header_view.h
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/frame/non_client_frame_view_ash.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/frame/non_client_frame_view_ash_unittest.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/frame/wide_frame_view.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/public/cpp/BUILD.gn
[delete] https://crrev.com/d04af01a6bf5dbb69737f6683d39f93c1ae8be55/ash/public/cpp/ash_layout_constants.h
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/public/cpp/caption_buttons/caption_button_model.h
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/public/cpp/caption_buttons/frame_back_button.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/public/cpp/caption_buttons/frame_back_button.h
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/public/cpp/caption_buttons/frame_caption_button_container_view.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/public/cpp/caption_buttons/frame_caption_button_container_view.h
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/public/cpp/caption_buttons/frame_size_button.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/public/cpp/caption_buttons/frame_size_button.h
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/public/cpp/caption_buttons/frame_size_button_delegate.h
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/public/cpp/default_frame_header.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/public/cpp/default_frame_header.h
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/public/cpp/frame_header.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/public/cpp/frame_header.h
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/public/cpp/vector_icons/BUILD.gn
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/wm/non_client_frame_controller.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ash/wm/non_client_frame_controller_unittest.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/chrome/browser/ui/views/frame/browser_frame_header_ash.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/chrome/browser/ui/views/frame/browser_frame_header_ash.h
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/chrome/browser/ui/views/frame/immersive_mode_controller_ash_browsertest.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/components/exo/client_controlled_shell_surface.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/components/exo/client_controlled_shell_surface.h
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/components/exo/client_controlled_shell_surface_unittest.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/components/exo/wayland/zcr_remote_shell.cc
[modify] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ui/views/BUILD.gn
[rename] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ui/views/window/caption_button_layout_constants.cc
[add] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ui/views/window/caption_button_layout_constants.h
[rename] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ui/views/window/caption_button_types.h
[rename] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ui/views/window/frame_caption_button.cc
[rename] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ui/views/window/frame_caption_button.h
[rename] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ui/views/window/frame_caption_button_unittest.cc
[add] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ui/views/window/vector_icons/BUILD.gn
[add] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ui/views/window/vector_icons/vector_icons.cc.template
[add] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ui/views/window/vector_icons/vector_icons.h.template
[rename] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ui/views/window/vector_icons/window_control_close.icon
[rename] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ui/views/window/vector_icons/window_control_maximize.icon
[rename] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ui/views/window/vector_icons/window_control_minimize.icon
[rename] https://crrev.com/f4c383b13f54423564b008db1b0d23ad4a8a8d9c/ui/views/window/vector_icons/window_control_restore.icon
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0a64efbc6688c49d333368f5e83b9f08816bdc8

commit d0a64efbc6688c49d333368f5e83b9f08816bdc8
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Dec 07 21:40:03 2018

Use MD-style frame buttons for Linux classic theme

BUG= 911770 
R=pkasting

Change-Id: I1f12126581ac6840cb8de8058bb6b791937f6ec0
Reviewed-on: https://chromium-review.googlesource.com/c/1361798
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614822}
[modify] https://crrev.com/d0a64efbc6688c49d333368f5e83b9f08816bdc8/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/d0a64efbc6688c49d333368f5e83b9f08816bdc8/chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_views.cc
[modify] https://crrev.com/d0a64efbc6688c49d333368f5e83b9f08816bdc8/chrome/browser/ui/views/frame/desktop_linux_browser_frame_view.cc
[modify] https://crrev.com/d0a64efbc6688c49d333368f5e83b9f08816bdc8/chrome/browser/ui/views/frame/desktop_linux_browser_frame_view.h
[modify] https://crrev.com/d0a64efbc6688c49d333368f5e83b9f08816bdc8/chrome/browser/ui/views/frame/desktop_linux_browser_frame_view_layout.cc
[modify] https://crrev.com/d0a64efbc6688c49d333368f5e83b9f08816bdc8/chrome/browser/ui/views/frame/desktop_linux_browser_frame_view_layout.h
[modify] https://crrev.com/d0a64efbc6688c49d333368f5e83b9f08816bdc8/chrome/browser/ui/views/frame/desktop_linux_browser_frame_view_layout_unittest.cc
[modify] https://crrev.com/d0a64efbc6688c49d333368f5e83b9f08816bdc8/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
[modify] https://crrev.com/d0a64efbc6688c49d333368f5e83b9f08816bdc8/chrome/browser/ui/views/frame/opaque_browser_frame_view.h
[modify] https://crrev.com/d0a64efbc6688c49d333368f5e83b9f08816bdc8/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
[modify] https://crrev.com/d0a64efbc6688c49d333368f5e83b9f08816bdc8/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h
[add] https://crrev.com/d0a64efbc6688c49d333368f5e83b9f08816bdc8/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_delegate.cc
[modify] https://crrev.com/d0a64efbc6688c49d333368f5e83b9f08816bdc8/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_delegate.h
[modify] https://crrev.com/d0a64efbc6688c49d333368f5e83b9f08816bdc8/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc
[modify] https://crrev.com/d0a64efbc6688c49d333368f5e83b9f08816bdc8/ui/views/window/frame_caption_button.h

Comment 3 by thomasanderson@chromium.org, Dec 7

Status: Fixed (was: Started)

Comment 4 by alancutter@chromium.org, Dec 12 

Looks like this broke PWA title bar layout.
Repro steps:
1. Visit soft-puppy.glitch.me
2. Menu > Install Soft Puppy
Screenshot from 2018-12-12 14-48-04.png
21.5 KB View Download

Comment 5 by alancutter@chromium.org, Dec 12

Cc: alancutter@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a41ce9be4f98f466881ae2a21ff2a8066677c62d

commit a41ce9be4f98f466881ae2a21ff2a8066677c62d
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Dec 13 02:33:48 2018

Apply correct ink drop ripple and highlight state after view resize

Only the active state was handled previously for the ink drop ripple,
and the visible state wasn't set at all on the highlight.  This CL
handles all ink drop ripple cases and the highlight visible state.

BUG= 905586 , 911770 
R=mohsen

Change-Id: I0fb383f32dd0c730cd3b38981c87b7447f1878c0
Reviewed-on: https://chromium-review.googlesource.com/c/1366492
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616172}
[modify] https://crrev.com/a41ce9be4f98f466881ae2a21ff2a8066677c62d/ui/views/animation/ink_drop_impl.cc
[modify] https://crrev.com/a41ce9be4f98f466881ae2a21ff2a8066677c62d/ui/views/animation/ink_drop_ripple.cc
[modify] https://crrev.com/a41ce9be4f98f466881ae2a21ff2a8066677c62d/ui/views/animation/ink_drop_ripple.h

Comment 8 by alancutter@chromium.org, Dec 13 

Thanks for the fix!

Comment 9 by vamshi.kommuri@chromium.org, Dec 14

Cc: vamshi.kommuri@chromium.org
Labels: Needs-Feedback
Tried checking the issue as per comment#4 on latest chrome version 73.0.3640.0 using Ubuntu 14.04
Observed the PWA title bar layout seems to be fixed. 
Attaching the screen shot of the same for reference.

@Tom Anderson: As we are not sure about Linux using MD-style frame buttons, Could you please give a clarify on it and help us in verifying the fix.

Thanks!
911770.png
152 KB View Download

Comment 10 by thomasanderson@chromium.org, Dec 14

Status: Verified (was: Fixed)
c#9: LGTM, thanks!
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 14

Labels: merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/307322fcaaaec26caf0f60601393ea770788440f

commit 307322fcaaaec26caf0f60601393ea770788440f
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Dec 14 23:39:11 2018

[Merge to M72] Apply correct ink drop ripple and highlight state after view resize

> Only the active state was handled previously for the ink drop ripple,
> and the visible state wasn't set at all on the highlight.  This CL
> handles all ink drop ripple cases and the highlight visible state.
>
> BUG= 905586 , 911770 
> R=mohsen
>
> Change-Id: I0fb383f32dd0c730cd3b38981c87b7447f1878c0
> Reviewed-on: https://chromium-review.googlesource.com/c/1366492
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#616172}

BUG= 905586 , 911770 
TBR=mohsen
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I9f7a3d5ed5d237e971a879d6088293397075cb97
Reviewed-on: https://chromium-review.googlesource.com/c/1379216
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#376}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/307322fcaaaec26caf0f60601393ea770788440f/ui/views/animation/ink_drop_impl.cc
[modify] https://crrev.com/307322fcaaaec26caf0f60601393ea770788440f/ui/views/animation/ink_drop_ripple.cc
[modify] https://crrev.com/307322fcaaaec26caf0f60601393ea770788440f/ui/views/animation/ink_drop_ripple.h

Comment 12 by vamshi.kommuri@chromium.org, Dec 19

Labels: -Needs-Feedback TE-Verified-M72 TE-Verified-72.0.3626.28
As per the confirmation given in C#10, verified the fix on Ubuntu 14.04 using Chrome version #72.0.3626.28 with the steps mentioned in comment#4.
Attaching screen shot for reference.
Observed the PWA title bar layout seems to be fixed.
Hence, the fix is working as expected. 
Adding the verified labels.
Note: Able to reproduce the issue on chrome version with out fix.

Thanks...!!
911770 Beta.png
154 KB View Download
Project Member

Comment 13 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/307322fcaaaec26caf0f60601393ea770788440f

Commit: 307322fcaaaec26caf0f60601393ea770788440f
Author: thomasanderson@chromium.org
Commiter: thomasanderson@chromium.org
Date: 2018-12-14 23:39:11 +0000 UTC

[Merge to M72] Apply correct ink drop ripple and highlight state after view resize

> Only the active state was handled previously for the ink drop ripple,
> and the visible state wasn't set at all on the highlight.  This CL
> handles all ink drop ripple cases and the highlight visible state.
>
> BUG= 905586 , 911770 
> R=mohsen
>
> Change-Id: I0fb383f32dd0c730cd3b38981c87b7447f1878c0
> Reviewed-on: https://chromium-review.googlesource.com/c/1366492
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#616172}

BUG= 905586 , 911770 
TBR=mohsen
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I9f7a3d5ed5d237e971a879d6088293397075cb97
Reviewed-on: https://chromium-review.googlesource.com/c/1379216
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#376}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efbe4fc92cffdee6cb4c0b8c638bcf343df4fba5

commit efbe4fc92cffdee6cb4c0b8c638bcf343df4fba5
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Jan 03 19:09:35 2019

Remove unnecessary Linux frame button resources

These should no longer be necessary now that Desktop Linux uses ChromeOS-styled
frame buttons.

BUG= 911770 
R=sky

Change-Id: I79ae8a5173e7be7e050ba84220700c47ea6515cc
Reviewed-on: https://chromium-review.googlesource.com/c/1394303
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619709}
[delete] https://crrev.com/37cc322c957f5a5ca742d1c817c0d1e5cdefb035/ui/views/resources/default_100_percent/linux/linux_close.png
[delete] https://crrev.com/37cc322c957f5a5ca742d1c817c0d1e5cdefb035/ui/views/resources/default_100_percent/linux/linux_close_hover.png
[delete] https://crrev.com/37cc322c957f5a5ca742d1c817c0d1e5cdefb035/ui/views/resources/default_100_percent/linux/linux_close_pressed.png
[delete] https://crrev.com/37cc322c957f5a5ca742d1c817c0d1e5cdefb035/ui/views/resources/default_100_percent/linux/linux_maximize.png
[delete] https://crrev.com/37cc322c957f5a5ca742d1c817c0d1e5cdefb035/ui/views/resources/default_100_percent/linux/linux_maximize_hover.png
[delete] https://crrev.com/37cc322c957f5a5ca742d1c817c0d1e5cdefb035/ui/views/resources/default_100_percent/linux/linux_maximize_pressed.png
[delete] https://crrev.com/37cc322c957f5a5ca742d1c817c0d1e5cdefb035/ui/views/resources/default_100_percent/linux/linux_minimize.png
[delete] https://crrev.com/37cc322c957f5a5ca742d1c817c0d1e5cdefb035/ui/views/resources/default_100_percent/linux/linux_minimize_hover.png
[delete] https://crrev.com/37cc322c957f5a5ca742d1c817c0d1e5cdefb035/ui/views/resources/default_100_percent/linux/linux_minimize_pressed.png
[delete] https://crrev.com/37cc322c957f5a5ca742d1c817c0d1e5cdefb035/ui/views/resources/default_100_percent/linux/linux_restore.png
[delete] https://crrev.com/37cc322c957f5a5ca742d1c817c0d1e5cdefb035/ui/views/resources/default_100_percent/linux/linux_restore_hover.png
[delete] https://crrev.com/37cc322c957f5a5ca742d1c817c0d1e5cdefb035/ui/views/resources/default_100_percent/linux/linux_restore_pressed.png
[modify] https://crrev.com/efbe4fc92cffdee6cb4c0b8c638bcf343df4fba5/ui/views/resources/views_resources.grd
►

Sign in to add a comment