Keyboard Shortcut Viewer Crashes upon close |
||||
Issue descriptionOn ToT from morning of Dec 4th: 7d47a55b52ba95cb87b5f71087762f8eae06e6d9 OS: Linux Chromium OS Mash: Local mode 1) Open Keyboard Shortcut Viewer 2) Close via window close button I'm seeing the following crash stack: Received signal 11 <unknown> 000000000000 #0 0x7f9ddf35dc5d base::debug::StackTrace::StackTrace() #1 0x7f9ddf057aca base::debug::StackTrace::StackTrace() #2 0x7f9ddf35d6df base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7f9dae5760c0 <unknown> #4 0x7f9dd08af6df aura::WindowEventDispatcher::~WindowEventDispatcher() #5 0x7f9dd08afcc9 aura::WindowEventDispatcher::~WindowEventDispatcher() #6 0x7f9dd08d06a4 aura::WindowTreeHost::DestroyDispatcher() #7 0x7f9dd089bb28 aura::WindowTreeHostMus::~WindowTreeHostMus() #8 0x7f9dc3bc9a2d views::DesktopWindowTreeHostMus::~DesktopWindowTreeHostMus() #9 0x7f9dc3bc9be9 views::DesktopWindowTreeHostMus::~DesktopWindowTreeHostMus() #10 0x7f9dc9d32a73 views::DesktopNativeWidgetAura::OnHostClosed() #11 0x7f9dc3bcc199 views::DesktopWindowTreeHostMus::CloseNow() #12 0x7f9dc3bd6a8f _ZN4base8internal13FunctorTraitsIMN5views24DesktopWindowTreeHostMusEFvvEvE6InvokeIS5_NS_7WeakPtrIS3_EEJEEEvT_OT0_DpOT1_ #13 0x7f9dc3bd69aa _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIMN5views24DesktopWindowTreeHostMusEFvvENS_7WeakPtrIS5_EEJEEEvOT_OT0_DpOT1_ #14 0x7f9dc3bd6940 _ZN4base8internal7InvokerINS0_9BindStateIMN5views24DesktopWindowTreeHostMusEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunImplIS6_NSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #15 0x7f9dc3bd6889 _ZN4base8internal7InvokerINS0_9BindStateIMN5views24DesktopWindowTreeHostMusEFvvEJNS_7WeakPtrIS4_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #16 0x7f9ddf0098ae _ZNO4base12OnceCallbackIFvvEE3RunEv #17 0x7f9ddf058f7a base::debug::TaskAnnotator::RunTask() #18 0x7f9ddf0e9e5c base::MessageLoopImpl::RunTask() #19 0x7f9ddf0ea15b base::MessageLoopImpl::DeferOrRunPendingTask() #20 0x7f9ddf0ea994 base::MessageLoopImpl::DoWork() #21 0x7f9ddf0f0838 base::MessagePumpDefault::Run() #22 0x7f9ddf0e9676 base::MessageLoopImpl::Run() #23 0x7f9ddf194f02 base::RunLoop::Run() #24 0x7f9dd986d85c content::UtilityMain() #25 0x7f9dd9891f92 content::RunOtherNamedProcessTypeMain() #26 0x7f9dd9893dac content::ContentMainRunnerImpl::Run() #27 0x7f9dd988ab3c content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #28 0x7f9daac464d1 service_manager::Main() #29 0x7f9dd988f455 content::ContentMain() #30 0x561b90343226 ChromeMain #31 0x561b90343132 main #32 0x7f9dacc9c2b1 __libc_start_main #33 0x561b9034300a _start
,
Dec 5
I believe this is because the Widget created by KSV is now deleted *after* Env. I think this is a result of Ken's recent changes to service lifetime, but I'm not positive.
,
Dec 5
You're right. I messed up converting this service and I see the bug. I did not translate 1:1 from old APIs to new APIs and the case where the last window is closed actually destroys the service instance immediately instead of initiating a graceful shutdown. I can fix this unless you've already started on it.
,
Dec 5
,
Dec 5
Thankfully it looks like the breakage was after the 72 branch. Specifically it looks like 72 branched @ 612437 and the patch that broke this landed at 612589.
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e74c1a868765ff9b8441d2fef5aa1831b2081eba commit e74c1a868765ff9b8441d2fef5aa1831b2081eba Author: Ken Rockot <rockot@chromium.org> Date: Wed Dec 05 05:07:04 2018 Fix keyboard_shortcut_viewer crash on close Fixes a regression where closing the keyboard_shortcut_viewer service's window leads to a crash. Bug: 911758 Change-Id: I06c2ea0bb272d940e5ed008ac90877cf50d12242 Reviewed-on: https://chromium-review.googlesource.com/c/1362012 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#613872} [modify] https://crrev.com/e74c1a868765ff9b8441d2fef5aa1831b2081eba/ash/components/shortcut_viewer/shortcut_viewer_application.cc [modify] https://crrev.com/e74c1a868765ff9b8441d2fef5aa1831b2081eba/ash/components/shortcut_viewer/shortcut_viewer_application.h
,
Dec 5
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sky@chromium.org
, Dec 4Owner: sky@chromium.org
Status: Started (was: Untriaged)