New issue
Advanced search Search tips

Issue 911749 link

Starred by 1 user
Status: Fixed
Owner:
weidongg@chromium.org
Closed: Dec 18
Cc:
omrilio@chromium.org
shibasheikh@chromium.org
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----



Sign in to add a comment

Peeking Launcher suggestion chips have no contrast with bg blur disabled (launcher high opacity)

Project Member Reported by newcomer@chromium.org, Dec 4 
On any device with no background blur, suggestion chip contrast is very low.

Comment 1 by sgabr...@chromium.org, Dec 6

Cc: -sgabr...@chromium.org omrilio@chromium.org shibasheikh@chromium.org
Owner: sgabr...@chromium.org
Assigning to me.

Comment 2 by sgabr...@chromium.org, Dec 11

Cc: sgabr...@chromium.org
Owner: weidongg@chromium.org
I've updated the design of the chips to be more visible. Spec updated here and excerpt attached: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZXS6M2rSjiqy/files/MCGWDM8eaujQbs-Nk1Ae1w_qwMSJbxAVNpw
spec excerpt.png
124 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20519a93bd8f22bc06f4f367942c17b91b53c2f2

commit 20519a93bd8f22bc06f4f367942c17b91b53c2f2
Author: weidongg@chromium.org <weidongg@chromium.org>
Date: Tue Dec 18 06:25:45 2018

Make suggestion chip more visible

Change the suggestion chip background color to make its contrast higher
based on specs.

Bug:  911749 
Change-Id: Iec7c66319cf8067b0207699e1444622262dc826b
Reviewed-on: https://chromium-review.googlesource.com/c/1379592
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617394}
[modify] https://crrev.com/20519a93bd8f22bc06f4f367942c17b91b53c2f2/ash/app_list/views/suggestion_chip_view.cc

Comment 4 by weidongg@chromium.org, Dec 18

Status: Fixed (was: Assigned)
►

Sign in to add a comment