This bug represents the work to show permission request notifications in a headset.
The initial work to add the notification should exit when Chrome dismisses a permission and show when Chrome shows a permission.
Klaus is currently working on this.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a64a7859d5d53dfc779841378f976ce41340b7b4 commit a64a7859d5d53dfc779841378f976ce41340b7b4 Author: Klaus Weidner <klausw@chromium.org> Date: Thu Dec 20 00:28:46 2018 Rename VRBrowserRendererHostWin to VRUiHostImpl This makes no functional changes, it just renames the class and file. The followup change https://crrev.com/c/1381516 will add an abstract base class, and this file will become the concrete implementation, hence naming it "*Impl" to prepare for that move. Using the new name in this CL avoids confusing git's file rename detection. Bug: 911734 Change-Id: Ia04103146679983abc01ed03bcfbf00dad087c89 Reviewed-on: https://chromium-review.googlesource.com/c/1381516 Reviewed-by: David Dorwin <ddorwin@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#618029} [modify] https://crrev.com/a64a7859d5d53dfc779841378f976ce41340b7b4/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/a64a7859d5d53dfc779841378f976ce41340b7b4/chrome/browser/vr/service/browser_xr_runtime.h [modify] https://crrev.com/a64a7859d5d53dfc779841378f976ce41340b7b4/chrome/browser/vr/service/isolated_device_provider.cc [delete] https://crrev.com/7bbf22d9c6685ee470695f76e78a78ded8335501/chrome/browser/vr/win/vr_renderloop_host_win.cc [delete] https://crrev.com/7bbf22d9c6685ee470695f76e78a78ded8335501/chrome/browser/vr/win/vr_renderloop_host_win.h [add] https://crrev.com/a64a7859d5d53dfc779841378f976ce41340b7b4/chrome/browser/vr/win/vr_ui_host_impl.cc [add] https://crrev.com/a64a7859d5d53dfc779841378f976ce41340b7b4/chrome/browser/vr/win/vr_ui_host_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16a09bd6a35611c38002101b2b28d821c4e8b214 commit 16a09bd6a35611c38002101b2b28d821c4e8b214 Author: Klaus Weidner <klausw@chromium.org> Date: Wed Dec 26 18:20:27 2018 Add VRUiHost abstract class, inject Impl class Extract an abstract class from the VRUiHostImpl class (renamed from VRBrowserRendererHostWin by https://crrev.com/c/1381516) in the service/ directory, and add the Impl class to the "browser" build component's sources. Impl class objects are injected through a registered factory method for use by code in the "vr_common" component. This lets followup changes use browser functions such as the permissions manager in the Impl class without introducing circular dependencies. Bug: 911734 Change-Id: I86aaa42660dc1f9e38a7518aa4184cda035c83df Reviewed-on: https://chromium-review.googlesource.com/c/1375430 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: David Dorwin <ddorwin@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#618941} [modify] https://crrev.com/16a09bd6a35611c38002101b2b28d821c4e8b214/chrome/browser/BUILD.gn [modify] https://crrev.com/16a09bd6a35611c38002101b2b28d821c4e8b214/chrome/browser/chrome_browser_main.cc [modify] https://crrev.com/16a09bd6a35611c38002101b2b28d821c4e8b214/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/16a09bd6a35611c38002101b2b28d821c4e8b214/chrome/browser/vr/service/isolated_device_provider.cc [modify] https://crrev.com/16a09bd6a35611c38002101b2b28d821c4e8b214/chrome/browser/vr/service/isolated_device_provider.h [add] https://crrev.com/16a09bd6a35611c38002101b2b28d821c4e8b214/chrome/browser/vr/service/vr_ui_host.cc [add] https://crrev.com/16a09bd6a35611c38002101b2b28d821c4e8b214/chrome/browser/vr/service/vr_ui_host.h [rename] https://crrev.com/16a09bd6a35611c38002101b2b28d821c4e8b214/chrome/browser/vr/ui_host/vr_ui_host_impl.cc [add] https://crrev.com/16a09bd6a35611c38002101b2b28d821c4e8b214/chrome/browser/vr/ui_host/vr_ui_host_impl.h [modify] https://crrev.com/16a09bd6a35611c38002101b2b28d821c4e8b214/chrome/browser/vr/win/vr_browser_renderer_thread_win.h [delete] https://crrev.com/543a2def162aeb06e9709ed4b8e4f074d9d8c18e/chrome/browser/vr/win/vr_ui_host_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c694950d9964683a3148b7d2140566f4eef8d24e commit c694950d9964683a3148b7d2140566f4eef8d24e Author: Klaus Weidner <klausw@chromium.org> Date: Mon Jan 07 23:49:16 2019 Detect permission bubbles in Windows VR and show in-headset prompt The permission manager observer doesn't currently support retrieving the specific prompt message, so this just shows a generic message that there's a permission prompt. The "open in browser" icon is from [1] (same as [2]) converted via the instructions in [3]. [1] https://icons.googleplex.com/#icon=ic_open_in_browser [2] https://cs.chromium.org/chromium/src/third_party/material_design_icons/src/action/svg/design/ic_open_in_browser_24px.svg [3] https://chromium.googlesource.com/chromium/src/+/master/components/vector_icons/README.md Bug: 911734 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I17917b6e5bcdc56ac6d0234bf86174094c08bacd Reviewed-on: https://chromium-review.googlesource.com/c/1279123 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#620535} [modify] https://crrev.com/c694950d9964683a3148b7d2140566f4eef8d24e/chrome/app/vector_icons/BUILD.gn [add] https://crrev.com/c694950d9964683a3148b7d2140566f4eef8d24e/chrome/app/vector_icons/open_in_browser.icon [modify] https://crrev.com/c694950d9964683a3148b7d2140566f4eef8d24e/chrome/app/vr_strings.grdp [modify] https://crrev.com/c694950d9964683a3148b7d2140566f4eef8d24e/chrome/browser/vr/model/web_vr_model.h [modify] https://crrev.com/c694950d9964683a3148b7d2140566f4eef8d24e/chrome/browser/vr/ui_host/vr_ui_host_impl.cc [modify] https://crrev.com/c694950d9964683a3148b7d2140566f4eef8d24e/chrome/browser/vr/ui_host/vr_ui_host_impl.h [modify] https://crrev.com/c694950d9964683a3148b7d2140566f4eef8d24e/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/c694950d9964683a3148b7d2140566f4eef8d24e/chrome/browser/vr/win/vr_browser_renderer_thread_win.cc [modify] https://crrev.com/c694950d9964683a3148b7d2140566f4eef8d24e/chrome/browser/vr/win/vr_browser_renderer_thread_win.h
Comment 1 by billorr@chromium.org
, Dec 6