Issue metadata
Sign in to add a comment
|
ChromeVox: tapping on an ARIA button highlights text, not the button |
||||||||||||||||||||||||
Issue descriptionInternal Google bug affecting CfM / Meet: b/118257269 If you have an ARIA button like this: <div tabIndex="0" role="button"> <p> Button Text </p> </div> Tapping on the button text selects the text, but it should select the button.
,
Dec 7
b/118257269 seems to be fixed. The CfM team would like this in 72 if possible.
,
Dec 7
,
Dec 8
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 12
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 13
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/745deb1e5599ab79a19e89776fa495ae9ee74c3a commit 745deb1e5599ab79a19e89776fa495ae9ee74c3a Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Thu Dec 13 17:56:30 2018 When ChromeVox gets a hover event, it should target a leaf node. In particular, the hover might be fired on a text node inside something like a button. The node that should be focused by ChromeVox is the button, not the text inside. Bug: 911726 Change-Id: Ibdbdbe5991e693bd8bbc575ab3e51e7a0fed3e07 Reviewed-on: https://chromium-review.googlesource.com/c/1361622 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614215}(cherry picked from commit 672f22463f1d416359f1db16e11ab6fe23accc88) Reviewed-on: https://chromium-review.googlesource.com/c/1376309 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#328} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/745deb1e5599ab79a19e89776fa495ae9ee74c3a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js [modify] https://crrev.com/745deb1e5599ab79a19e89776fa495ae9ee74c3a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs [modify] https://crrev.com/745deb1e5599ab79a19e89776fa495ae9ee74c3a/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/745deb1e5599ab79a19e89776fa495ae9ee74c3a Commit: 745deb1e5599ab79a19e89776fa495ae9ee74c3a Author: dmazzoni@chromium.org Commiter: dmazzoni@chromium.org Date: 2018-12-13 17:56:30 +0000 UTC When ChromeVox gets a hover event, it should target a leaf node. In particular, the hover might be fired on a text node inside something like a button. The node that should be focused by ChromeVox is the button, not the text inside. Bug: 911726 Change-Id: Ibdbdbe5991e693bd8bbc575ab3e51e7a0fed3e07 Reviewed-on: https://chromium-review.googlesource.com/c/1361622 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614215}(cherry picked from commit 672f22463f1d416359f1db16e11ab6fe23accc88) Reviewed-on: https://chromium-review.googlesource.com/c/1376309 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#328} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 6