New issue
Advanced search Search tips

Issue 911718 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

vm.CrostiniFiles test is failing

Project Member Reported by jkardatzke@chromium.org, Dec 4

Issue description

This test is now failing in all instances with the following error:

2018/12/04 07:08:18 [07:08:18.030] Error at crostini_files.go:179: Running fileManagerPrivate.sharePathsWithCrostini failed: got exception: Error: Invalid value for argument 1. Property '.0': Expected 'object' but got 'undefined'.

I'm assuming this is a result of the recent change to the test by joel. Maybe Chrome just needs to be uprev'd and then it'll be fine...but should be looked into anyways.

Here are some example logs:

https://stainless.corp.google.com/browse/chromeos-autotest-results/263467878-chromeos-test/
 
Cc: lucmult@chromium.org
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1295692 forces MyFilesVolume flag on which changes paths within FilesApp.

It also bind mounts /Downloads into /MyFiles/Downloads.

With the new bind mount seneschal unmount for /MyFiles root now fails.  When seneschal does a recursive bind mount of /MyFiles, it also gets /MyFiles/Downloads.  When seneschal unmounts /MyFiles, it fails to unmount /MyFiles/Downloads with EINVAL, and fails to unmount /MyFiles with EBUSY.

Chirantan is investigating what change is required to make unmount work as desired.

Fix for test is to expect that MyFilesVolume flag is now enabled.

Further temp fix for is to only deal with files inside /MyFiles/Downloads rather than in root of /MyFiles.
Cc: chirantan@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/43234d41878568112e0c473e77423dcb189a5b7a

commit 43234d41878568112e0c473e77423dcb189a5b7a
Author: Joel Hockey <joelhockey@chromium.org>
Date: Wed Dec 05 09:13:34 2018

tast-tests: Update CrostiniFiles to work with MyFilesVolume

Share files from MyFiles rather than Downloads.

Fix JS promise rejection in share/unshare

BUG= chromium:907231 
BUG= chromium:911718 
TEST=vm.CrostiniFiles

Change-Id: Id4baaa1777bceac2771aaac52059234619139a5d
Reviewed-on: https://chromium-review.googlesource.com/1362261
Commit-Ready: Joel Hockey <joelhockey@chromium.org>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/43234d41878568112e0c473e77423dcb189a5b7a/src/chromiumos/tast/local/bundles/cros/vm/crostini_files.go

Status: Fixed (was: Assigned)

Sign in to add a comment