ChildProcessTest.ChildHasCleanExit is flaky |
|||
Issue descriptionExample failure: M72: 72.0.3610.2 - Unit Tests: base_unittests failed with the above error: ChildProcessTest.ChildHasCleanExit Link to Tests: https://uberchromegw.corp.google.com/i/official.android/builders/test-official-arm/builds/3277 Link to failed step: https://uberchromegw.corp.google.com/i/official.android/builders/test-official-arm/builds/3277/steps/Unit%20Test%3A%20base_unittests/logs/stdio 94.018s Main Detailed Logs C 94.018s Main ******************************************************************************** C 94.022s Main [FAILURE] ChildProcessTest.ChildHasCleanExit: C 94.022s Main [ RUN ] ChildProcessTest.ChildHasCleanExit C 94.022s Main ../../base/android/child_process_unittest.cc:31: Failure C 94.022s Main Value of: MultiProcessTestChildHasCleanExit(process) C 94.022s Main Actual: false C 94.022s Main Expected: true C 94.022s Main [ FAILED ] ChildProcessTest.ChildHasCleanExit (168 ms) C 94.022s Main [----------] 1 test from ChildProcessTest (168 ms total) C 94.022s Main C 94.022s Main [----------] Global test environment tear-down C 94.022s Main [==========] 1 test from 1 test case ran. (169 ms total) C 94.022s Main [ PASSED ] 0 tests. C 94.022s Main [ FAILED ] 1 test, listed below: C 94.022s Main [ FAILED ] ChildProcessTest.ChildHasCleanExit C 94.022s Main ******************************************************************************** C 94.022s Main Summary C 94.022s Main ******************************************************************************** C 94.030s Main [==========] 3998 tests ran. C 94.030s Main [ PASSED ] 3997 tests. C 94.030s Main [ FAILED ] 1 test, listed below: C 94.030s Main [ FAILED ] ChildProcessTest.ChildHasCleanExit C 94.030s Main C 94.030s Main 1 FAILED TEST Another example: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-kitkat-arm-rel/139376
,
Dec 4
Bo, do you happen to have any ideas on why this test keeps flaking?
,
Dec 4
I assume I was cc'ed as the sheriff. Since this test has been disabled, I don't believe it needs sheriff attention. Please re-add me if needed.
,
Dec 4
These two things probably races? https://cs.chromium.org/chromium/src/base/test/android/java/src/org/chromium/base/MultiprocessTestClientLauncher.java?rcl=546c505e7dca72f08d52c36d7f22d5cd2079ca04&l=108 https://cs.chromium.org/chromium/src/base/test/android/java/src/org/chromium/base/MultiprocessTestClientLauncher.java?rcl=546c505e7dca72f08d52c36d7f22d5cd2079ca04&l=337
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccb389f869494fa0abbe3e66fe1d181eaebe0e4f commit ccb389f869494fa0abbe3e66fe1d181eaebe0e4f Author: Clark DuVall <cduvall@chromium.org> Date: Wed Dec 12 18:21:14 2018 Fix flaky ChildProcessTest.ChildHasCleanExit test on Android This change makes sure we save the clean exit value if the connection to the child process is lost. Bug: 911716 Change-Id: I9e0ac28e4ed18a3852fa157a4ce1295552d79bc4 Reviewed-on: https://chromium-review.googlesource.com/c/1370644 Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#615968} [modify] https://crrev.com/ccb389f869494fa0abbe3e66fe1d181eaebe0e4f/base/android/child_process_unittest.cc [modify] https://crrev.com/ccb389f869494fa0abbe3e66fe1d181eaebe0e4f/base/test/android/java/src/org/chromium/base/MultiprocessTestClientLauncher.java
,
Dec 12
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Dec 4