Web App Manifest Parser crashes on invalid Web Share Target |
|
Issue descriptionCurrently, providing a non-string value for one of the list items for the 'accept' parameter to a Web Share Target will cause the renderer to crash due to a failing CHECK(). CL is posted at https://chromium-review.googlesource.com/c/chromium/src/+/1355766, but I will be creating a copy and continuing the review from the new CL shortly.
,
Jan 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/685a74c3ce8286ec5972b53df40300a7322307e3 commit 685a74c3ce8286ec5972b53df40300a7322307e3 Author: Glenn Hartmann <hartmanng@chromium.org> Date: Mon Jan 07 17:01:48 2019 Fix a few ShareTargetFiles bugs in the WebAppManifest Parser. Bugs fixed: * don't crash if entries in 'accept' sequence are not strings * allow 'accept' to be a single string * allow 'files' to be a single ShareTargetFile Bug: 911690, 912548 Change-Id: If930941dafaf61dbeb5b80d53a7684aa88f401b7 Reviewed-on: https://chromium-review.googlesource.com/c/1361291 Commit-Queue: Glenn Hartmann <hartmanng@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#620359} [modify] https://crrev.com/685a74c3ce8286ec5972b53df40300a7322307e3/content/renderer/manifest/manifest_parser.cc [modify] https://crrev.com/685a74c3ce8286ec5972b53df40300a7322307e3/content/renderer/manifest/manifest_parser.h [modify] https://crrev.com/685a74c3ce8286ec5972b53df40300a7322307e3/content/renderer/manifest/manifest_parser_unittest.cc |
|
►
Sign in to add a comment |
|
Comment 1 by hartma...@chromium.org
, Dec 4