adhd unit test failing in ubsan builder |
|||
Issue descriptionhttps://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8928074746337446368 adhd-0.0.1-r1607: * ASAN error detected: adhd-0.0.1-r1607: * tests/mix_unittest.cc:414:33: runtime error: left shift of negative value -2105343 adhd-0.0.1-r1607: * #0 0x55aa867d650d in (anonymous namespace)::MixTestSuiteS24_LE::Scale(int, float) /build/amd64-generic/tmp/portage/media-sound/adhd-0.0.1-r1607/work/adhd-0.0.1/cras/src/tests/mix_unittest.cc:414:33 adhd-0.0.1-r1607: * #1 0x55aa867d650d in (anonymous namespace)::MixTestSuiteS24_LE::ScaleIncrement(float, float, float) /build/amd64-generic/tmp/portage/media-sound/adhd-0.0.1-r1607/work/adhd-0.0.1/cras/src/tests/mix_unittest.cc:404 adhd-0.0.1-r1607: adhd-0.0.1-r1607: >>> Failed to emerge media-sound/adhd-0.0.1-r1607 for /build/amd64-generic/, Log file: To repro: FEATURES=test USE=ubsan emerge-amd64-generic adhd
,
Dec 5
tzungbi@ This is also blocking other packages unit tests from running, ptal.
,
Dec 5
The error messages are: server/cras_mix_ops.c:233:28: runtime error: left shift of negative value -2105343 tests/mix_unittest.cc:414:33: runtime error: left shift of negative value -2105343
,
Dec 5
For the left shift op, using unsigned type instead of signed type might be enough to silence the complains.
,
Dec 5
Got it. The CL is going to merge. https://chromium-review.googlesource.com/1362263
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/3981d3f014659719c93b4059397a758034501c13 commit 3981d3f014659719c93b4059397a758034501c13 Author: Tzung-Bi Shih <tzungbi@chromium.org> Date: Wed Dec 05 12:22:27 2018 CRAS: mix: remove undefined behaviors around shift The error messages are: server/cras_mix_ops.c:233:28: runtime error: left shift of negative value -2105343 tests/mix_unittest.cc:414:33: runtime error: left shift of negative value -2105343 Add casts and bitwise AND to make ubsan happy. BUG= chromium:911689 TEST=FEATURES=test USE=ubsan emerge-atlas adhd Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org> Change-Id: I7e00195c40c9d61989a4061dbe9cbae420a3d895 Reviewed-on: https://chromium-review.googlesource.com/1362263 Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> [modify] https://crrev.com/3981d3f014659719c93b4059397a758034501c13/cras/src/tests/mix_unittest.cc [modify] https://crrev.com/3981d3f014659719c93b4059397a758034501c13/cras/src/server/cras_mix_ops.c
,
Jan 3
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dgreid@google.com
, Dec 4Owner: tzungbi@chromium.org