New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment
link

Issue 911683: url::Origin::Resolve should also consider about:srcdoc (in addition to about:blank)

Reported by lukasza@chromium.org, Dec 4 Project Member

Issue description

about:srcdoc inherits the origin of its parent frame (similarly to about:blank).  Therefore url::Origin::Resolve should also consider about:srcdoc.
 

Comment 1 by lukasza@chromium.org, Dec 4

Owner: lukasza@chromium.org
Status: Started (was: Untriaged)
WIP CL @ https://crrev.com/c/1361284

Comment 2 by bugdroid1@chromium.org, Dec 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b309508508f232e7a91aa34891f652313afa7840

commit b309508508f232e7a91aa34891f652313afa7840
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Fri Dec 07 00:57:16 2018

Also considering about:srcdoc in url::Origin::Resolve.

about:srcdoc inherits the origin of its parent frame (similarly to
about:blank).  Therefore url::Origin::Resolve should also consider
about:srcdoc.

Bug:  911683 
Change-Id: I114cdd21ff5b317c38cd50e648a16fb0879ceed9
Reviewed-on: https://chromium-review.googlesource.com/c/1361284
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Ɓukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614506}
[modify] https://crrev.com/b309508508f232e7a91aa34891f652313afa7840/url/origin.cc
[modify] https://crrev.com/b309508508f232e7a91aa34891f652313afa7840/url/origin_unittest.cc

Comment 3 by lukasza@chromium.org, Dec 7

Status: Fixed (was: Started)

Sign in to add a comment