Port ForceSigninVerifier to IdentityManager |
||
Issue descriptionIt uses SigninManager and ProfileOAuth2TokenService (without including either header, d'oh). From a quick analysis, the porting of the unittest might involve some complexity. Feel free to reach out early in the case of unexpected/challenging issues with either the production code or the test.
,
Jan 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9080ae110b2c95ad74defdd050687a1795d499ba commit 9080ae110b2c95ad74defdd050687a1795d499ba Author: Antonio Gomes <tonikitoo@igalia.com> Date: Wed Jan 02 16:11:06 2019 [s13n] Port ForceSigninVerifier to IdentityManager SigninManager and PO2TS are going to be an implementation detail of the IdentityManager, and eventually will not be exposed to clients out of //services/identity. This CL converts ForceSigninVerifier and its subclasses accordingly. BUG= 911682 Change-Id: I349995dfd934870c09ba4145c431f322e5517e5f Reviewed-on: https://chromium-review.googlesource.com/c/1388784 Reviewed-by: Owen Min <zmin@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#619411} [modify] https://crrev.com/9080ae110b2c95ad74defdd050687a1795d499ba/chrome/browser/signin/force_signin_verifier.cc [modify] https://crrev.com/9080ae110b2c95ad74defdd050687a1795d499ba/chrome/browser/signin/force_signin_verifier.h [modify] https://crrev.com/9080ae110b2c95ad74defdd050687a1795d499ba/chrome/browser/signin/force_signin_verifier_unittest.cc
,
Jan 2
|
||
►
Sign in to add a comment |
||
Comment 1 by toniki...@chromium.org
, Dec 21Status: Started (was: Available)