New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 911672 link

Starred by 1 user
Status: Fixed
Owner:
mheikal@chromium.org
Closed: Dec 4
Cc:
█ wnwen@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

License missing when regenerating com_google_protobuf_protobuf_lite

Project Member Reported by wnwen@chromium.org, Dec 4 
Run:
  rm -rf third_party/android_deps/libs/[!O]*
  tools/android/roll/android_deps/fetch_all.py --update-all

Expected:
  No changes

Actual:
$ git status
        deleted:    third_party/android_deps/libs/com_google_protobuf_protobuf_lite/LICENSE
        modified:   third_party/android_deps/libs/com_google_protobuf_protobuf_lite/README.chromium

May need to add a textual license file for this library under //third_party/android_deps/licenses and refer to it in ChromiumDepGraph.groovy as a special case.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d15388719c0baee935187174926e011cd809b1a

commit 9d15388719c0baee935187174926e011cd809b1a
Author: Mohamed Heikal <mheikal@chromium.org>
Date: Tue Dec 04 19:03:05 2018

[Android Deps] Add license to generator code for com_google_protobuf_protobuf_lite

Make sure that all code under
third_party/android_deps/libs/com_google_protobuf_protobuf_lite/ is
generated and not modified manually. This cl adds URL and License values
in groovy to make up for the fact that they are not supplied by the POM.

Bug:  911672 
Change-Id: Id84904fef075f4130de78f62e596d0eb33d6aeff
Reviewed-on: https://chromium-review.googlesource.com/c/1361288
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613621}
[modify] https://crrev.com/9d15388719c0baee935187174926e011cd809b1a/tools/android/roll/android_deps/buildSrc/src/main/groovy/ChromiumDepGraph.groovy

Comment 2 by mheikal@chromium.org, Dec 4

Status: Fixed (was: Assigned)
Marking as fixed
►

Sign in to add a comment