Make content_browsertests pass with --enable-features=UseSkiaRenderer,UseSkiaDeferredDisplayList |
||||||||
Issue descriptionUpdated description. Many less failing tests. Current output from a pull near 3217eb0ab0b18f3f10e33d3c65df99b70d1a7830 (Thur, Dec 13) 1 tests failed: TouchActionBrowserTest.DefaultAuto/1 (../../content/browser/renderer_host/input/touch_action_browsertest.cc:449) 5 tests timed out: AuraWindowVideoCaptureDeviceBrowserTest.DeliversRefreshFramesUponRequest (../../content/browser/media/capture/aura_window_video_capture_device_browsertest.cc:278) AuraWindowVideoCaptureDeviceBrowserTest.ErrorsOutWhenWindowIsDestroyed (../../content/browser/media/capture/aura_window_video_capture_device_browsertest.cc:222) AuraWindowVideoCaptureDeviceBrowserTest.SuspendsAndResumes (../../content/browser/media/capture/aura_window_video_capture_device_browsertest.cc:244) AuraWindowVideoCaptureDeviceBrowserTestP.CapturesContentChanges/0 (../../content/browser/media/capture/aura_window_video_capture_device_browsertest.cc:325) AuraWindowVideoCaptureDeviceBrowserTestP.CapturesContentChanges/1 (../../content/browser/media/capture/aura_window_video_capture_device_browsertest.cc:325)
,
Dec 4
Lots of likely regressions: TouchActionBrowserTest.DefaultAuto/1 fails with SkRenderer (with or without SkDDL) but passes with GLRenderer CaptureScreenshotTest.SetDefaultBackgroundColorOverride and CaptureScreenshotTest.TransparentScreenshots passes with SkRenderer but not SkDDL. SnapshotBrowserTest.SingleWindowTest SnapshotBrowserTest.SyncMultiWindowTest passes with SkRenderer and no SkDDL.
,
Dec 4
ScrollLatencyBrowserTest.SmoothWheelScroll passes with SkRenderer and no SkDDL. SnapshotBrowserTest.AsyncMultiWindowTest passes with SkRenderer and crashes with SkDDL. AuraWindowVideoCaptureDeviceBrowserTest* DevToolsVideoConsumerTest.SetMinAndMaxFramesChangesDimensions GLAndSoftwareCompositing* WebContentsVideoCaptureDeviceBrowserTest* are hitting NOTIMPLEMENTED here: https://cs.chromium.org/chromium/src/components/viz/service/display/skia_renderer.cc?rcl=28252beecf1003598727bbf40ab9e4d6a8622f16&l=1158
,
Dec 4
,
Dec 4
,
Dec 4
,
Dec 4
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f97a0d5358cf4a3bbef6e3f6329d89cee3df4984 commit f97a0d5358cf4a3bbef6e3f6329d89cee3df4984 Author: Jonathan Backer <backer@chromium.org> Date: Wed Dec 05 16:43:14 2018 Fix ScrollLatencyBrowserTest.SmoothWheelScrol for SkDDL Bug: 911643 Change-Id: Ifd28657fc81441c317abf37592e636af52c9bd54 Reviewed-on: https://chromium-review.googlesource.com/c/1363355 Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#613992} [modify] https://crrev.com/f97a0d5358cf4a3bbef6e3f6329d89cee3df4984/components/viz/service/BUILD.gn [modify] https://crrev.com/f97a0d5358cf4a3bbef6e3f6329d89cee3df4984/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc [modify] https://crrev.com/f97a0d5358cf4a3bbef6e3f6329d89cee3df4984/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.h
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/21355d4c6a7449020952ec5040b05d6ce29b8aeb commit 21355d4c6a7449020952ec5040b05d6ce29b8aeb Author: Jonathan Backer <backer@chromium.org> Date: Wed Dec 05 17:16:24 2018 Determine render_pass_id differently Looking at current_canvas_ is unreliable because it is unchanging for SkDDL. Instead compare the current_render_pass against the root_render_pass. Bug: 911643, 911804 Change-Id: I09bbdcdcf510045c9ad6a89270af581564a5a414 Reviewed-on: https://chromium-review.googlesource.com/c/1363361 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#614003} [modify] https://crrev.com/21355d4c6a7449020952ec5040b05d6ce29b8aeb/components/viz/service/display/skia_renderer.cc
,
Dec 12
,
Dec 19
,
Dec 20
,
Dec 20
With https://crrev.com/c/1387024 all the tests pass except TouchActionBrowserTest.DefaultAuto/1
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f7be72b9b4355e08b753340f8f235722a55dd5f commit 1f7be72b9b4355e08b753340f8f235722a55dd5f Author: Jonathan Backer <backer@chromium.org> Date: Fri Dec 21 23:36:05 2018 Skip makeImageSnapshot for CopyOutput readback It doesn't seem to work for the root sk_surface_ with SkDDL. Plus, we might skip an unnecessary copy. Specifically, when we do a makeImageSnapshot, we are probably doing a GPU --> GPU memory copy. This is followed by a GPU --> CPU memory copy to turn the SkImage into a SkBitmap. With the new code, Skia may optimize to a single GPU --> CPU memory copy. Bug: 911643 Change-Id: Ia456a9bba1a59f7f37134a8642a76064a54bf75f Reviewed-on: https://chromium-review.googlesource.com/c/1387024 Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#618670} [modify] https://crrev.com/1f7be72b9b4355e08b753340f8f235722a55dd5f/components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc [modify] https://crrev.com/1f7be72b9b4355e08b753340f8f235722a55dd5f/content/browser/media/capture/aura_window_video_capture_device_browsertest.cc |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by backer@chromium.org
, Dec 4Labels: Proj-Vulkanize