New issue
Advanced search Search tips

Issue 911636 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 12
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug

Blocking:
issue 831123



Sign in to add a comment

Incorrect password might be pressaved instead of the generated password with new parser

Project Member Reported by dvadym@chromium.org, Dec 4

Issue description

The new form parser might incorrectly detect a password field on password form with the generated password. As result a generated password might be not saved.
 
Blocking: 831123
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8791081237e90719fc7a998a0e39296146cd4f9e

commit 8791081237e90719fc7a998a0e39296146cd4f9e
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Wed Dec 05 15:40:04 2018

Robust saving of generated password in NewPasswordFormManager.

This CL implements that independently of parsing result the generated
password is presaved and saved.

This CL contains:

1.Replacing field has_generated_password_ with generated_password_ in
NewPasswrodFormManager. This field is used to ensure that the generated
password is saved.

2.Setting this field in PresaveGenerated

3.In case if the new parser fails, use the result of the old parser
for presaving. It's for robustness.

4.Ensure that |generated_password_| is saved during presaving/saving.

Bug:  911636 , 831123
Change-Id: Icc4e4c0bd597fc2f0da1f68a3333e7c93b8f8fb6
Reviewed-on: https://chromium-review.googlesource.com/c/1361021
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613975}
[modify] https://crrev.com/8791081237e90719fc7a998a0e39296146cd4f9e/components/password_manager/core/browser/new_password_form_manager.cc
[modify] https://crrev.com/8791081237e90719fc7a998a0e39296146cd4f9e/components/password_manager/core/browser/new_password_form_manager.h
[modify] https://crrev.com/8791081237e90719fc7a998a0e39296146cd4f9e/components/password_manager/core/browser/new_password_form_manager_unittest.cc

Labels: Merge-Request-72
Please provide more context. Why this is critical for m72, how safe is this, is this verified?
This is a M-72 regression, without this patch the generated password is not saved immediately. This patch is simple and not risky patch.
Labels: -Merge-Request-72 Merge-Approved-72
Thank you. branch:3626
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 10

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/500d8fb442f0ce6229ae6f01f9bc45889bc1b6fe

commit 500d8fb442f0ce6229ae6f01f9bc45889bc1b6fe
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Mon Dec 10 16:36:37 2018

Robust saving of generated password in NewPasswordFormManager.

This CL implements that independently of parsing result the generated
password is presaved and saved.

This CL contains:

1.Replacing field has_generated_password_ with generated_password_ in
NewPasswrodFormManager. This field is used to ensure that the generated
password is saved.

2.Setting this field in PresaveGenerated

3.In case if the new parser fails, use the result of the old parser
for presaving. It's for robustness.

4.Ensure that |generated_password_| is saved during presaving/saving.

TBR=dvadym@chromium.org

(cherry picked from commit 8791081237e90719fc7a998a0e39296146cd4f9e)

Bug:  911636 , 831123
Change-Id: Icc4e4c0bd597fc2f0da1f68a3333e7c93b8f8fb6
Reviewed-on: https://chromium-review.googlesource.com/c/1361021
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613975}
Reviewed-on: https://chromium-review.googlesource.com/c/1369857
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#201}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/500d8fb442f0ce6229ae6f01f9bc45889bc1b6fe/components/password_manager/core/browser/new_password_form_manager.cc
[modify] https://crrev.com/500d8fb442f0ce6229ae6f01f9bc45889bc1b6fe/components/password_manager/core/browser/new_password_form_manager.h
[modify] https://crrev.com/500d8fb442f0ce6229ae6f01f9bc45889bc1b6fe/components/password_manager/core/browser/new_password_form_manager_unittest.cc

Status: Fixed (was: Assigned)
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/500d8fb442f0ce6229ae6f01f9bc45889bc1b6fe

Commit: 500d8fb442f0ce6229ae6f01f9bc45889bc1b6fe
Author: dvadym@chromium.org
Commiter: dvadym@chromium.org
Date: 2018-12-10 16:36:37 +0000 UTC

Robust saving of generated password in NewPasswordFormManager.

This CL implements that independently of parsing result the generated
password is presaved and saved.

This CL contains:

1.Replacing field has_generated_password_ with generated_password_ in
NewPasswrodFormManager. This field is used to ensure that the generated
password is saved.

2.Setting this field in PresaveGenerated

3.In case if the new parser fails, use the result of the old parser
for presaving. It's for robustness.

4.Ensure that |generated_password_| is saved during presaving/saving.

TBR=dvadym@chromium.org

(cherry picked from commit 8791081237e90719fc7a998a0e39296146cd4f9e)

Bug:  911636 , 831123
Change-Id: Icc4e4c0bd597fc2f0da1f68a3333e7c93b8f8fb6
Reviewed-on: https://chromium-review.googlesource.com/c/1361021
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613975}
Reviewed-on: https://chromium-review.googlesource.com/c/1369857
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#201}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment