New issue
Advanced search Search tips

Issue 911625 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in int blink::CSSPropertyValueSet::FindPropertyIndex<blink::CSSPropertyID>

Project Member Reported by ClusterFuzz, Dec 4

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6737011605766144

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  int blink::CSSPropertyValueSet::FindPropertyIndex<blink::CSSPropertyID>
  blink::MediaControlsImpl::UpdateOverflowMenuItemCSSClass
  blink::MediaControlsImpl::UpdateOverflowMenuWanted
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=613211:613239

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6737011605766144

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 4

Components: Blink>CSS Blink>Media>Controls
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Dec 4

Labels: Test-Predator-Auto-Owner
Owner: jazzhsu@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/6ec9a91f0a6112ff42186a0da367109e0be38ab0 ([Media Controls] Overflow menu item wave animation).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5309a72cc4de68bb5ee588bc49b1a1663f0a2894

commit 5309a72cc4de68bb5ee588bc49b1a1663f0a2894
Author: Jazz Xu <jazzhsu@chromium.org>
Date: Wed Dec 05 02:40:10 2018

[Media Controls] Fix null-dereference read

Bug:  911625 
Change-Id: I19a47884f615c0cf518514bfbd07e3e631479c1c
Reviewed-on: https://chromium-review.googlesource.com/c/1362247
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613828}
[modify] https://crrev.com/5309a72cc4de68bb5ee588bc49b1a1663f0a2894/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc

Project Member

Comment 4 by ClusterFuzz, Dec 5

ClusterFuzz has detected this issue as fixed in range 613825:613831.

Detailed report: https://clusterfuzz.com/testcase?key=6737011605766144

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  int blink::CSSPropertyValueSet::FindPropertyIndex<blink::CSSPropertyID>
  blink::MediaControlsImpl::UpdateOverflowMenuItemCSSClass
  blink::MediaControlsImpl::UpdateOverflowMenuWanted
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=613211:613239
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=613825:613831

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6737011605766144

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Dec 5

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6737011605766144 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment