OmniboxViewTest.AcceptKeywordBySpace fails interactive_ui_tests failing on chromium.memory/Linux TSan Tests |
||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of guidou@chromium.org OmniboxViewTest.AcceptKeywordBySpace fails interactive_ui_tests failing on chromium.memory/Linux TSan Tests Builders failed on: - Linux TSan Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests interactive_ui_tests Run on OS: 'Ubuntu-14.04' Max shard duration: 0:11:21.525589 (shard #3) Min shard duration: 0:07:28.133091 (shard #4) failures: OmniboxViewTest.AcceptKeywordBySpace
,
Dec 4
,
Dec 4
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f584b8f37b7e82fe991371ceb56b44961cd07f8 commit 7f584b8f37b7e82fe991371ceb56b44961cd07f8 Author: Guido Urdaneta <guidou@chromium.org> Date: Tue Dec 04 12:54:11 2018 Disable flaky OmniboxViewTest.AcceptKeywordBySpace on TSAN Bug: 911614 Change-Id: I21cd0567214a8cf6767a5cf3cabb556b3b24fd3a TBR: jdonnelly@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1360614 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#613524} [modify] https://crrev.com/7f584b8f37b7e82fe991371ceb56b44961cd07f8/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
,
Dec 4
-> Untriaged, so it gets triaged by the omnibox rotation
,
Dec 5
Doesn't surprise me. Best fix is to decompose this to unit tests. See 751031 for the master bug on that.
,
Dec 5
I have an example CL on how to do this type of decomposition here: https://chromium-review.googlesource.com/1232525 Anyone can take this on if they are willing. For now I will leave this as Available. It would be a code health thing. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by guidou@chromium.org
, Dec 4Owner: jdonnelly@chromium.org
Status: Assigned (was: Available)