New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 911609 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----



Sign in to add a comment

browser_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 4

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of guidou@chromium.org

browser_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Builders failed on: 
- Linux Chromium OS ASan LSan Tests (1): 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/30403

Max shard duration: 0:23:31.968912 (shard #23)
Min shard duration: 0:14:46.604465 (shard #30)
failures:
CopyBetweenWindows/FilesAppBrowserTest.Test/copyBetweenWindowsDriveToUsb_DriveFs
CopyBetweenWindows/FilesAppBrowserTest.Test/copyBetweenWindowsDriveToUsb
 
 
Disabling tests on ASAN.
Components: Tests>Flaky
Labels: -Sheriff-Chromium
Owner: amistry@chromium.org
Status: Assigned (was: Available)
amistry@: Please take a look or help find a better owner.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/465cf593370e3bd2ce1d2287050c97e9b33f2682

commit 465cf593370e3bd2ce1d2287050c97e9b33f2682
Author: Guido Urdaneta <guidou@chromium.org>
Date: Tue Dec 04 12:33:46 2018

Disable flaky CopyBetweenWindows test on ASAN

Bug: 911609
Change-Id: Id1884d46d9ba067e0b84f4d2a4b7c34f9a601a2c
TBR: amistry@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1360634
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613522}
[modify] https://crrev.com/465cf593370e3bd2ce1d2287050c97e9b33f2682/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Cc: lucmult@chromium.org
Components: Platform>Apps>FileManager
Labels: OS-Chrome
Cc: odejesush@chromium.org sa...@chromium.org slangley@chromium.org noel@chromium.org
 Issue 911824  has been merged into this issue.

Sample error log from 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/9343


  [ RUN      ] CopyBetweenWindows/FilesAppBrowserTest.Test/copyBetweenWindowsDriveToUsb_DriveFs
  [9488:9488:1204/045533.460421:WARNING:user_policy_manager_factory_chromeos.cc(208)] No policy loaded for known non-enterprise user
  [9488:9488:1204/045533.567370:WARNING:easy_unlock_service_regular.cc(523)] EasyUnlockServiceRegular::IsInLegacyHostMode: DeviceSyncClient not ready. Returning false.
  [9488:9488:1204/045533.930202:WARNING:wallpaper_controller_client.cc(358)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances.
  [9488:9488:1204/045534.282791:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *)
  [9488:9488:1204/045534.963138:INFO:file_manager_browsertest_base.cc(1314)] FileManagerBrowserTest::StartTest copyBetweenWindowsDriveToUsb_DriveFs
  [9488:9488:1204/045539.062336:INFO:CONSOLE(837)] "Cache database creating or upgrading.", source: chrome-extension://pmfjbimdmchhbnneeidfognadeopoehp/background_scripts.js (837)
  [9488:9488:1204/045539.453186:INFO:CONSOLE(5284)] "Requesting volume list.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5284)
  [9488:9488:1204/045539.477637:INFO:CONSOLE(4682)] "Loading chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/runtime_loaded_test_util.js", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (4682)
  [9488:9488:1204/045539.479593:INFO:CONSOLE(5286)] "Volume list fetched with: 3 items.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5286)
  [9488:9488:1204/045539.479977:INFO:CONSOLE(5296)] "Initializing volume: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5296)
  [9488:9488:1204/045539.481508:INFO:CONSOLE(5760)] "Requesting file system: android_files android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5760)
  [9488:9488:1204/045539.502659:INFO:CONSOLE(5296)] "Initializing volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5296)
  [9488:9488:1204/045539.503240:INFO:CONSOLE(5760)] "Requesting file system: downloads downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5760)
  [9488:9488:1204/045539.504986:INFO:CONSOLE(5296)] "Initializing volume: drive:v2", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5296)
  [9488:9488:1204/045539.505246:INFO:CONSOLE(5760)] "Requesting file system: drive drive:v2", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5760)
  [9488:9488:1204/045539.513516:INFO:CONSOLE(646)] "Waiting for the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/runtime_loaded_test_util.js (646)
  [9488:9488:1204/045539.527648:INFO:CONSOLE(646)] "Waiting for the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/runtime_loaded_test_util.js (646)
  [9488:9488:1204/045539.641432:INFO:CONSOLE(5810)] "File system obtained: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5810)
  [9488:9488:1204/045539.642652:INFO:CONSOLE(5300)] "Initialized volume: android_files:AndroidFiles", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5300)
  [9488:9488:1204/045539.643854:INFO:CONSOLE(5810)] "File system obtained: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5810)
  [9488:9488:1204/045539.644920:INFO:CONSOLE(5300)] "Initialized volume: downloads:Downloads", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5300)
  [9488:9488:1204/045539.645223:INFO:CONSOLE(5810)] "File system obtained: drive:v2", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5810)
  [9488:9488:1204/045539.646343:INFO:CONSOLE(5300)] "Initialized volume: drive:v2", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5300)
  [9488:9488:1204/045539.646592:INFO:CONSOLE(5304)] "Initialized all volumes.", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5304)
  [9488:9488:1204/045540.005324:INFO:CONSOLE(643)] "Received the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/runtime_loaded_test_util.js (643)
  [9488:9488:1204/045540.006393:INFO:CONSOLE(0)] "HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.", source:  (0)
  [9488:9488:1204/045540.142697:INFO:CONSOLE(0)] ":unresolved pseudo selector is deprecated and will be removed in M73, around March 2019. Please use :not(:defined) instead. See https://www.chromestatus.com/features/4642138092470272 for more details.", source:  (0)
  [9488:9488:1204/045540.538467:INFO:CONSOLE(643)] "Received the result of openMainWindow", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/runtime_loaded_test_util.js (643)
  [9488:9488:1204/045540.539256:INFO:CONSOLE(0)] "HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.", source:  (0)
  [9488:9488:1204/045540.572791:INFO:CONSOLE(0)] ":unresolved pseudo selector is deprecated and will be removed in M73, around March 2019. Please use :not(:defined) instead. See https://www.chromestatus.com/features/4642138092470272 for more details.", source:  (0)
  [9488:9488:1204/045540.792766:INFO:CONSOLE(442)] "document.registerElement is deprecated and will be removed in M73, around March 2019. Please use window.customElements.define instead. See https://www.chromestatus.com/features/4642138092470272 for more details.", source: chrome://resources/polymer/v1_0/polymer/polymer-micro-extracted.js (442)
  [9488:9488:1204/045541.987342:INFO:CONSOLE(442)] "document.registerElement is deprecated and will be removed in M73, around March 2019. Please use window.customElements.define instead. See https://www.chromestatus.com/features/4642138092470272 for more details.", source: chrome://resources/polymer/v1_0/polymer/polymer-micro-extracted.js (442)
  [9488:9488:1204/045545.397496:INFO:CONSOLE(2083)] "Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details.", source: chrome://resources/polymer/v1_0/polymer/polymer-mini-extracted.js (2083)
  [9488:9488:1204/045548.308599:INFO:CONSOLE(2083)] "Element.createShadowRoot is deprecated and will be removed in M73, around March 2019. Please use Element.attachShadow instead. See https://www.chromestatus.com/features/4507242028072960 for more details.", source: chrome://resources/polymer/v1_0/polymer/polymer-mini-extracted.js (2083)
  [9488:9488:1204/045548.349059:INFO:CONSOLE(159)] "at testcase.copyBetweenWindowsDriveToUsb (/file_manager/copy_between_windows.js:124:20): waitForFiles: expected: [["photos","--","Folder","Jan 1, 1980, 11:59 PM"]] actual [].", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (159)
  [9488:9488:1204/045552.143005:INFO:CONSOLE(159)] "at testcase.copyBetweenWindowsDriveToUsb (/file_manager/copy_between_windows.js:124:20): waitForFiles: expected: [["photos","--","Folder","Jan 1, 1980, 11:59 PM"]] actual [].", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (159)
  [9488:9488:1204/045555.545776:INFO:CONSOLE(5760)] "Requesting file system: removable removable:fake-usb", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5760)
  [9488:9488:1204/045556.228240:INFO:CONSOLE(5810)] "File system obtained: removable:fake-usb", source: chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/background/js/background_common_scripts.js (5810)
  [9488:9488:1204/045601.022105:INFO:CONSOLE(159)] "at copyBetweenWindows (/file_manager/copy_between_windows.js:43:20): waitForFiles: expected: [["hello.txt","51 bytes","Plain text","Sep 4, 1998, 12:34 PM"]] actual [["photos","--","Folder","Jan 1, 1980, 11:59 PM"]].", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (159)
  [9488:9488:1204/045603.972010:INFO:CONSOLE(159)] "at copyBetweenWindows (/file_manager/copy_between_windows.js:43:20): waitForFiles: expected: [["hello.txt","51 bytes","Plain text","Sep 4, 1998, 12:34 PM"]] actual [["photos","--","Folder","Jan 1, 1980, 11:59 PM"]].", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (159)
  [9488:9488:1204/045607.013645:INFO:CONSOLE(159)] "at copyBetweenWindows (/file_manager/copy_between_windows.js:43:20): waitForFiles: expected: [["hello.txt","51 bytes","Plain text","Sep 4, 1998, 12:34 PM"]] actual [["photos","--","Folder","Jan 1, 1980, 11:59 PM"]].", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (159)
  [9488:9488:1204/045610.029740:INFO:CONSOLE(159)] "at copyBetweenWindows (/file_manager/copy_between_windows.js:43:20): waitForFiles: expected: [["hello.txt","51 bytes","Plain text","Sep 4, 1998, 12:34 PM"]] actual [["photos","--","Folder","Jan 1, 1980, 11:59 PM"]].", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (159)
  [9488:9488:1204/045612.948856:INFO:CONSOLE(159)] "at copyBetweenWindows (/file_manager/copy_between_windows.js:43:20): waitForFiles: expected: [["hello.txt","51 bytes","Plain text","Sep 4, 1998, 12:34 PM"]] actual [["photos","--","Folder","Jan 1, 1980, 11:59 PM"]].", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (159)
  BrowserTestBase received signal: Terminated. Backtrace:
  #0 0x7fe02908a3ed base::debug::StackTrace::StackTrace()
  #1 0x7fe028d8327a base::debug::StackTrace::StackTrace()
  #2 0x555a0a51fdc2 content::(anonymous namespace)::DumpStackTraceSignalHandler()
  #3 0x7fdff593ecb0 <unknown>
  #4 0x7fdff5a066d3 epoll_wait
  #5 0x7fe02913993f epoll_dispatch
  #6 0x7fe02912d0c5 event_base_loop
  #7 0x7fe0290dd7c9 base::MessagePumpLibevent::Run()
  #8 0x7fe028e150f6 base::MessageLoopImpl::Run()
  #9 0x7fe028ec0cd2 base::RunLoop::Run()
  #10 0x555a03bf76d4 file_manager::(anonymous namespace)::FileManagerTestMessageListener::GetNextMessage()
  #11 0x555a03bf6d07 file_manager::FileManagerBrowserTestBase::RunTestMessageLoop()
  #12 0x555a03bf6af9 file_manager::FileManagerBrowserTestBase::StartTest()
  #13 0x555a03bafc55 file_manager::FilesAppBrowserTest_Test_Test::RunTestOnMainThread()
  #14 0x555a0a51e2f5 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
  #15 0x555a019f4c6d _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIS4_P21RenderViewContextMenuJEEEvT_OT0_DpOT1_
  #16 0x555a019f4bb4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_
  #17 0x555a0a521155 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
  #18 0x555a0a52108c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
  #19 0x555a019e53cd _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
  #20 0x555a09249180 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
  #21 0x555a092472b4 ChromeBrowserMainParts::PreMainMessageLoopRun()
  #22 0x555a04943c9b chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
  #23 0x7fe01e5f6f82 content::BrowserMainLoop::PreMainMessageLoopRun()
  #24 0x7fe01d12154d _ZN4base8internal13FunctorTraitsIMN7content12ChildProcessEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_
  #25 0x7fe01d121494 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content12ChildProcessEFvvEJPS5_EEEvOT_DpOT0_
  #26 0x7fe01e5fcd35 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE
  #27 0x7fe01e5fcc6c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE
  #28 0x7fe01d0266ed _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
  #29 0x7fe01f5d99ed content::StartupTaskRunner::RunAllTasksNow()
  #30 0x7fe01e5f2cdf content::BrowserMainLoop::CreateStartupTasks()
  #31 0x7fe01e5ff3b3 content::BrowserMainRunnerImpl::Initialize()
  #32 0x7fe01e5ea5c9 content::BrowserMain()
  #33 0x7fe020954720 content::RunBrowserProcessMain()
  #34 0x7fe020957b55 content::ContentMainRunnerImpl::RunServiceManager()
  #35 0x7fe020956759 content::ContentMainRunnerImpl::Run()
  #36 0x7fe02094d51c content::ContentServiceManagerMainDelegate::RunEmbedderProcess()
  #37 0x7fdff3fd1a71 service_manager::Main()
  #38 0x7fe020951e35 content::ContentMain()
  #39 0x555a0a51d8a2 content::BrowserTestBase::SetUp()
  #40 0x555a090ec7eb InProcessBrowserTest::SetUp()
  #41 0x555a0900aaec extensions::ExtensionBrowserTest::SetUp()
  #42 0x555a03bf21dc file_manager::FileManagerBrowserTestBase::SetUp()
  #43 0x555a01a46c9e _ZN7testing8internal12InvokeHelperIRKNSt3__16vectorIPN12user_manager4UserENS2_9allocatorIS6_EEEENS2_5tupleIJEEEE12InvokeMethodIN8chromeos15MockUserManagerEMSH_KFSB_vEEESB_PT_T0_RKSD_
  #44 0x555a05866472 testing::internal::HandleExceptionsInMethodIfSupported<>()
  #45 0x555a058461d4 testing::Test::Run()
  #46 0x555a05846e82 testing::TestInfo::Run()
  #47 0x555a05847d9f testing::TestCase::Run()
  #48 0x555a0585bc4b testing::internal::UnitTestImpl::RunAllTests()
  #49 0x555a0586fd9e testing::internal::HandleSehExceptionsInMethodIfSupported<>()
  #50 0x555a05867be2 testing::internal::HandleExceptionsInMethodIfSupported<>()
  #51 0x555a0585b887 testing::UnitTest::Run()
  #52 0x555a09136171 RUN_ALL_TESTS()
  #53 0x555a0913333b base::TestSuite::Run()
  #54 0x555a08fdd307 ChromeTestSuiteRunner::RunTestSuite()
  #55 0x555a08fdd3f3 ChromeTestLauncherDelegate::RunTestSuite()
  #56 0x555a0a5a88f9 content::LaunchTests()
  #57 0x555a08fde742 LaunchChromeTests()
  #58 0x555a08fdcc4b main
  #59 0x7fdff5929f45 __libc_start_main
  #60 0x555a0196e90a _start

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c50cc4c031f69b3e9de96a06bef41a43012b50d

commit 9c50cc4c031f69b3e9de96a06bef41a43012b50d
Author: Ovidio Henriquez <odejesush@chromium.org>
Date: Tue Dec 04 23:37:32 2018

Disable flaky CopyBetweenWindows test

Bug:  911824 , 911609
Change-Id: I0265f663858a42b67f1cab2f1aca07dffab27497
Tbr: amistry@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1362290
Reviewed-by: Ovidio Henriquez <odejesush@chromium.org>
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613760}
[modify] https://crrev.com/9c50cc4c031f69b3e9de96a06bef41a43012b50d/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Owner: lucmult@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba4cf64ec6d7268f1a6922c39198f5b419cbac6f

commit ba4cf64ec6d7268f1a6922c39198f5b419cbac6f
Author: Sam McNally <sammc@chromium.org>
Date: Thu Dec 06 05:32:12 2018

Deflake CopyBetweenWindows/FilesAppBrowserTest tests.

Bug: 911609
Change-Id: I69434c3516bc8867eb0a67e2c6df4699887d8ff2
Reviewed-on: https://chromium-review.googlesource.com/c/1364970
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614275}
[modify] https://crrev.com/ba4cf64ec6d7268f1a6922c39198f5b419cbac6f/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/ba4cf64ec6d7268f1a6922c39198f5b419cbac6f/ui/file_manager/file_manager/foreground/js/directory_model.js

Cause was issue 873539#c30 and we have a handle on the fix(es), comming ...

Project Member

Comment 13 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6562ea1bc24eddee0a22b8d8d64614e69b3792c2

commit 6562ea1bc24eddee0a22b8d8d64614e69b3792c2
Author: Noel Gordon <noel@chromium.org>
Date: Thu Dec 06 06:25:30 2018

Update comment after CL:1364970

The fix for bug 911609 obsoleted a comment about the affected JS code.
Let's update the comment too.

No-try: true
Bug: 873539, 911609
Change-Id: I2477ce8082724bd9ca3f2ab70cd169d6579b22e4
Reviewed-on: https://chromium-review.googlesource.com/c/1364971
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614281}
[modify] https://crrev.com/6562ea1bc24eddee0a22b8d8d64614e69b3792c2/ui/file_manager/file_manager/foreground/js/directory_model.js

Project Member

Comment 14 by bugdroid1@chromium.org, Dec 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3272f73f06312a50d6601bda8dbf737cbbae3874

commit 3272f73f06312a50d6601bda8dbf737cbbae3874
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Fri Dec 07 04:32:27 2018

Deflake DirectoryTreeContextMenu tests

Change flake tests to use expandTreeItemInDirectoryTree and fix it to
wait for the tree-item being expanded to have "has-children" attribute,
so the click to expand actually works.

Change expandTreeItemInDirectoryTree to use |waitAndClickElement| and
to do so, move it from RemoteCallGallery to the RemoteCall base class.
Change its callbacks from anonymous function to arrow function.

Enable dirRenameWithoutChangingCurrent to run with MyFilesVolume flag
enabled.

Bug: 911609
Change-Id: I10387aef5f213ac2c39f253bf041a5003a2cde17
Reviewed-on: https://chromium-review.googlesource.com/c/1364932
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614584}
[modify] https://crrev.com/3272f73f06312a50d6601bda8dbf737cbbae3874/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/3272f73f06312a50d6601bda8dbf737cbbae3874/ui/file_manager/integration_tests/file_manager/directory_tree_context_menu.js
[modify] https://crrev.com/3272f73f06312a50d6601bda8dbf737cbbae3874/ui/file_manager/integration_tests/remote_call.js

Sign in to add a comment