New issue
Advanced search Search tips

Issue 911562 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 5
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.8% regression in system_health.memory_mobile at 611891:612010

Project Member Reported by toyoshim@chromium.org, Dec 4

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=911562

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=23aeacb856bd3ef480c364126a31d22681f47378cd2efde3a0d79f4016c725d1


Bot(s) for this bug's original alert(s):

android-nexus5x-perf

system_health.memory_mobile - Benchmark documentation link:
  https://bit.ly/system-health-benchmarks
Cc: lucmult@chromium.org
Owner: lucmult@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12c8339fe40000

Files app: Change FMP.StartCopy to ues MyFiles path to check disk space by lucmult@chromium.org
https://chromium.googlesource.com/chromium/src/+/604074aaafa8005d0b553fa7a17163d9e41ffffd
memory:chrome:all_processes:reported_by_os:system_memory:proportional_resident_size: 2.617e+08 → 2.661e+08 (+4.396e+06)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/system-health-benchmarks
Owner: toyoshim@chromium.org
This change only affects chromeos build, so I don't see how it could impact memory in android.

The only file changed in this CL is here:
chrome/browser/chromeos/file_manager/path_util.cc

Also, it changes from a function that's pretty much the same as before, I believe something is wrong in the detection.

The build file has an assert(is_chromeos):
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/BUILD.gn?l=15&rcl=d1c6a0c1985aae3d9844fe2ee75ff7919fed0ee3
Status: WontFix (was: Assigned)
In general, please follow the step if your change should not be a root cause.

https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md#If-you-don_t-believe-your-CL-could-be-the-cause

But, this time, the regression is very very small, and probably this was a false alert. So, let me close this now.

Sign in to add a comment