Issue metadata
Sign in to add a comment
|
2.8% regression in system_health.memory_mobile at 611891:612010 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Dec 4
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12c8339fe40000
,
Dec 4
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/12c8339fe40000 Files app: Change FMP.StartCopy to ues MyFiles path to check disk space by lucmult@chromium.org https://chromium.googlesource.com/chromium/src/+/604074aaafa8005d0b553fa7a17163d9e41ffffd memory:chrome:all_processes:reported_by_os:system_memory:proportional_resident_size: 2.617e+08 → 2.661e+08 (+4.396e+06) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: https://bit.ly/system-health-benchmarks
,
Dec 5
This change only affects chromeos build, so I don't see how it could impact memory in android. The only file changed in this CL is here: chrome/browser/chromeos/file_manager/path_util.cc Also, it changes from a function that's pretty much the same as before, I believe something is wrong in the detection. The build file has an assert(is_chromeos): https://cs.chromium.org/chromium/src/chrome/browser/chromeos/BUILD.gn?l=15&rcl=d1c6a0c1985aae3d9844fe2ee75ff7919fed0ee3
,
Dec 5
In general, please follow the step if your change should not be a root cause. https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md#If-you-don_t-believe-your-CL-could-be-the-cause But, this time, the regression is very very small, and probably this was a false alert. So, let me close this now. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Dec 4