New issue
Advanced search Search tips

Issue 911534 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Refactor omnibox on-scroll keyboard dismissal

Project Member Reported by stkhapugin@chromium.org, Dec 4

Issue description

There is a desired behavior of omnibox dismissing the keyboard when the suggestion list is being scrolled.

The real logic is: "On scroll, if on iPhone, [omnibox resignFirstResponder]".

Currently it's implemented with 3 levels of indirection and 4 method calls. This seems over the top:

PopupViewController -(delegate)-> PopupMediator -(delegate)-> OmniboxPopupViewIOS -(delegate)->OmniboxViewIOS

Seems like a better way would be PopupViewController -> Dispatcher -> OmniboxViewController. 


 

Sign in to add a comment