Merge Fix of WebRTC Event Logging CPU-Overuse into M72 |
|||||||
Issue descriptionThe following CLs need to be merged into M72: 1. https://webrtc-review.googlesource.com/c/src/+/112598 2. https://webrtc-review.googlesource.com/c/src/+/112860 3. https://chromium-review.googlesource.com/c/chromium/src/+/1356800 These CLs fix an issue that caused CPU-overuse when producing WebRTC event logs. All three CLs are on 73.0.3630.0. Tested there; works.
,
Dec 4
,
Dec 4
,
Dec 5
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30600f99be877a4f7cf9850f407fb8b63211b4da commit 30600f99be877a4f7cf9850f407fb8b63211b4da Author: Elad Alon <eladalon@chromium.org> Date: Wed Dec 05 10:52:41 2018 Fix CPU overuse caused by WebRTC event logs not being batched Use batches of 5 seconds instead of immediate log emission. (An upcoming CL should make this configurable from JS.) Bug: 910576 , 911514 Change-Id: Ib2b804e1e8c7798b744548fb343776fa8a315a65 Reviewed-on: https://chromium-review.googlesource.com/c/1356800 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612663}(cherry picked from commit de9c922fc0c4954feada059fdd8d4c3f12fbd37e) Reviewed-on: https://chromium-review.googlesource.com/c/1362898 Reviewed-by: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#71} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/30600f99be877a4f7cf9850f407fb8b63211b4da/content/renderer/media/webrtc/rtc_peer_connection_handler.cc
,
Dec 10
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30600f99be877a4f7cf9850f407fb8b63211b4da Commit: 30600f99be877a4f7cf9850f407fb8b63211b4da Author: eladalon@chromium.org Commiter: eladalon@chromium.org Date: 2018-12-05 10:52:41 +0000 UTC Fix CPU overuse caused by WebRTC event logs not being batched Use batches of 5 seconds instead of immediate log emission. (An upcoming CL should make this configurable from JS.) Bug: 910576 , 911514 Change-Id: Ib2b804e1e8c7798b744548fb343776fa8a315a65 Reviewed-on: https://chromium-review.googlesource.com/c/1356800 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#612663}(cherry picked from commit de9c922fc0c4954feada059fdd8d4c3f12fbd37e) Reviewed-on: https://chromium-review.googlesource.com/c/1362898 Reviewed-by: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#71} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by eladalon@chromium.org
, Dec 4