Video on MacOS

Deleted: missing-loader-icon.mov 385 KB

	missing-loader-icon.mov 385 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bfabec2ac11decb989a7a03ea5980eaf56893e6

commit 0bfabec2ac11decb989a7a03ea5980eaf56893e6
Author: Peter Boström <pbos@chromium.org>
Date: Tue Dec 04 16:11:04 2018

Revert "Fix layout/repaint of tab on focus or alert change."

This reverts commit d80f1a220d9c95ab45afb8fdc44a2b926893132a.

Reason for revert: Tab icons are no longer reliably laid out.

Bug:  chromium:911508 

Original change's description:
> Fix layout/repaint of tab on focus or alert change.
> 
> Also removes code associated with "show close button on hover" in
> non-touch situations because showing of close button on inactive tabs is
> now purely a function of tab size and the code had no effect.
> 
> Previously, tabs were relying on invalidation of the tabstrip to repaint
> when active status changed. This resulted in cases where when the number
> of tabs at minimum size exceded the size of the browser window, pinned
> tabs would not repaint when a new tab was added, resulting in them
> appearing to still be active (until something else invalidated the
> tabstrip, like a mouse event or resize).
> 
> Now we're using InvalidateLayout() and SchedulePaint() correctly to make
> sure things which could change the render or layout state of a tab
> result in the tab being laid out and/or repainted.
> 
> Bug:  896849 
> Change-Id: If2fcdafe80a0d22dc1d7c5c2c4a703729b8ed55b
> Reviewed-on: https://chromium-review.googlesource.com/c/1357329
> Commit-Queue: Dana Fried <dfried@chromium.org>
> Reviewed-by: Peter Boström <pbos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#613252}

TBR=pbos@chromium.org,dfried@chromium.org

Change-Id: Ic7f3900d75aab0eda985368785b9182835b15d35
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  896849 
Reviewed-on: https://chromium-review.googlesource.com/c/1361301
Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613567}
[modify] https://crrev.com/0bfabec2ac11decb989a7a03ea5980eaf56893e6/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/0bfabec2ac11decb989a7a03ea5980eaf56893e6/chrome/browser/ui/views/tabs/tab_controller.h
[modify] https://crrev.com/0bfabec2ac11decb989a7a03ea5980eaf56893e6/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/0bfabec2ac11decb989a7a03ea5980eaf56893e6/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/0bfabec2ac11decb989a7a03ea5980eaf56893e6/chrome/browser/ui/views/tabs/tab_strip_unittest.cc
[modify] https://crrev.com/0bfabec2ac11decb989a7a03ea5980eaf56893e6/chrome/browser/ui/views/tabs/tab_unittest.cc

Not directly related to the tab-loading animation. Tab icons aren't laid out when the tab contents change, the favicon + animations appear again if you click on a tab switch windows back and forth.

[Auto-generated comment by a script] We noticed that this issue is targeted for M-72; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-72 label, otherwise remove Merge-TBD label. Thanks.

Culprit landed in 73.0.3630.0 so this should not hit M72 at all.

Thank you for catching this. Can't imagine why I didn't.
Might have been an interaction with a later change to tab loading animations than the one I was working off of.

I'll fix and resubmit.

 Issue 911719  has been merged into this issue.