New issue
Advanced search Search tips

Issue 911444 link

Starred by 1 user
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Dec 10
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessary grey focus highlight is seen on check box in chrome://history page.

Reported by rp...@virtusa.com, Dec 4 
Chrome Version:73.0.3629.0 (Official Build) Revision e65f720d1d3d9b1817d178fcabcfd2bf54f2061c-refs/branch-heads/3629@{#1}(32/64-bit)
OS: Windows(7,8,8.1,10) , Mac(10.13.1 , 10.13.6 , 10.14.2) and Linux(14.04 LTS)OS 

What steps will reproduce the problem?
1. Launch chrome ,navigate to chrome://history/
2. Now click on 'Actions' iron icon to open drop down list and click on 'Remove from history' option and observe focus

Actual  : Unnecessary grey focus highlight is seen on check box on removing history item
Expected: Grey focus highlight should be seen on 'Actions' iron icon on removing history item

This is a regression issue broken in ‘M-72’ and below is the bisect information:
Good Build: 72.0.3611.0 (Revision : 608212)
Bad Build : 72.0.3612.0 (Revision : 608630)

You are probably looking for a change made after 608561 (known good), but no later than 608562 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/9b0436b7f7661e562fb0cb2d5d3aec70aa1d966f..292d851b752f8a97a347ecdf8e1f412afe9bcc37	

Suspecting: https://chromium.googlesource.com/chromium/src/+/292d851b752f8a97a347ecdf8e1f412afe9bcc37

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly review the attached screen-cast for reference.

Note : Able to reproduce issue on Dev #72.0.3622.0

Thank you.
Actual_video.mov
6.1 MB View Download
Expected_video.mov
4.1 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8590a077110d1cc40a70fe053f76f0056569027c

commit 8590a077110d1cc40a70fe053f76f0056569027c
Author: rbpotter <rbpotter@chromium.org>
Date: Sat Dec 08 03:32:33 2018

History/Settings: Maintain focus position when items are removed

Removing items results in focus leaving the list and then being
restored directly to a list item, because when preserve-focus is set
iron-list calls blur() on the currently focused element and then focuses
the next item in the list.

Normally, we want to reset the focus position if focus leaves the list
and is then restored to a list item, as this occurs when the user blurs
the list and then tabs back into the list from the beginning.

The difference between these cases can be detected by watching
ironListTabIndex, which changes when items are added to or removed from
the list. Clearing the listBlurred parameter in this case means that
FocusRowBehavior will treat the subsequent focus event as if focus had
never left the list, which is the desired behavior.

Also fixing some runtime errors observed on chrome://history, that
are likely due to Polymer 2 allowing observers to be called with
undefined arguments. These errors seemed to show up consistently with
this CL in debug builds, so it appears the change altered the timing
slightly and triggers the observers being called before their
arguments are defined.

Bug:  911444 , 912926, 912900
Change-Id: Ib1a04ed0da6650d2f5e24787e36f4247c0364d51
Reviewed-on: https://chromium-review.googlesource.com/c/1368782
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614935}
[modify] https://crrev.com/8590a077110d1cc40a70fe053f76f0056569027c/chrome/browser/resources/md_history/history_item.js
[modify] https://crrev.com/8590a077110d1cc40a70fe053f76f0056569027c/chrome/browser/resources/md_history/history_list.js
[modify] https://crrev.com/8590a077110d1cc40a70fe053f76f0056569027c/ui/webui/resources/js/cr/ui/focus_row_behavior.js

Comment 2 by rp...@virtusa.com, Dec 10

Labels: TE-Verified-M73 TE-Verified-73.0.3636.0
Update :
Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS) and Mac OS X(10.13.1,10.13.6,10.14.2) using latest Canary build : 73.0.3636.0 and the issue is Fixed.Hence adding TE Verified Labels.

Kindly refer the attached screen cast.

Thank you..!!
Fixed_video.mov
7.6 MB View Download

Comment 3 by rbpotter@chromium.org, Dec 10

Status: Verified (was: Assigned)
►

Sign in to add a comment