New issue
Advanced search Search tips

Issue 911442 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 678905



Sign in to add a comment

[WPT] New failures introduced in external/wpt/service-workers by import https://crrev.com/c/1359866

Issue description

WPT import https://crrev.com/c/1359866 introduced new failures in external/wpt/service-workers:

List of new failures:
[ Mac-mac10.11 ] virtual/outofblink-cors/external/wpt/service-workers/service-worker/clients-matchall-client-types.https.html new failing tests: https://crrev.com/c/1359866/4/third_party/blink/web_tests/platform/mac-mac10.11/virtual/outofblink-cors/external/wpt/service-workers/service-worker/clients-matchall-client-types.https-expected.txt
[ Mac-retina ] virtual/outofblink-cors/external/wpt/service-workers/service-worker/clients-matchall-client-types.https.html new failing tests: https://crrev.com/c/1359866/4/third_party/blink/web_tests/platform/mac-retina/virtual/outofblink-cors/external/wpt/service-workers/service-worker/clients-matchall-client-types.https-expected.txt
[ Mac-mac10.11 ] external/wpt/service-workers/service-worker/clients-matchall-client-types.https.html new failing tests: https://crrev.com/c/1359866/4/third_party/blink/web_tests/platform/mac-mac10.11/virtual/outofblink-cors/external/wpt/service-workers/service-worker/clients-matchall-client-types.https-expected.txt
[ Mac-retina ] external/wpt/service-workers/service-worker/clients-matchall-client-types.https.html new failing tests: https://crrev.com/c/1359866/4/third_party/blink/web_tests/platform/mac-retina/virtual/outofblink-cors/external/wpt/service-workers/service-worker/clients-matchall-client-types.https-expected.txt

This import contains upstream changes from b158c0c511481efaeb9dd5fcabbac5aad4c228ba to 1abcb7058ecdaabd5fe9c27c90a73795d31d2a0a:
[service-workers] Use asynchronous cleanup (#13164): https://github.com/web-platform-tests/wpt/commit/1abcb7058ecdaabd5fe9c27c90a73795d31d2a0a [affecting this directory]
Rename audio-output idlharness test for secure context change (#14337): https://github.com/web-platform-tests/wpt/commit/ef72a20e3dbb89e06df6d193294aed9361f4ad42
Simplify interpolation of 2-D matrix transforms.: https://github.com/web-platform-tests/wpt/commit/a0aee6e93a0d8d367df19b14dd2facef903a2a63
Update the docker image: https://github.com/web-platform-tests/wpt/commit/7de8ae387ff302a7c429a5f2788e87120bab7128
Fetch tags on initial clone: https://github.com/web-platform-tests/wpt/commit/3c36672a946d62721369d515a577569f0109ea4e
Move most of start.sh to outside the Docker image: https://github.com/web-platform-tests/wpt/commit/dedf2359323acdf651d309ec1911f52406ca55eb
[Background Fetch] Remove records_ from BackgroundFetchRegistration.: https://github.com/web-platform-tests/wpt/commit/073eaac34d507b0ab4c9e2bf0c0d85d9e39cdc2c

 
Blocking: 678905
Labels: Pri-2 Type-Bug
Owner: falken@chromium.org
Status: Started (was: Untriaged)
This is from https://github.com/web-platform-tests/wpt/pull/13164 which I reviewed. Looking.
For the root clients-matchall-client-types, the test was already failing, and this slightly changed the expectations.

For the virtual/outofblink-cors and outofblink-cors-ns variant,
there are diff expectations for Mac vs other platforms, which we wouldn't expect. The test has been flaky on Mac since at least 612923, which predates this WPT import:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/36871
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=clients-matchall-client-types.https.html
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d96c8eda9afb578f13ed9e952b69c525f539ce7f

commit d96c8eda9afb578f13ed9e952b69c525f539ce7f
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Dec 04 09:38:35 2018

Gardening: Tweak outofblink-cors failures after WPT import.

The import bot at https://crrev.com/c/1359866 added Mac expectations for
outofblink-cors/external/wpt/service-workers/service-worker/clients-matchall-client-types,
which is surprising because the test should have no platform
differences. Probably the test is just flaky everywhere. Remove the Mac
expectations in favor of flaky expectations.

Bug:  911442 , 870173
Change-Id: I1cfae61ceee615bcd5654920590a53c0d8447d3e
TBR: toyoshim
Reviewed-on: https://chromium-review.googlesource.com/c/1360453
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613484}
[modify] https://crrev.com/d96c8eda9afb578f13ed9e952b69c525f539ce7f/third_party/blink/web_tests/TestExpectations
[delete] https://crrev.com/4413fc16ca9a076f683f6cdbaa4e43b8166f4c99/third_party/blink/web_tests/platform/mac-mac10.11/virtual/outofblink-cors/external/wpt/service-workers/service-worker/clients-matchall-client-types.https-expected.txt
[delete] https://crrev.com/4413fc16ca9a076f683f6cdbaa4e43b8166f4c99/third_party/blink/web_tests/platform/mac-retina/virtual/outofblink-cors/external/wpt/service-workers/service-worker/clients-matchall-client-types.https-expected.txt

Actually the flakiness on outofblink-cors seems to have disappeared according to flakiness dashboard. I'll remove the flaky expectation.
Status: Fixed (was: Started)
This change in expectations has been triaged. issue 751959 remains to track this test failing.

Sign in to add a comment