New issue
Advanced search Search tips

Issue 911438 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Showtime default app order must be wrong

Project Member Reported by benwells@google.com, Dec 4

Issue description

While I can't test this, the ID for showtime is definitely incorrect.
 
Cc: sdantul...@chromium.org
Owner: benwells@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e82243c3b17af75e80481f89580f339b5edf18e2

commit e82243c3b17af75e80481f89580f339b5edf18e2
Author: Ben Wells <benwells@chromium.org>
Date: Wed Dec 05 06:08:01 2018

Fix showtime app id for default app ordering.

Bug:  911438 
Change-Id: I6890242edf97abb7cbc6d025bfa02fef0685ed70
Reviewed-on: https://chromium-review.googlesource.com/c/1360255
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613881}
[modify] https://crrev.com/e82243c3b17af75e80481f89580f339b5edf18e2/chrome/browser/chromeos/extensions/default_web_app_ids.h

Labels: Merge-Request-72
Blocking: 882945
Blocking: -882945
Project Member

Comment 6 by sheriffbot@chromium.org, Dec 7

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 10

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0208a116c5d4807183cfe2d79b34c841dd25d78d

commit 0208a116c5d4807183cfe2d79b34c841dd25d78d
Author: Ben Wells <benwells@chromium.org>
Date: Mon Dec 10 06:31:50 2018

Fix showtime app id for default app ordering.

TBR=benwells@chromium.org

(cherry picked from commit e82243c3b17af75e80481f89580f339b5edf18e2)

Bug:  911438 
Change-Id: I6890242edf97abb7cbc6d025bfa02fef0685ed70
Reviewed-on: https://chromium-review.googlesource.com/c/1360255
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613881}
Reviewed-on: https://chromium-review.googlesource.com/c/1369745
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#171}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/0208a116c5d4807183cfe2d79b34c841dd25d78d/chrome/browser/chromeos/extensions/default_web_app_ids.h

Status: Fixed (was: Assigned)
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/0208a116c5d4807183cfe2d79b34c841dd25d78d

Commit: 0208a116c5d4807183cfe2d79b34c841dd25d78d
Author: benwells@chromium.org
Commiter: benwells@chromium.org
Date: 2018-12-10 06:31:50 +0000 UTC

Fix showtime app id for default app ordering.

TBR=benwells@chromium.org

(cherry picked from commit e82243c3b17af75e80481f89580f339b5edf18e2)

Bug:  911438 
Change-Id: I6890242edf97abb7cbc6d025bfa02fef0685ed70
Reviewed-on: https://chromium-review.googlesource.com/c/1360255
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613881}
Reviewed-on: https://chromium-review.googlesource.com/c/1369745
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#171}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment