New issue
Advanced search Search tips

Issue 911425 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

chromium_presubmit keeps failing

Project Member Reported by tikuta@chromium.org, Dec 4

Issue description

https://ci.chromium.org/p/chromium/builders/luci.chromium.try/chromium_presubmit?limit=200

Traceback (most recent call last):
  File "/b/swarming/w/ir/kitchen-checkout/recipe_engine/recipe_engine/run.py", line 287, in _new_run
    recipe_result = recipe_script.run(api, self.properties, self.environ)
  File "/b/swarming/w/ir/kitchen-checkout/recipe_engine/recipe_engine/loader.py", line 108, in run
    self.run_steps, properties, environ, self.PROPERTIES, api=api)
  File "/b/swarming/w/ir/kitchen-checkout/recipe_engine/recipe_engine/loader.py", line 636, in invoke_with_properties
    arg_names, **additional_args)
  File "/b/swarming/w/ir/kitchen-checkout/recipe_engine/recipe_engine/loader.py", line 599, in _invoke_with_properties
    return callable_obj(*props, **additional_args)
  File "/b/swarming/w/ir/kitchen-checkout/build/scripts/slave/recipes/run_presubmit.py", line 124, in RunSteps
    return _RunStepsInternal(api)
  File "/b/swarming/w/ir/kitchen-checkout/build/scripts/slave/recipes/run_presubmit.py", line 30, in _RunStepsInternal
    api.gclient.set_config(repo_name)
  File "/b/swarming/w/ir/kitchen-checkout/recipe_engine/recipe_engine/recipe_api.py", line 983, in set_config
    config, _ = self.make_config_params(config_name, optional, **CONFIG_VARS)
  File "/b/swarming/w/ir/kitchen-checkout/recipe_engine/recipe_engine/recipe_api.py", line 964, in make_config_params
    itm = ctx.CONFIG_ITEMS[config_name] if config_name else None
KeyError: 'chromium'
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18

commit a22fd4cad2247c47db47ff1f6c7bb4272a61fd18
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Tue Dec 04 04:48:43 2018

Revert "run_presubmit: update to use buildbucket API."

This reverts commit 3b60b9fffff5885840ab39a0d9682af42b007d97.

Reason for revert: likely caused crbug/911425

Original change's description:
> run_presubmit: update to use buildbucket API.
> 
> R=​jchinlee, nodir
> 
> Change-Id: I9ffd8e929e1d7ef88886eb3cd19b91807bb1d90d
> Reviewed-on: https://chromium-review.googlesource.com/c/1360112
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>

TBR=nodir@chromium.org,jchinlee@chromium.org,tandrii@chromium.org

Change-Id: I1be8184f66fd15b17480bf54e0f7265b818d50da
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 911425
Reviewed-on: https://chromium-review.googlesource.com/c/1359894
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/presubmit-infra-failure.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/chrome_golo.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/gyp.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/skia.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/v8_with_cache.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/webports.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/pdfium.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/catapult.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/build.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/internal_deps.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/presubmit-failure.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/chromium_timeout.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/infra_with_runhooks.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/recipes-py.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/v8.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/luci-py.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/build_internal_scripts_slave.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/depot_tools.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/chromium.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/webrtc.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/chromium_dry_run.json
[rename] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/repository_url.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/v8_with_cache_infra_config_branch.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/master_deps.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.py
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/README.recipes.md
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/build_internal.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/slave_deps.json
[modify] https://crrev.com/a22fd4cad2247c47db47ff1f6c7bb4272a61fd18/scripts/slave/recipes/run_presubmit.expected/nacl.json

Labels: -Pri-0 Pri-1
Owner: tandrii@chromium.org
Status: Assigned (was: Untriaged)
Resolved with a revert. Kudos to tikuta@ for escalating and finding the culprit.
Question: don't we have some alert for this type of consistent infra failure?
Unfortunately, the CL landed shortly after our shift ended; troopers wouldn't have seen the alert until 9am today.

Probably prudent to land things like this during alerting hours.
Issue 911378 has been merged into this issue.

Sign in to add a comment