New issue
Advanced search Search tips

Issue 911415 link

Starred by 2 users
Status: Assigned
Owner:
nhiroki@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocked on:
issue 869748


Sign in to add a comment

OnionSoup: Shared Workers

Project Member Reported by nhiroki@chromium.org, Dec 4 
Shared Workers should be onion-soupified.

See the following doc about the Onion Soup:
https://docs.google.com/document/d/1K1nO8G9dO9kNSmtVz2gJ2GG9gQOTgm65sJlV3Fga4jE/edit#

Briefly speaking, for architectural cleanup, we move mojom files in content/common/shared_worker/ to third_party/blink/public/mojom/worker/, and then move worker implementation in content/renderer/shared_worker/ to third_party/blink/renderer/core/workers/.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0dee838eecaf3c0d202b4ef623f6fc81f6a48db

commit d0dee838eecaf3c0d202b4ef623f6fc81f6a48db
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Tue Dec 04 11:19:10 2018

Worker: Move shared_worker_client.mojom from content/ to blink/ (Onion Soup)

This CL moves shared_worker_client.mojom from content/common/shared_worker/ to
third_party/blink/public/mojom/worker as a part of the Onion Soup project.

A follow-up CL will remove SharedWorkerClientImpl that is a thin layer between
Blink and Content.

Bug: 911415
Change-Id: If53022045987be3612c6af1fb34d6b83012f88f0
Reviewed-on: https://chromium-review.googlesource.com/c/1360253
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613506}
[modify] https://crrev.com/d0dee838eecaf3c0d202b4ef623f6fc81f6a48db/content/browser/worker_host/mock_shared_worker.cc
[modify] https://crrev.com/d0dee838eecaf3c0d202b4ef623f6fc81f6a48db/content/browser/worker_host/mock_shared_worker.h
[modify] https://crrev.com/d0dee838eecaf3c0d202b4ef623f6fc81f6a48db/content/browser/worker_host/shared_worker_connector_impl.cc
[modify] https://crrev.com/d0dee838eecaf3c0d202b4ef623f6fc81f6a48db/content/browser/worker_host/shared_worker_connector_impl.h
[modify] https://crrev.com/d0dee838eecaf3c0d202b4ef623f6fc81f6a48db/content/browser/worker_host/shared_worker_host.cc
[modify] https://crrev.com/d0dee838eecaf3c0d202b4ef623f6fc81f6a48db/content/browser/worker_host/shared_worker_host.h
[modify] https://crrev.com/d0dee838eecaf3c0d202b4ef623f6fc81f6a48db/content/browser/worker_host/shared_worker_host_unittest.cc
[modify] https://crrev.com/d0dee838eecaf3c0d202b4ef623f6fc81f6a48db/content/browser/worker_host/shared_worker_service_impl.cc
[modify] https://crrev.com/d0dee838eecaf3c0d202b4ef623f6fc81f6a48db/content/browser/worker_host/shared_worker_service_impl.h
[modify] https://crrev.com/d0dee838eecaf3c0d202b4ef623f6fc81f6a48db/content/browser/worker_host/shared_worker_service_impl_unittest.cc
[modify] https://crrev.com/d0dee838eecaf3c0d202b4ef623f6fc81f6a48db/content/common/BUILD.gn
[modify] https://crrev.com/d0dee838eecaf3c0d202b4ef623f6fc81f6a48db/content/common/shared_worker/shared_worker_connector.mojom
[modify] https://crrev.com/d0dee838eecaf3c0d202b4ef623f6fc81f6a48db/content/renderer/shared_worker/shared_worker_client_impl.h
[modify] https://crrev.com/d0dee838eecaf3c0d202b4ef623f6fc81f6a48db/content/renderer/shared_worker/shared_worker_repository.cc
[modify] https://crrev.com/d0dee838eecaf3c0d202b4ef623f6fc81f6a48db/content/renderer/shared_worker/shared_worker_repository.h
[modify] https://crrev.com/d0dee838eecaf3c0d202b4ef623f6fc81f6a48db/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/d0dee838eecaf3c0d202b4ef623f6fc81f6a48db/third_party/blink/public/mojom/worker/shared_worker_client.mojom
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2e5ff8a170be3b93bd44867c229dc6e1c43137c

commit e2e5ff8a170be3b93bd44867c229dc6e1c43137c
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Wed Dec 05 09:25:14 2018

Worker: Remove unused WebSharedWorkerClient::NotificationPresenter()

Bug: 911415
Change-Id: Id036431348a94325b856a1b484a16fb70925a6fe
Reviewed-on: https://chromium-review.googlesource.com/c/1362716
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613913}
[modify] https://crrev.com/e2e5ff8a170be3b93bd44867c229dc6e1c43137c/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/e2e5ff8a170be3b93bd44867c229dc6e1c43137c/content/renderer/shared_worker/embedded_shared_worker_stub.h
[modify] https://crrev.com/e2e5ff8a170be3b93bd44867c229dc6e1c43137c/third_party/blink/public/web/web_shared_worker_client.h
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d6bb3e78c7e797d14379b8b97d25e6d99b319db

commit 2d6bb3e78c7e797d14379b8b97d25e6d99b319db
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Wed Dec 05 13:13:08 2018

Worker: Add README.md to third_party/blink/public/mojom/worker/

This is a follow-up CL for previous review comments:
https://chromium-review.googlesource.com/c/chromium/src/+/1358197/3#message-ed8eeb89d834aef392b64e425d8faf18414c18bf

Bug: 911415
Change-Id: Ie784a6f07bc4e117c025543876ff098619e5f0c6
Reviewed-on: https://chromium-review.googlesource.com/c/1363112
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613950}
[add] https://crrev.com/2d6bb3e78c7e797d14379b8b97d25e6d99b319db/third_party/blink/public/mojom/worker/README.md
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/792fcc3ac0290a37dede266b7561e6e365e86396

commit 792fcc3ac0290a37dede266b7561e6e365e86396
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Thu Dec 06 06:50:57 2018

CSP: Move content_security_policy.mojom from public/platform/ to public/mojom/csp/

This CL just moves content_security_policy.mojom from public/platform/ to
public/mojom/csp/ for cleanup.

This is useful for onion-soupifying shared workers without an additional
dependency in BUILD.gn.

Change-Id: I1292c6f18613be38c44e592fc1fe8a35fe070966
Bug: 911415
Reviewed-on: https://chromium-review.googlesource.com/c/1362703
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614283}
[modify] https://crrev.com/792fcc3ac0290a37dede266b7561e6e365e86396/content/browser/DEPS
[modify] https://crrev.com/792fcc3ac0290a37dede266b7561e6e365e86396/content/browser/worker_host/shared_worker_instance.h
[modify] https://crrev.com/792fcc3ac0290a37dede266b7561e6e365e86396/content/common/DEPS
[modify] https://crrev.com/792fcc3ac0290a37dede266b7561e6e365e86396/content/common/content_param_traits_macros.h
[modify] https://crrev.com/792fcc3ac0290a37dede266b7561e6e365e86396/content/common/content_security_policy_header.h
[modify] https://crrev.com/792fcc3ac0290a37dede266b7561e6e365e86396/content/common/shared_worker/shared_worker_info.mojom
[modify] https://crrev.com/792fcc3ac0290a37dede266b7561e6e365e86396/content/renderer/shared_worker/shared_worker_repository.h
[modify] https://crrev.com/792fcc3ac0290a37dede266b7561e6e365e86396/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/792fcc3ac0290a37dede266b7561e6e365e86396/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/792fcc3ac0290a37dede266b7561e6e365e86396/third_party/blink/public/mojom/csp/OWNERS
[add] https://crrev.com/792fcc3ac0290a37dede266b7561e6e365e86396/third_party/blink/public/mojom/csp/README.md
[rename] https://crrev.com/792fcc3ac0290a37dede266b7561e6e365e86396/third_party/blink/public/mojom/csp/content_security_policy.mojom
[modify] https://crrev.com/792fcc3ac0290a37dede266b7561e6e365e86396/third_party/blink/public/platform/web_content_security_policy_struct.h
[modify] https://crrev.com/792fcc3ac0290a37dede266b7561e6e365e86396/third_party/blink/public/web/web_remote_frame.h
[modify] https://crrev.com/792fcc3ac0290a37dede266b7561e6e365e86396/third_party/blink/public/web/web_shared_worker.h
[modify] https://crrev.com/792fcc3ac0290a37dede266b7561e6e365e86396/third_party/blink/renderer/core/exported/web_shared_worker_impl.h
[modify] https://crrev.com/792fcc3ac0290a37dede266b7561e6e365e86396/third_party/blink/renderer/platform/network/content_security_policy_parsers.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f236df12021640e9c9e0116d84c8f2914c3ee8c

commit 1f236df12021640e9c9e0116d84c8f2914c3ee8c
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Thu Dec 06 06:55:27 2018

Worker: Move shared_worker_info.mojom from content/ to blink/ (Onion Soup)

Change-Id: Ieb3f3b689f266d0d6c88824accd31a752dd66cbe
Bug: 911415
Reviewed-on: https://chromium-review.googlesource.com/c/1360036
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614284}
[modify] https://crrev.com/1f236df12021640e9c9e0116d84c8f2914c3ee8c/content/browser/worker_host/mock_shared_worker.cc
[modify] https://crrev.com/1f236df12021640e9c9e0116d84c8f2914c3ee8c/content/browser/worker_host/mock_shared_worker.h
[modify] https://crrev.com/1f236df12021640e9c9e0116d84c8f2914c3ee8c/content/browser/worker_host/shared_worker_connector_impl.cc
[modify] https://crrev.com/1f236df12021640e9c9e0116d84c8f2914c3ee8c/content/browser/worker_host/shared_worker_connector_impl.h
[modify] https://crrev.com/1f236df12021640e9c9e0116d84c8f2914c3ee8c/content/browser/worker_host/shared_worker_host.cc
[modify] https://crrev.com/1f236df12021640e9c9e0116d84c8f2914c3ee8c/content/browser/worker_host/shared_worker_service_impl.cc
[modify] https://crrev.com/1f236df12021640e9c9e0116d84c8f2914c3ee8c/content/browser/worker_host/shared_worker_service_impl.h
[modify] https://crrev.com/1f236df12021640e9c9e0116d84c8f2914c3ee8c/content/browser/worker_host/shared_worker_service_impl_unittest.cc
[modify] https://crrev.com/1f236df12021640e9c9e0116d84c8f2914c3ee8c/content/common/BUILD.gn
[modify] https://crrev.com/1f236df12021640e9c9e0116d84c8f2914c3ee8c/content/common/shared_worker/shared_worker_connector.mojom
[modify] https://crrev.com/1f236df12021640e9c9e0116d84c8f2914c3ee8c/content/common/shared_worker/shared_worker_factory.mojom
[modify] https://crrev.com/1f236df12021640e9c9e0116d84c8f2914c3ee8c/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/1f236df12021640e9c9e0116d84c8f2914c3ee8c/content/renderer/shared_worker/embedded_shared_worker_stub.h
[modify] https://crrev.com/1f236df12021640e9c9e0116d84c8f2914c3ee8c/content/renderer/shared_worker/shared_worker_factory_impl.cc
[modify] https://crrev.com/1f236df12021640e9c9e0116d84c8f2914c3ee8c/content/renderer/shared_worker/shared_worker_factory_impl.h
[modify] https://crrev.com/1f236df12021640e9c9e0116d84c8f2914c3ee8c/content/renderer/shared_worker/shared_worker_repository.cc
[modify] https://crrev.com/1f236df12021640e9c9e0116d84c8f2914c3ee8c/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/1f236df12021640e9c9e0116d84c8f2914c3ee8c/third_party/blink/public/mojom/worker/shared_worker_info.mojom

Comment 6 by nhiroki@google.com, Dec 6

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86d9e0e9690613df6b2303795e9366e960e243bd

commit 86d9e0e9690613df6b2303795e9366e960e243bd
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Thu Dec 06 10:55:00 2018

Worker: Move shared_worker_host.mojom from content/ to blink/ (Onion Soup)

Bug: 911415
Change-Id: If442d03c009fd934dc4f6700b63dc435af381093
Reviewed-on: https://chromium-review.googlesource.com/c/1364993
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614310}
[modify] https://crrev.com/86d9e0e9690613df6b2303795e9366e960e243bd/content/browser/worker_host/mock_shared_worker.cc
[modify] https://crrev.com/86d9e0e9690613df6b2303795e9366e960e243bd/content/browser/worker_host/mock_shared_worker.h
[modify] https://crrev.com/86d9e0e9690613df6b2303795e9366e960e243bd/content/browser/worker_host/shared_worker_host.cc
[modify] https://crrev.com/86d9e0e9690613df6b2303795e9366e960e243bd/content/browser/worker_host/shared_worker_host.h
[modify] https://crrev.com/86d9e0e9690613df6b2303795e9366e960e243bd/content/browser/worker_host/shared_worker_host_unittest.cc
[modify] https://crrev.com/86d9e0e9690613df6b2303795e9366e960e243bd/content/browser/worker_host/shared_worker_service_impl_unittest.cc
[modify] https://crrev.com/86d9e0e9690613df6b2303795e9366e960e243bd/content/common/BUILD.gn
[modify] https://crrev.com/86d9e0e9690613df6b2303795e9366e960e243bd/content/common/shared_worker/shared_worker_factory.mojom
[modify] https://crrev.com/86d9e0e9690613df6b2303795e9366e960e243bd/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/86d9e0e9690613df6b2303795e9366e960e243bd/content/renderer/shared_worker/embedded_shared_worker_stub.h
[modify] https://crrev.com/86d9e0e9690613df6b2303795e9366e960e243bd/content/renderer/shared_worker/shared_worker_factory_impl.cc
[modify] https://crrev.com/86d9e0e9690613df6b2303795e9366e960e243bd/content/renderer/shared_worker/shared_worker_factory_impl.h
[modify] https://crrev.com/86d9e0e9690613df6b2303795e9366e960e243bd/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/86d9e0e9690613df6b2303795e9366e960e243bd/third_party/blink/public/mojom/worker/shared_worker_host.mojom
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e677766dedb2399fee8e8f3676eb1b2fc8b8953

commit 0e677766dedb2399fee8e8f3676eb1b2fc8b8953
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Thu Dec 06 14:55:38 2018

Worker: Move shared_worker_connector.mojom from content/ to blink/ (Onion Soup)

Bug: 911415
Change-Id: Ifab02f8eccba1f2501400150d9aa563e88f44ac8
Reviewed-on: https://chromium-review.googlesource.com/c/1365105
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614347}
[modify] https://crrev.com/0e677766dedb2399fee8e8f3676eb1b2fc8b8953/content/browser/worker_host/shared_worker_connector_impl.cc
[modify] https://crrev.com/0e677766dedb2399fee8e8f3676eb1b2fc8b8953/content/browser/worker_host/shared_worker_connector_impl.h
[modify] https://crrev.com/0e677766dedb2399fee8e8f3676eb1b2fc8b8953/content/browser/worker_host/shared_worker_service_impl.h
[modify] https://crrev.com/0e677766dedb2399fee8e8f3676eb1b2fc8b8953/content/browser/worker_host/shared_worker_service_impl_unittest.cc
[modify] https://crrev.com/0e677766dedb2399fee8e8f3676eb1b2fc8b8953/content/common/BUILD.gn
[modify] https://crrev.com/0e677766dedb2399fee8e8f3676eb1b2fc8b8953/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/0e677766dedb2399fee8e8f3676eb1b2fc8b8953/content/renderer/shared_worker/shared_worker_repository.h
[modify] https://crrev.com/0e677766dedb2399fee8e8f3676eb1b2fc8b8953/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/0e677766dedb2399fee8e8f3676eb1b2fc8b8953/third_party/blink/public/mojom/worker/shared_worker_connector.mojom
[modify] https://crrev.com/0e677766dedb2399fee8e8f3676eb1b2fc8b8953/tools/metrics/histograms/enums.xml
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c0a7e70cc81c15f7d63349465327fbb0d30755c

commit 7c0a7e70cc81c15f7d63349465327fbb0d30755c
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Mon Dec 10 04:31:29 2018

DevTools: Move devtools_agent.mojom from public/web/ to public/mojom/devtools

This CL just moves devtools_agent.mojom from public/web/ to
public/mojom/devtools/ for cleanup.

This is useful for onion-soupifying shared workers without an additional
dependency in BUILD.gn.

Bug: 911415
Change-Id: I19aaf2fb8283b69fa44c4573b30a2cfe5955b94f
Reviewed-on: https://chromium-review.googlesource.com/c/1368084
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615043}
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/content/browser/DEPS
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/content/browser/devtools/devtools_renderer_channel.h
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/content/browser/devtools/devtools_session.h
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/content/browser/devtools/service_worker_devtools_agent_host.h
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/content/browser/devtools/service_worker_devtools_manager.h
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/content/browser/devtools/shared_worker_devtools_agent_host.cc
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/content/browser/devtools/worker_devtools_agent_host.h
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/content/browser/worker_host/shared_worker_host.h
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/content/common/frame.mojom
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/content/common/shared_worker/shared_worker.mojom
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/content/renderer/shared_worker/embedded_shared_worker_stub.h
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/third_party/blink/public/mojom/devtools/OWNERS
[add] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/third_party/blink/public/mojom/devtools/README.md
[rename] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/third_party/blink/public/mojom/devtools/devtools_agent.mojom
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/third_party/blink/renderer/core/exported/web_shared_worker_impl.cc
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/third_party/blink/renderer/core/frame/web_local_frame_impl.h
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/third_party/blink/renderer/core/inspector/devtools_agent.h
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/third_party/blink/renderer/core/inspector/devtools_session.h
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/third_party/blink/renderer/core/inspector/inspector_session_state.h
[modify] https://crrev.com/7c0a7e70cc81c15f7d63349465327fbb0d30755c/third_party/blink/renderer/core/inspector/worker_devtools_params.h
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2da3b583997344f70bd2c41097308b9e042b7d0c

commit 2da3b583997344f70bd2c41097308b9e042b7d0c
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Mon Dec 10 06:44:52 2018

Worker: Move shared_worker.mojom from content/ to blink/ (Onion Soup)

Bug: 911415
Change-Id: Icd73af86a411dbd8359299ede2f82fc7337f335d
Reviewed-on: https://chromium-review.googlesource.com/c/1368085
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615059}
[modify] https://crrev.com/2da3b583997344f70bd2c41097308b9e042b7d0c/content/browser/worker_host/mock_shared_worker.cc
[modify] https://crrev.com/2da3b583997344f70bd2c41097308b9e042b7d0c/content/browser/worker_host/mock_shared_worker.h
[modify] https://crrev.com/2da3b583997344f70bd2c41097308b9e042b7d0c/content/browser/worker_host/shared_worker_host.h
[modify] https://crrev.com/2da3b583997344f70bd2c41097308b9e042b7d0c/content/browser/worker_host/shared_worker_host_unittest.cc
[modify] https://crrev.com/2da3b583997344f70bd2c41097308b9e042b7d0c/content/browser/worker_host/shared_worker_service_impl_unittest.cc
[modify] https://crrev.com/2da3b583997344f70bd2c41097308b9e042b7d0c/content/common/BUILD.gn
[modify] https://crrev.com/2da3b583997344f70bd2c41097308b9e042b7d0c/content/common/shared_worker/shared_worker_factory.mojom
[modify] https://crrev.com/2da3b583997344f70bd2c41097308b9e042b7d0c/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/2da3b583997344f70bd2c41097308b9e042b7d0c/content/renderer/shared_worker/embedded_shared_worker_stub.h
[modify] https://crrev.com/2da3b583997344f70bd2c41097308b9e042b7d0c/content/renderer/shared_worker/shared_worker_factory_impl.cc
[modify] https://crrev.com/2da3b583997344f70bd2c41097308b9e042b7d0c/content/renderer/shared_worker/shared_worker_factory_impl.h
[modify] https://crrev.com/2da3b583997344f70bd2c41097308b9e042b7d0c/third_party/blink/public/mojom/BUILD.gn
[rename] https://crrev.com/2da3b583997344f70bd2c41097308b9e042b7d0c/third_party/blink/public/mojom/worker/shared_worker.mojom

Comment 11 by nhiroki@chromium.org, Dec 10

Description: Show this description
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43558d886bc744212ce6eaf854fb87d6eec440b9

commit 43558d886bc744212ce6eaf854fb87d6eec440b9
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Mon Dec 10 08:14:43 2018

Worker: Remove SharedWorkerClientImpl and SharedWorkerRepository (Onion Soup)

This CL removes some classes in content/renderer/shared_worker/ as a part of the
Onion Soup project.

Specifically, this merges...

  - content/renderer/shared_worker/shared_worker_client_impl.{cc,h}
  - content/renderer/shared_worker/shared_worker_repository.{cc,h}

into

  - third_party/blink/renderer/core/exported/shared_worker_repository_client_impl.{cc,h}

Also, this removes following interfaces that are no longer used:

  - third_party/blink/public/web/web_shared_worker_connect_listener.h
  - third_party/blink/public/web/web_shared_worker_repository_client.h

Probably we should rename some classes based on the new class relationship. The
next CL will do that.

Change-Id: I51fd32b1ca33bfc7bb60f144e6b394c880b3e68d
Bug: 911415
Reviewed-on: https://chromium-review.googlesource.com/c/1361757
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615066}
[modify] https://crrev.com/43558d886bc744212ce6eaf854fb87d6eec440b9/content/renderer/BUILD.gn
[modify] https://crrev.com/43558d886bc744212ce6eaf854fb87d6eec440b9/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/43558d886bc744212ce6eaf854fb87d6eec440b9/content/renderer/render_frame_impl.h
[delete] https://crrev.com/4b05c21182e9ab5715389b016ae38a67484281d7/content/renderer/shared_worker/shared_worker_client_impl.cc
[delete] https://crrev.com/4b05c21182e9ab5715389b016ae38a67484281d7/content/renderer/shared_worker/shared_worker_client_impl.h
[delete] https://crrev.com/4b05c21182e9ab5715389b016ae38a67484281d7/content/renderer/shared_worker/shared_worker_repository.cc
[delete] https://crrev.com/4b05c21182e9ab5715389b016ae38a67484281d7/content/renderer/shared_worker/shared_worker_repository.h
[modify] https://crrev.com/43558d886bc744212ce6eaf854fb87d6eec440b9/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/43558d886bc744212ce6eaf854fb87d6eec440b9/third_party/blink/public/mojom/worker/shared_worker_client.mojom
[modify] https://crrev.com/43558d886bc744212ce6eaf854fb87d6eec440b9/third_party/blink/public/web/web_local_frame.h
[delete] https://crrev.com/4b05c21182e9ab5715389b016ae38a67484281d7/third_party/blink/public/web/web_shared_worker_connect_listener.h
[delete] https://crrev.com/4b05c21182e9ab5715389b016ae38a67484281d7/third_party/blink/public/web/web_shared_worker_repository_client.h
[modify] https://crrev.com/43558d886bc744212ce6eaf854fb87d6eec440b9/third_party/blink/renderer/core/exported/shared_worker_repository_client_impl.cc
[modify] https://crrev.com/43558d886bc744212ce6eaf854fb87d6eec440b9/third_party/blink/renderer/core/exported/shared_worker_repository_client_impl.h
[modify] https://crrev.com/43558d886bc744212ce6eaf854fb87d6eec440b9/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/43558d886bc744212ce6eaf854fb87d6eec440b9/third_party/blink/renderer/core/frame/web_local_frame_impl.h
[modify] https://crrev.com/43558d886bc744212ce6eaf854fb87d6eec440b9/third_party/blink/renderer/core/workers/shared_worker.cc
[modify] https://crrev.com/43558d886bc744212ce6eaf854fb87d6eec440b9/third_party/blink/renderer/core/workers/shared_worker.idl
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c23362773a94551285d023d48d8af0f734186965

commit c23362773a94551285d023d48d8af0f734186965
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Tue Dec 11 03:56:44 2018

Worker: Move SharedWorkerRepositoryClientImpl from core/exported/ to core/workers/

For cleanup, this CL moves SharedWorkerRepositoryClientImpl from core/exported/
to core/workers/, and merge it to SharedWorkerRepositoryClient.

Change-Id: I694198b596ef572f064fa0638e82251e53decc0f
Bug: 911415
Reviewed-on: https://chromium-review.googlesource.com/c/1369757
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615417}
[modify] https://crrev.com/c23362773a94551285d023d48d8af0f734186965/third_party/blink/renderer/core/exported/BUILD.gn
[modify] https://crrev.com/c23362773a94551285d023d48d8af0f734186965/third_party/blink/renderer/core/exported/local_frame_client_impl.cc
[delete] https://crrev.com/29d62643351b1cf142de933d7e785f64b5aac83c/third_party/blink/renderer/core/exported/shared_worker_repository_client_impl.h
[modify] https://crrev.com/c23362773a94551285d023d48d8af0f734186965/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/c23362773a94551285d023d48d8af0f734186965/third_party/blink/renderer/core/frame/web_local_frame_impl.h
[modify] https://crrev.com/c23362773a94551285d023d48d8af0f734186965/third_party/blink/renderer/core/workers/BUILD.gn
[rename] https://crrev.com/c23362773a94551285d023d48d8af0f734186965/third_party/blink/renderer/core/workers/shared_worker_repository_client.cc
[modify] https://crrev.com/c23362773a94551285d023d48d8af0f734186965/third_party/blink/renderer/core/workers/shared_worker_repository_client.h
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/220fc84e2fee980d98f20c276d454316a1974fee

commit 220fc84e2fee980d98f20c276d454316a1974fee
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Tue Dec 11 04:54:17 2018

Worker: Simplify ownership model of SharedWorkerRepositoryClient

Before this CL, SharedWorkerRepositoryClient is created in
RenderFrameImpl::Initialize() and owned by WebLocalFrameImpl[*]. This needed
unnecessary plumbing between blink/renderer and content/renderer.

This CL removes the path, and instead makes Document own
SharedWorkerRepositoryClient as Supplement<Document>. This changes the ownership
model of SharedWorkerRepositoryClient from per-Frame to per-Document, but it
shouldn't affect behavior. Also, this removes the mechanism to manage multiple
Documents from SharedWorkerRepositoryClient (see ClientMap/Set in the class). As
mentioned above, the client is a per-Frame (per-Document) object, and the
mechanism doesn't make sense.

[*] This was necessary for communicating with renderer's embedder but the path
was removed by recent refactorings (Onion Soup).

Bug: 911415
Change-Id: If9ae00b0fbdde99d8a0256dc7381fab5c72ff317
Reviewed-on: https://chromium-review.googlesource.com/c/1370224
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615432}
[modify] https://crrev.com/220fc84e2fee980d98f20c276d454316a1974fee/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/220fc84e2fee980d98f20c276d454316a1974fee/third_party/blink/public/web/web_local_frame.h
[modify] https://crrev.com/220fc84e2fee980d98f20c276d454316a1974fee/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/220fc84e2fee980d98f20c276d454316a1974fee/third_party/blink/renderer/core/exported/local_frame_client_impl.cc
[modify] https://crrev.com/220fc84e2fee980d98f20c276d454316a1974fee/third_party/blink/renderer/core/exported/local_frame_client_impl.h
[modify] https://crrev.com/220fc84e2fee980d98f20c276d454316a1974fee/third_party/blink/renderer/core/frame/local_frame_client.h
[modify] https://crrev.com/220fc84e2fee980d98f20c276d454316a1974fee/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/220fc84e2fee980d98f20c276d454316a1974fee/third_party/blink/renderer/core/frame/web_local_frame_impl.h
[modify] https://crrev.com/220fc84e2fee980d98f20c276d454316a1974fee/third_party/blink/renderer/core/workers/shared_worker.cc
[modify] https://crrev.com/220fc84e2fee980d98f20c276d454316a1974fee/third_party/blink/renderer/core/workers/shared_worker_repository_client.cc
[modify] https://crrev.com/220fc84e2fee980d98f20c276d454316a1974fee/third_party/blink/renderer/core/workers/shared_worker_repository_client.h
Project Member

Comment 16 by bugdroid1@chromium.org, Dec 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f820a670eede7c8c9d3def27ef0d7ebe53a1665

commit 7f820a670eede7c8c9d3def27ef0d7ebe53a1665
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Fri Dec 21 08:32:25 2018

Worker: Rename SharedWorkerRepositoryClient to SharedWorkerClientHolder

This CL renames SharedWorkerRepositoryClient and SharedWorkerConnectListener to
SharedWorkerClientHolder and SharedWorkerClient for cleanup.

Before this CL, the communication path for shared workers between a
document-side renderer process and the browser process as follows

  SharedWorkerRepositoryClient::Connect()
    -> SharedWorkerConnectListner::Connect()
       ---(renderer / browser)--->
         -> SharedWorkerConnectorImpl::Connect()
            -> SharedWorkerServiceImpl::ConnectToWorker()

After this CL, the communication path will be changed as follows:

  SharedWorkerClientHolder::Connect()
    -> SharedWorkerClient::Connect()
       ---(renderer / browser)--->
         -> SharedWorkerConnectorImpl::Connect()
            -> SharedWorkerServiceImpl::ConnectToWorker()

Bug: 911415
Change-Id: I7c66b6323c830fe9962a818fdf21323988067986
Reviewed-on: https://chromium-review.googlesource.com/c/1373270
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618482}
[modify] https://crrev.com/7f820a670eede7c8c9d3def27ef0d7ebe53a1665/third_party/blink/renderer/core/workers/BUILD.gn
[modify] https://crrev.com/7f820a670eede7c8c9d3def27ef0d7ebe53a1665/third_party/blink/renderer/core/workers/shared_worker.cc
[rename] https://crrev.com/7f820a670eede7c8c9d3def27ef0d7ebe53a1665/third_party/blink/renderer/core/workers/shared_worker_client.cc
[add] https://crrev.com/7f820a670eede7c8c9d3def27ef0d7ebe53a1665/third_party/blink/renderer/core/workers/shared_worker_client.h
[rename] https://crrev.com/7f820a670eede7c8c9d3def27ef0d7ebe53a1665/third_party/blink/renderer/core/workers/shared_worker_client_holder.cc
[rename] https://crrev.com/7f820a670eede7c8c9d3def27ef0d7ebe53a1665/third_party/blink/renderer/core/workers/shared_worker_client_holder.h
[delete] https://crrev.com/f6e87a44866c4860471163fc9fe217927bdb5a22/third_party/blink/renderer/core/workers/shared_worker_connect_listener.h

Comment 17 by nhiroki@chromium.org, Yesterday (27 hours ago)

Status: Assigned (was: Started)
To proceed with this issue, we need to onion-soupify RendererPreferences etc first.

Comment 18 by shimazu@chromium.org, Yesterday (27 hours ago)

Blockedon: 869748
As per c#17, it seems blocked on 869748.

Comment 19 by nhiroki@google.com, Yesterday (27 hours ago) 

Good to know that leon.han@ has already started working on it :)
►

Sign in to add a comment