New issue
Advanced search Search tips

Issue 911413 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocked on:
issue 904035



Sign in to add a comment

Add pixel tests for MP4 videos with rotation or aspect specified

Project Member Reported by zmo@chromium.org, Dec 4

Issue description

Rotation can be 90/180/270 degrees

We want to test both the direct composition path and the GLRenderer composition path
 
Blockedon: 904035
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/161f3975469bb19a3c2f3ef62dda1d58457f3691

commit 161f3975469bb19a3c2f3ef62dda1d58457f3691
Author: Zhenyao Mo <zmo@chromium.org>
Date: Wed Dec 05 03:30:00 2018

Add GPU pixel tests for MP4 videos with rotation and aspect specified.

BUG=911413,911895,911898
TEST=GPU bots, pixel
R=sunnyps@chromium.org,kbr@chromium.org

Change-Id: I2971656ae3f78c2ac62ebc4a2239d491fa438528
Reviewed-on: https://chromium-review.googlesource.com/c/1359953
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613849}
[modify] https://crrev.com/161f3975469bb19a3c2f3ef62dda1d58457f3691/chrome/test/BUILD.gn
[add] https://crrev.com/161f3975469bb19a3c2f3ef62dda1d58457f3691/content/test/data/gpu/pixel_video_mp4_four_colors_aspect_4x3.html
[add] https://crrev.com/161f3975469bb19a3c2f3ef62dda1d58457f3691/content/test/data/gpu/pixel_video_mp4_four_colors_rot_180.html
[add] https://crrev.com/161f3975469bb19a3c2f3ef62dda1d58457f3691/content/test/data/gpu/pixel_video_mp4_four_colors_rot_270.html
[add] https://crrev.com/161f3975469bb19a3c2f3ef62dda1d58457f3691/content/test/data/gpu/pixel_video_mp4_four_colors_rot_90.html
[modify] https://crrev.com/161f3975469bb19a3c2f3ef62dda1d58457f3691/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/161f3975469bb19a3c2f3ef62dda1d58457f3691/content/test/gpu/gpu_tests/pixel_test_pages.py
[modify] https://crrev.com/161f3975469bb19a3c2f3ef62dda1d58457f3691/media/test/data/README.md
[add] https://crrev.com/161f3975469bb19a3c2f3ef62dda1d58457f3691/media/test/data/four-colors-aspect-4x3.mp4
[add] https://crrev.com/161f3975469bb19a3c2f3ef62dda1d58457f3691/media/test/data/four-colors-rot-180.mp4
[add] https://crrev.com/161f3975469bb19a3c2f3ef62dda1d58457f3691/media/test/data/four-colors-rot-270.mp4
[add] https://crrev.com/161f3975469bb19a3c2f3ef62dda1d58457f3691/media/test/data/four-colors-rot-90.mp4

These tests fail on "Mac Pro FYI Release (AMD)":
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20Pro%20FYI%20Release%20%28AMD%29/3447

AssertionError: Expected pixel at [125, 5] (actual pixel (125, 5))  to be [255, 17, 24] but got [247, 0, 27]
AssertionError: Expected pixel at [5, 5] (actual pixel (5, 5))  to be [44, 255, 16] but got [61, 255, 25]
AssertionError: Expected pixel at [152, 5] (actual pixel (152, 5))  to be [12, 12, 255] but got [14, 0, 255]
AssertionError: Expected pixel at [152, 5] (actual pixel (152, 5))  to be [255, 17, 24] but got [247, 0, 27]

Going to skip them there.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cc18fde9f5d9526299203c9a335c4bdcea822e4

commit 0cc18fde9f5d9526299203c9a335c4bdcea822e4
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Wed Dec 05 18:22:33 2018

Mark Pixel_Video_MP4 tests with rotation or aspect Fail on Mac Pro AMD

TBR=zmo@chromium.org

Bug: 911413
Change-Id: Id179c47b230cced812664241b1c70972514cdf32
Reviewed-on: https://chromium-review.googlesource.com/c/1363630
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614030}
[modify] https://crrev.com/0cc18fde9f5d9526299203c9a335c4bdcea822e4/content/test/gpu/gpu_tests/pixel_expectations.py

Sign in to add a comment