New issue
Advanced search Search tips

Issue 911402 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Fix node revealing

Project Member Reported by paulir...@chromium.org, Dec 4

Issue description

Audits node revealing doesn't always work

See https://github.com/GoogleChrome/lighthouse/issues/2289
 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3ea44603d0ea32e222f5d03d4677867558502a9

commit a3ea44603d0ea32e222f5d03d4677867558502a9
Author: cjamcl@google.com <cjamcl@google.com>
Date: Tue Dec 04 14:44:47 2018

[DevTools] Audits: Fix broken DOM node revealing

Bug: 911402
Change-Id: I095e52915fd8fafb00c2e0adfbded2d35eb51ff3
Reviewed-on: https://chromium-review.googlesource.com/c/1359856
Commit-Queue: Connor Clark <cjamcl@google.com>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613545}
[modify] https://crrev.com/a3ea44603d0ea32e222f5d03d4677867558502a9/third_party/blink/renderer/devtools/front_end/audits2/Audits2ReportRenderer.js

Labels: Merge-Request-72
Pls apply appropriate OSs label.

Comment 5 Deleted

Labels: -OS-All OS-Chrome OS-Linux OS-Mac OS-Windows
How safe is this? Have you verified this in canary?
Safe. Trivial change to a developer tool.

Yes, it works as expected in Canary.
Project Member

Comment 9 by sheriffbot@chromium.org, Dec 12

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 12

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c94d57e05704086190e39863fe4d1f7548550375

commit c94d57e05704086190e39863fe4d1f7548550375
Author: Paul Irish <paulirish@chromium.org>
Date: Wed Dec 12 22:21:05 2018

[DevTools] Audits: Fix broken DOM node revealing

TBR=cjamcl@google.com

(cherry picked from commit a3ea44603d0ea32e222f5d03d4677867558502a9)

Bug: 911402
Change-Id: I095e52915fd8fafb00c2e0adfbded2d35eb51ff3
Reviewed-on: https://chromium-review.googlesource.com/c/1359856
Commit-Queue: Connor Clark <cjamcl@google.com>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613545}
Reviewed-on: https://chromium-review.googlesource.com/c/1374569
Reviewed-by: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#310}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/c94d57e05704086190e39863fe4d1f7548550375/third_party/blink/renderer/devtools/front_end/audits2/Audits2ReportRenderer.js

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/c94d57e05704086190e39863fe4d1f7548550375

Commit: c94d57e05704086190e39863fe4d1f7548550375
Author: paulirish@chromium.org
Commiter: paulirish@chromium.org
Date: 2018-12-12 22:21:05 +0000 UTC

[DevTools] Audits: Fix broken DOM node revealing

TBR=cjamcl@google.com

(cherry picked from commit a3ea44603d0ea32e222f5d03d4677867558502a9)

Bug: 911402
Change-Id: I095e52915fd8fafb00c2e0adfbded2d35eb51ff3
Reviewed-on: https://chromium-review.googlesource.com/c/1359856
Commit-Queue: Connor Clark <cjamcl@google.com>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613545}
Reviewed-on: https://chromium-review.googlesource.com/c/1374569
Reviewed-by: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#310}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
Components: Platform>DevTools
Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment