New issue
Advanced search Search tips

Issue 911374 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ToolbarActionViewInteractiveUITest.TestContextMenuOnOverflowedAction fails on CrOS

Project Member Reported by pkasting@chromium.org, Dec 4

Issue description

After https://chromium-review.googlesource.com/c/chromium/src/+/1351805 lands, re-enabling ToolbarActionViewInteractiveUITest.TestContextMenuOnOverflowedAction on CrOS will fail with the following stack:

[7060:7060:1203/172321.676566:FATAL:menu_controller.cc(1283)] Check failed: !active_mouse_view_tracker_->view().
#0 0x55597d576aaf base::debug::StackTrace::StackTrace()
#1 0x55597d4d624b logging::LogMessage::~LogMessage()
#2 0x55597d3f2822 views::MenuController::SetSelectionOnPointerDown()
#3 0x55597d3f25a9 views::MenuController::OnMousePressed()
#4 0x55597d433d17 views::Widget::OnMouseEvent()
#5 0x55597d4514fc views::DesktopNativeWidgetAura::OnMouseEvent()
#6 0x55597da7fbe3 ui::EventDispatcher::ProcessEvent()
#7 0x55597da7fa05 ui::EventDispatcherDelegate::DispatchEventToTarget()
#8 0x55597da7f976 ui::EventDispatcherDelegate::DispatchEvent()
#9 0x55597da80922 ui::EventProcessor::OnEventFromSource()
#10 0x55597da80ebe ui::EventSource::SendEventToSinkFromRewriter()
#11 0x55597e830b4d aura::WindowTreeClient::OnWindowInputEvent()
#12 0x55597a39d8cd ws::mojom::WindowTreeClientStubDispatch::Accept()
#13 0x55597d7e9756 mojo::InterfaceEndpointClient::HandleValidatedMessage()
#14 0x55597d7fa806 mojo::FilterChain::Accept()
#15 0x55597d7eaae5 mojo::InterfaceEndpointClient::HandleIncomingMessage()
#16 0x55597d7f04db mojo::internal::MultiplexRouter::ProcessIncomingMessage()
#17 0x55597d7ef900 mojo::internal::MultiplexRouter::Accept()
#18 0x55597d7fa806 mojo::FilterChain::Accept()
#19 0x55597d7e7559 mojo::Connector::ReadSingleMessage()
#20 0x55597d7e7f61 mojo::Connector::ReadAllAvailableMessages()
#21 0x55597d7e7e09 mojo::Connector::OnHandleReadyInternal()
#22 0x55597a209fe7 mojo::SimpleWatcher::DiscardReadyState()
#23 0x55597d8061f4 mojo::SimpleWatcher::OnHandleReady()
#24 0x55597a44d1b1 _ZN4base8internal7InvokerINS0_9BindStateIMN3viz14GpuServiceImplEFvN3gfx21GenericSharedMemoryIdEiRKN3gpu9SyncTokenEEJNS_7WeakPtrIS4_EES6_iS8_EEEFvvEE7RunImplISC_NSt3__15tupleIJSE_S6_iS8_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSJ_16integer_sequenceImJXspT1_EEEE
#25 0x55597d59ad71 base::debug::TaskAnnotator::RunTask()
#26 0x55597d4df250 base::MessageLoopImpl::RunTask()
#27 0x55597d4df813 base::MessageLoopImpl::DoWork()
#28 0x55597d595a49 base::MessagePumpLibevent::Run()
#29 0x55597d4dedf8 base::MessageLoopImpl::Run()
#30 0x55597d505bc9 base::RunLoop::Run()
#31 0x55597d5061fa base::RunLoop::RunUntilIdle()
#32 0x5559794e1a18 ToolbarActionViewInteractiveUITest_TestContextMenuOnOverflowedAction_Test::RunTestOnMainThread()
#33 0x55597cdc3a19 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#34 0x55597c8a1f77 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#35 0x55597c8a0d2b ChromeBrowserMainParts::PreMainMessageLoopRun()
#36 0x55597b467820 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#37 0x55597a72fa95 content::BrowserMainLoop::PreMainMessageLoopRun()
#38 0x55597abeaf45 content::StartupTaskRunner::RunAllTasksNow()
#39 0x55597a72e795 content::BrowserMainLoop::CreateStartupTasks()
#40 0x55597a731d59 content::BrowserMainRunnerImpl::Initialize()
#41 0x55597a72c69b content::BrowserMain()
#42 0x55597c67c153 content::ContentMainRunnerImpl::RunServiceManager()
#43 0x55597c67c024 content::ContentMainRunnerImpl::Run()
#44 0x55597eaba356 service_manager::Main()
#45 0x55597c67a574 content::ContentMain()
#46 0x55597cdc360c content::BrowserTestBase::SetUp()
#47 0x55597c891ce1 InProcessBrowserTest::SetUp()
#48 0x555979660110 testing::Test::Run()
#49 0x555979660eaf testing::TestInfo::Run()
#50 0x5559796613d7 testing::TestCase::Run()
#51 0x55597966d617 testing::internal::UnitTestImpl::RunAllTests()
#52 0x55597966d18d testing::UnitTest::Run()
#53 0x55597d4b1f71 base::TestSuite::Run()
#54 0x55597945faf3 InteractiveUITestSuiteRunner::RunTestSuite()
#55 0x55597cdcd9da content::LaunchTests()
#56 0x55597c88b933 LaunchChromeTests()
#57 0x55597945fa9d main
#58 0x7f20fae5bf45 __libc_start_main
#59 0x55597932df0a _start

In other words, the menu controller believes the mouse is already down on something when processing the mouse click.  I don't know why this is, and numerous attempts to wait for the menu to appear and/or RunLoop()::RunUntilIdle() in various places have not helped.
 

Sign in to add a comment