New issue
Advanced search Search tips

Issue 911371 link

Starred by 1 user
Status: Fixed
Owner:
tbarzic@chromium.org
Closed: Dec 4
Cc:
benchan@chromium.org
r...@chromium.org
tonydeluna@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Setting kCertRevocationCheckingEnabled pref in chromeos::MobileActivator has no effect

Project Member Reported by tbarzic@chromium.org, Dec 4 
As part of preparation for LTE activation (which can be done through a captive portal), chromeos::MobileActivator disables  kCertRevocationCheckingEnabled pref in local state.

This has no effect any more given that ability for users to check this pref was removed some time ago:  https://crbug.com/361820 
The pref value is ignored, with cert revocation checks disabled by default, unless it's set by a policy. If the cert revocation is set by policy, that value will override pref value set at user level, so setting the value in chromeos::MobileActivator will have no effect either.

In short, kCertRevocationCheckingEnabled handling in chromeos::MobileActivator should be safe to remove.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16242d04769e4ab8d00b443ef118b7945b245ff9

commit 16242d04769e4ab8d00b443ef118b7945b245ff9
Author: Toni Barzic <tbarzic@chromium.org>
Date: Tue Dec 04 18:00:39 2018

Don't change cert revocations check pref in MobileActivator

The cert revocations checks can only be enabled by policy, in which
case changing the kCertRevocationCheckingEnabled pref value (at user
level) will have no effect, as it cannot override the managed pref
value.

In short, changing kCertRevocationCheckingEnabled user pref has no
effect anymore, so it can be removed from chromeos::MobileActivator
(this was not the case when this code was written, but the user option
to enable this preference has since removed).

BUG= 911371 

Change-Id: I67bd93edf29dbdaa0cde2d9c6db8b9776f9cd44b
Reviewed-on: https://chromium-review.googlesource.com/c/1359977
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613595}
[modify] https://crrev.com/16242d04769e4ab8d00b443ef118b7945b245ff9/chrome/browser/chromeos/mobile/mobile_activator.cc
[modify] https://crrev.com/16242d04769e4ab8d00b443ef118b7945b245ff9/chrome/browser/chromeos/mobile/mobile_activator.h

Comment 2 by tbarzic@chromium.org, Dec 4

Status: Fixed (was: Assigned)
►

Sign in to add a comment