New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 911354 link

Starred by 1 user
Status: Assigned
Owner:
yhanada@chromium.org
Cc:
█ omakoto@google.com
osh...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ARC++ apps can't get volume-up/down keys

Project Member Reported by mukai@chromium.org, Dec 4 
Chrome Version: 71.0.3578.57
OS: ChromeOS

What steps will reproduce the problem?
(1) install Kindle, open it
(2) go "more" > "settings", and enable "volume buttons control"
(3) open a book
(4) press volume up or down key

What is the expected result?
- page moves according to the volume button

What happens instead?
- volume changes on OS



Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by omakoto@google.com, Dec 4

Cc: omakoto@google.com
Thanks Mukai for filing the bug for me!

Note that I saw this behavior on my Pixel Slate, which has no media buttons. What I used was https://amzn.com/B00RM75NL0, which acts as a BT keyboard with media buttons.

The Play Books android app has the same feature, so I double checked with it and the device doesn't work with Play Books either.

Note even on a regular android device, the volume buttons on a BT headset *won't* work with Kindle/Play Books. But the above device (and many "remote BT shutter" devices) will be connected as a keyboard, and it *will* work with Kindle/Play Books on a regular android device.

Comment 2 by omakoto@google.com, Dec 4 

(Mukai pointed out the slate has the volume buttons. They didn't respond at all on my device... Until I rebooted it. And now I confirmed these on-device keys don't work on Kindle either.)

Comment 3 by yhanada@chromium.org, Dec 4

Cc: osh...@chromium.org
omakoto: Are volume-up/down keys intercepted by Kindle app? so device volume doesn't change while Kindle app opens on Android phone?

The ARC++ app windows don't have kCanConsumeSystemKeysKey property, so system keys are intercepted by PreTargetAcceleratorHandler before exo::Keyboard processes it.
We may want to add the property to the ARC++ app windows.
We already have a mechanism to fall back keys not handled by ARC++ apps to Chrome's accelerator handler, so it's okay to pass keys to ARC++ apps before Chrome's accelerator handler consumes it.

Comment 4 by osh...@chromium.org, Dec 4 

> We already have a mechanism to fall back keys not handled by ARC++ apps t...

That may not be true. IIRC, there was an app that consumed all keys even though they don't handle it. Is there an API to intercept power key?

Comment 5 by omakoto@google.com, Dec 4 

@yhanada yes, Kindle has an option for that. Note it only happens when you're reading a book and kindle is in full-screen. When you're browsing books, for example, the vol keys won't be intercepted. Play Books has the same option too.
►

Sign in to add a comment