New issue
Advanced search Search tips

Issue 911349 link

Starred by 1 user
Status: Assigned
Owner:
sunn...@chromium.org
Cc:
magchen@chromium.org
zmo@chromium.org
kkinnu...@nvidia.com
mcasas@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Videos show dark boundary where there should be none

Project Member Reported by zmo@chromium.org, Dec 4 
Here is one video we can clearly see at the right edge:

https://cs.chromium.org/chromium/src/media/test/data/four-colors.mp4

I think this only happens when downscaling, and we can reproduce this with TOT build, Canary, Beta, with --enable-direct-composition-layers, but can't reproduce with --disable-direct-composition-layers

Can't reproduce this with Stable (M70)

Comment 1 by sunn...@chromium.org, Dec 4 

The cause is most likely this change which made us select minimum of display size and content size as swap chain size: https://chromium-review.googlesource.com/c/chromium/src/+/1225295/

Before this we would set swap chain size to content size if g_supports_scaled_overlays is true which is the default value used when --enable-direct-composition-layers is passed to non hardware overlay supporting hardware.

I changed CalculateSwapChainSize to return content size and can't reproduce the bug.

Comment 2 by zmo@chromium.org, Dec 4

Cc: kkinnu...@nvidia.com
Labels: -Pri-1 GPU-NVidia Pri-2
I tried on Microsoft Surface with Intel GPU. This doesn't reproduce.

We can reliably reproduce on NVidia GPU. Will try with AMD GPU later.

Reduce to P2 since direct composition code path isn't usually taken on NVidia or AMD, where hardware overlays aren't supported. One potential exception is for the software protected videos.

Comment 3 by kkinnu...@nvidia.com, Dec 4

crbug-911349.html
666 bytes View Download
►

Sign in to add a comment