New issue
Advanced search Search tips

Issue 911333 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Rework StartLXDContainer to operate asynchronously

Project Member Reported by smbar...@chromium.org, Dec 4

Issue description

Starting an LXD container can cause a uid shift in the guest. This operation can take a long time, so we should treat starting a container as an async operation.
 
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b97206fb01a64095b479fd50d37d084543ca6c1e

commit b97206fb01a64095b479fd50d37d084543ca6c1e
Author: Stephen Barber <smbarber@chromium.org>
Date: Sat Dec 15 06:40:32 2018

system_api: vm_cicerone: add async StartLxdContainer

BUG=chromium:911333
TEST=vm.Crostini*

Change-Id: I7a98f6b87147f2892b86cfadb2c912c12a858add
Reviewed-on: https://chromium-review.googlesource.com/1375091
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/b97206fb01a64095b479fd50d37d084543ca6c1e/system_api/dbus/vm_cicerone/dbus-constants.h
[modify] https://crrev.com/b97206fb01a64095b479fd50d37d084543ca6c1e/system_api/dbus/vm_cicerone/cicerone_service.proto

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e5037dccfefd10a75873a9f4f8e516b56d47af9b

commit e5037dccfefd10a75873a9f4f8e516b56d47af9b
Author: Stephen Barber <smbarber@chromium.org>
Date: Mon Dec 17 00:26:17 2018

vm_tools: proto: add UpdateStartStatus RPC

Add an RPC for tremplin to inform the host asynchronously of a
container's start result.

BUG=chromium:911333
TEST=vm.Crostini*

Change-Id: I1b29fc436972024915d28e17ea3d338a75e311dc
Reviewed-on: https://chromium-review.googlesource.com/1375092
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/e5037dccfefd10a75873a9f4f8e516b56d47af9b/vm_tools/cicerone/tremplin_listener_impl.cc
[modify] https://crrev.com/e5037dccfefd10a75873a9f4f8e516b56d47af9b/vm_tools/cicerone/tremplin_listener_impl.h
[modify] https://crrev.com/e5037dccfefd10a75873a9f4f8e516b56d47af9b/vm_tools/proto/tremplin.proto

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tremplin/+/e0819858974d57c9f0b3beba487c13143dfd632b

commit e0819858974d57c9f0b3beba487c13143dfd632b
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Jan 03 02:14:05 2019

tremplin: implement async StartContainer

BUG=chromium:911333
TEST=vm.Crostini*
CQ-DEPEND=CL:1375092

Change-Id: I5e7c272a95c84bad8a4dffb0975d88b6ad122d0c
Reviewed-on: https://chromium-review.googlesource.com/1375349
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/e0819858974d57c9f0b3beba487c13143dfd632b/src/chromiumos/tremplin/tremplin.go

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7e32798f2f9e50f13d99896f346abb9211d81456

commit 7e32798f2f9e50f13d99896f346abb9211d81456
Author: Stephen Barber <smbarber@chromium.org>
Date: Sun Jan 06 04:08:39 2019

vm_tools: crostini_client: add async start support

BUG=chromium:911333
TEST=crostini_client vmc container ...

Change-Id: Icfed594fadee8e02b951ea9a3f05823737dd63f6
Reviewed-on: https://chromium-review.googlesource.com/1375094
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/7e32798f2f9e50f13d99896f346abb9211d81456/vm_tools/crostini_client/backends/chromeos.rs

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tremplin/+/0fad6fecfc6e56cfab5c23ef249efb3ee57be461

commit 0fad6fecfc6e56cfab5c23ef249efb3ee57be461
Author: Stephen Barber <smbarber@chromium.org>
Date: Thu Jan 17 13:16:28 2019

tremplin: allow container filesystem remaps

Chrome now requests async container startup, so let's allow container
ids to be remapped.

BUG=chromium:911333
TEST=vm.CrostiniStartEverything

Change-Id: I09ce74d757e4b0cfd6ce9b9c026819efe8772f86
Reviewed-on: https://chromium-review.googlesource.com/1416594
Commit-Ready: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>

[modify] https://crrev.com/0fad6fecfc6e56cfab5c23ef249efb3ee57be461/src/chromiumos/tremplin/main.go

Sign in to add a comment