New issue
Advanced search Search tips

Issue 911306 link

Starred by 1 user
Status: Fixed
Owner:
x...@chromium.org
Closed: Dec 21
Cc:
omrilio@chromium.org
mccanny@chromium.org
osh...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

In tablet mode, dragged tabs can't merge into a minimized overview browser window

Project Member Reported by x...@chromium.org, Dec 3 
Chrome Version: (copy from chrome://version)
OS: Chrome

What steps will reproduce the problem?
(1) Enter tablet mode
(2) Open a few browser windows. Tab on a browser window with one tab and drag it, notice that overview is opened below the dragged windows
(3) Drag the tab over the overview browser windows, we can see highlight shown that indicates the selection of the overview browser window. Release the tap, the dragged tab will merge into the selected overview browser window
(4) Tap on the launcher to minimize all windows
(5) Repeat step 2) and 3)

What is the expected result?
The dragged tab should be able to merge into an overview window that represents a minimized browser window

What happens instead?
The dragged tab can't be merged into an overview window that represents a minimized browser window
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/899b1678897ddbd0e0bda818d0cba1e57cce0f16

commit 899b1678897ddbd0e0bda818d0cba1e57cce0f16
Author: Xiaoqian Dai <xdai@chromium.org>
Date: Thu Dec 13 19:29:33 2018

tab dragging: merge into a minimized overview window.

Currently dragged tab(s) can't be merged into a browser window if it's
minimized and currently showing in overview, this CL makes the dragged
tab(s) be able to merge into such window.

Bug:  911306 
Change-Id: I82f76bd0dbd96771216d80ad109491a28d3cfb46
Reviewed-on: https://chromium-review.googlesource.com/c/1362461
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616393}
[modify] https://crrev.com/899b1678897ddbd0e0bda818d0cba1e57cce0f16/ash/wm/overview/scoped_transform_overview_window.cc
[modify] https://crrev.com/899b1678897ddbd0e0bda818d0cba1e57cce0f16/ash/wm/overview/scoped_transform_overview_window.h
[modify] https://crrev.com/899b1678897ddbd0e0bda818d0cba1e57cce0f16/ash/wm/overview/window_grid.cc
[modify] https://crrev.com/899b1678897ddbd0e0bda818d0cba1e57cce0f16/ash/wm/overview/window_grid.h
[modify] https://crrev.com/899b1678897ddbd0e0bda818d0cba1e57cce0f16/ash/wm/overview/window_selector_item.cc
[modify] https://crrev.com/899b1678897ddbd0e0bda818d0cba1e57cce0f16/ash/wm/overview/window_selector_item.h
[modify] https://crrev.com/899b1678897ddbd0e0bda818d0cba1e57cce0f16/ash/wm/window_finder.cc
[modify] https://crrev.com/899b1678897ddbd0e0bda818d0cba1e57cce0f16/ash/wm/window_finder.h
[modify] https://crrev.com/899b1678897ddbd0e0bda818d0cba1e57cce0f16/ash/wm/window_finder_unittest.cc
[modify] https://crrev.com/899b1678897ddbd0e0bda818d0cba1e57cce0f16/chrome/browser/BUILD.gn
[modify] https://crrev.com/899b1678897ddbd0e0bda818d0cba1e57cce0f16/chrome/browser/ui/views/tabs/tab_drag_controller.cc
[modify] https://crrev.com/899b1678897ddbd0e0bda818d0cba1e57cce0f16/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/899b1678897ddbd0e0bda818d0cba1e57cce0f16/chrome/browser/ui/views/tabs/window_finder_chromeos.cc
[modify] https://crrev.com/899b1678897ddbd0e0bda818d0cba1e57cce0f16/chrome/test/BUILD.gn

Comment 2 by x...@chromium.org, Dec 21

Status: Fixed (was: Assigned)
►

Sign in to add a comment