Issue metadata
Sign in to add a comment
|
media-video/yavta is not built with clang |
||||||||||||||||||||||
Issue descriptionyavta is using GCC to build itself. This was exposed by a CL that passed a GCC 4.9 incompatible flag. yavta-0.0.1-r2: make -j32 CROSS_COMPILE=x86_64-cros-linux-gnu- 'CFLAGS= -O2 -pipe -march=skylake -g -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -Iinclude' yavta-0.0.1-r2: x86_64-cros-linux-gnu-gcc -O2 -pipe -march=skylake -g -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -Iinclude -c -o yavta.o yavta.c yavta-0.0.1-r2: yavta.c:1:0: error: bad value (skylake) for -march= switch yavta-0.0.1-r2: /* yavta-0.0.1-r2: ^
,
Dec 4
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/75ae45e16af65d7afd68c819f2c0f1ccb1c70152 commit 75ae45e16af65d7afd68c819f2c0f1ccb1c70152 Author: Ricky Liang <jcliang@chromium.org> Date: Tue Dec 04 19:06:22 2018 media-video/yavta: use clang toolchain to build the package The new Makefile in yavta-20181204.tar.gz builds yavta with clang instead of gcc. BUG=chromium:911273 TEST=`emerge-<board> yavta` Change-Id: Idffc26b186d65a9e7e7c8a0339489852313b1357 Reviewed-on: https://chromium-review.googlesource.com/1360814 Commit-Ready: Ricky Liang <jcliang@chromium.org> Tested-by: Ricky Liang <jcliang@chromium.org> Reviewed-by: Shik Chen <shik@chromium.org> [rename] https://crrev.com/75ae45e16af65d7afd68c819f2c0f1ccb1c70152/media-video/yavta/yavta-0.0.1-r3.ebuild [modify] https://crrev.com/75ae45e16af65d7afd68c819f2c0f1ccb1c70152/media-video/yavta/Manifest
,
Dec 5
Thanks!
,
Dec 5
the ebuild needs to respect/set CC directly rather than hardcode it in the Makefile
,
Dec 5
Yes, if CC is hardcoded, that is not good either. What about other things like CFLAGS etc. Is yavta's makefile overriding or appending the flags.
,
Dec 5
when i looked it was just defaulting CFLAGS the Makefile can set up defaults (including CC), but the settings in the ebuild have to be respected. unfortunately, due to CC being a default var, the easiest way is to run `emake CC=...` in the ebuild rather than trying to tweak the Makefile. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by manojgupta@chromium.org
, Dec 3