Crostini task manager support doesn't recognize raw disk images |
||
Issue descriptionThe Chrome OS task manager was updated to show "Linux Virtual Machine: termina"-style entries for running VMs; however, it currently assumes that the disk image filename ends in .qcow2, which isn't necessarily true after the addition of raw disk image support.
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccd047d72ad33a67d0b0277e11f19b99f4bade62 commit ccd047d72ad33a67d0b0277e11f19b99f4bade62 Author: Daniel Verkamp <dverkamp@chromium.org> Date: Wed Dec 19 22:32:27 2018 Support Crostini raw disk images in task manager The original Crostini task manager support assumed that the disk image filename always ended in .qcow2. With raw disk image support now enabled in Chrome via DISK_IMAGE_AUTO, the filename may now end in .img instead. Since the read-only rootfs image also ends in .img, we need to add another check to filter it out. Signed-off-by: Daniel Verkamp <dverkamp@chromium.org> Change-Id: Icb15d2052db5fd535019ec7409fd6d24195dfbe2 Bug: 911263 Reviewed-on: https://chromium-review.googlesource.com/c/1359146 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#617987} [modify] https://crrev.com/ccd047d72ad33a67d0b0277e11f19b99f4bade62/chrome/browser/task_manager/providers/crostini/crostini_process_task_provider.cc
,
Jan 2
Verified with Chromium 73.0.3654.0 - VMs with both raw and qcow2 disk images show up in the task manager now. |
||
►
Sign in to add a comment |
||
Comment 1 by dverkamp@chromium.org
, Dec 3